All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-rt-devel:linux-5.9.y-rt-rebase 26/220] kernel/printk/printk.c:2791:2: warning: function 'vprintk_deferred' might be a candidate for 'gnu_printf' format attribute
@ 2020-09-28 18:56 kernel test robot
  2020-09-29 11:09 ` Sebastian Andrzej Siewior
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-09-28 18:56 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2341 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.9.y-rt-rebase
head:   9dd5279e0cf53370afb4b4982d7eecb230471932
commit: 6fc369f502c0d5e3ce1187494f651381eaa45435 [26/220] printk: remove unused code
config: parisc-randconfig-r026-20200928 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/commit/?id=6fc369f502c0d5e3ce1187494f651381eaa45435
        git remote add linux-rt-devel https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git
        git fetch --no-tags linux-rt-devel linux-5.9.y-rt-rebase
        git checkout 6fc369f502c0d5e3ce1187494f651381eaa45435
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   kernel/printk/printk.c:1987:5: warning: no previous prototype for 'vprintk_default' [-Wmissing-prototypes]
    1987 | int vprintk_default(const char *fmt, va_list args)
         |     ^~~~~~~~~~~~~~~
   kernel/printk/printk.c: In function 'vprintk_default':
   kernel/printk/printk.c:1989:2: warning: function 'vprintk_default' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    1989 |  return vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, 0, fmt, args);
         |  ^~~~~~
   kernel/printk/printk.c: In function 'vprintk_deferred':
>> kernel/printk/printk.c:2791:2: warning: function 'vprintk_deferred' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    2791 |  return vprintk_emit(0, LOGLEVEL_SCHED, NULL, 0, fmt, args);
         |  ^~~~~~

vim +2791 kernel/printk/printk.c

  2788	
  2789	static int vprintk_deferred(const char *fmt, va_list args)
  2790	{
> 2791		return vprintk_emit(0, LOGLEVEL_SCHED, NULL, 0, fmt, args);
  2792	}
  2793	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 24633 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [linux-rt-devel:linux-5.9.y-rt-rebase 26/220] kernel/printk/printk.c:2791:2: warning: function 'vprintk_deferred' might be a candidate for 'gnu_printf' format attribute
  2020-09-28 18:56 [linux-rt-devel:linux-5.9.y-rt-rebase 26/220] kernel/printk/printk.c:2791:2: warning: function 'vprintk_deferred' might be a candidate for 'gnu_printf' format attribute kernel test robot
@ 2020-09-29 11:09 ` Sebastian Andrzej Siewior
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2020-09-29 11:09 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

On 2020-09-29 02:56:24 [+0800], kernel test robot wrote:
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    kernel/printk/printk.c:1987:5: warning: no previous prototype for 'vprintk_default' [-Wmissing-prototypes]
>     1987 | int vprintk_default(const char *fmt, va_list args)
>          |     ^~~~~~~~~~~~~~~

I think I forgot to remove it since we are not using it anymore.

>    kernel/printk/printk.c: In function 'vprintk_default':
>    kernel/printk/printk.c:1989:2: warning: function 'vprintk_default' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
>     1989 |  return vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, 0, fmt, args);
>          |  ^~~~~~
>    kernel/printk/printk.c: In function 'vprintk_deferred':
> >> kernel/printk/printk.c:2791:2: warning: function 'vprintk_deferred' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
>     2791 |  return vprintk_emit(0, LOGLEVEL_SCHED, NULL, 0, fmt, args);
>          |  ^~~~~~

This was made static and the annotation was removed with the
declaration. Added.

Sebastian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-29 11:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 18:56 [linux-rt-devel:linux-5.9.y-rt-rebase 26/220] kernel/printk/printk.c:2791:2: warning: function 'vprintk_deferred' might be a candidate for 'gnu_printf' format attribute kernel test robot
2020-09-29 11:09 ` Sebastian Andrzej Siewior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.