[PATCH][next] fddi/skfp: Avoid the use of one-element array

[PATCH][next] fddi/skfp: Avoid the use of one-element array

[Gustavo A. R. Silva]

One-element arrays are being deprecated[1]. Replace the one-element array
with a simple object of type u_char: 'u_char rm_pad1'[2], once it seems
this is just a placeholder for padding.

[1] https://www.kernel.org/doc/html/v5.9-rc1/process/deprecated.html#zero-length-and-one-element-arrays
[2] https://github.com/KSPP/linux/issues/86

Built-tested-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/5f72c23f.%2FkPBWcZBu+W6HKH4%25lkp@intel.com/
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/net/fddi/skfp/h/smc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/fddi/skfp/h/smc.h b/drivers/net/fddi/skfp/h/smc.h
index 991857f6a83c..706fa619b703 100644
--- a/drivers/net/fddi/skfp/h/smc.h
+++ b/drivers/net/fddi/skfp/h/smc.h
@@ -122,7 +122,7 @@ struct s_rmt {
 	u_char timer1_exp ;		/* flag : timer 1 expired */
 	u_char timer2_exp ;		/* flag : timer 2 expired */
 
-	u_char rm_pad1[1] ;
+	u_char rm_pad1;
 } ;
 
 /*
-- 
2.27.0

Re: [PATCH][next] fddi/skfp: Avoid the use of one-element array

[David Miller]

From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Date: Tue, 29 Sep 2020 08:27:51 -0500

> One-element arrays are being deprecated[1]. Replace the one-element array
> with a simple object of type u_char: 'u_char rm_pad1'[2], once it seems
> this is just a placeholder for padding.
> 
> [1] https://www.kernel.org/doc/html/v5.9-rc1/process/deprecated.html#zero-length-and-one-element-arrays
> [2] https://github.com/KSPP/linux/issues/86
> 
> Built-tested-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/lkml/5f72c23f.%2FkPBWcZBu+W6HKH4%25lkp@intel.com/
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Applied, thanks.