* [kvm:queue 136/148] arch/x86/kvm/vmx/vmx.c:440:11: sparse: sparse: symbol 'vmx_uret_msrs_list' was not declared. Should it be
@ 2020-09-28 15:37 kernel test robot
2020-09-28 15:37 ` kernel test robot
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2020-09-28 15:37 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]
tree: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
head: 0c899c25d754ae386940f0e1b86b31d3921480b6
commit: 14a61b642de9e5612f091b3295da6d0c89449a49 [136/148] KVM: VMX: Rename "vmx_msr_index" to "vmx_uret_msrs_list"
config: i386-randconfig-s001-20200928 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-201-g24bdaac6-dirty
# https://git.kernel.org/pub/scm/virt/kvm/kvm.git/commit/?id=14a61b642de9e5612f091b3295da6d0c89449a49
git remote add kvm https://git.kernel.org/pub/scm/virt/kvm/kvm.git
git fetch --no-tags kvm queue
git checkout 14a61b642de9e5612f091b3295da6d0c89449a49
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kvm/vmx/vmx.c:440:11: sparse: sparse: symbol 'vmx_uret_msrs_list' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37122 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC PATCH kvm] KVM: VMX: vmx_uret_msrs_list[] can be static
2020-09-28 15:37 [kvm:queue 136/148] arch/x86/kvm/vmx/vmx.c:440:11: sparse: sparse: symbol 'vmx_uret_msrs_list' was not declared. Should it be kernel test robot
@ 2020-09-28 15:37 ` kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2020-09-28 15:37 UTC (permalink / raw)
To: Sean Christopherson
Cc: kbuild-all, kvm, Robert Hu, Farrah Chen, Danmei Wei, Paolo Bonzini
Fixes: 14a61b642de9 ("KVM: VMX: Rename "vmx_msr_index" to "vmx_uret_msrs_list"")
Signed-off-by: kernel test robot <lkp@intel.com>
---
vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 07781403db08a2..b20ef136894acc 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -437,7 +437,7 @@ static unsigned long host_idt_base;
* support this emulation, IA32_STAR must always be included in
* vmx_uret_msrs_list[], even in i386 builds.
*/
-const u32 vmx_uret_msrs_list[] = {
+static const u32 vmx_uret_msrs_list[] = {
#ifdef CONFIG_X86_64
MSR_SYSCALL_MASK, MSR_LSTAR, MSR_CSTAR,
#endif
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RFC PATCH kvm] KVM: VMX: vmx_uret_msrs_list[] can be static
@ 2020-09-28 15:37 ` kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2020-09-28 15:37 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
Fixes: 14a61b642de9 ("KVM: VMX: Rename "vmx_msr_index" to "vmx_uret_msrs_list"")
Signed-off-by: kernel test robot <lkp@intel.com>
---
vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 07781403db08a2..b20ef136894acc 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -437,7 +437,7 @@ static unsigned long host_idt_base;
* support this emulation, IA32_STAR must always be included in
* vmx_uret_msrs_list[], even in i386 builds.
*/
-const u32 vmx_uret_msrs_list[] = {
+static const u32 vmx_uret_msrs_list[] = {
#ifdef CONFIG_X86_64
MSR_SYSCALL_MASK, MSR_LSTAR, MSR_CSTAR,
#endif
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC PATCH kvm] KVM: VMX: vmx_uret_msrs_list[] can be static
2020-09-28 15:37 ` kernel test robot
@ 2020-09-30 0:17 ` Sean Christopherson
-1 siblings, 0 replies; 5+ messages in thread
From: Sean Christopherson @ 2020-09-30 0:17 UTC (permalink / raw)
To: kernel test robot
Cc: kbuild-all, kvm, Robert Hu, Farrah Chen, Danmei Wei, Paolo Bonzini
On Mon, Sep 28, 2020 at 11:37:14PM +0800, kernel test robot wrote:
>
> Fixes: 14a61b642de9 ("KVM: VMX: Rename "vmx_msr_index" to "vmx_uret_msrs_list"")
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-30 0:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 15:37 [kvm:queue 136/148] arch/x86/kvm/vmx/vmx.c:440:11: sparse: sparse: symbol 'vmx_uret_msrs_list' was not declared. Should it be kernel test robot
2020-09-28 15:37 ` [RFC PATCH kvm] KVM: VMX: vmx_uret_msrs_list[] can be static kernel test robot
2020-09-28 15:37 ` kernel test robot
2020-09-30 0:17 ` Sean Christopherson
2020-09-30 0:17 ` Sean Christopherson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.