* [PATCH] drm/ingenic: remove redundant null check
@ 2020-09-30 8:24 ` Xu Wang
0 siblings, 0 replies; 2+ messages in thread
From: Xu Wang @ 2020-09-30 8:24 UTC (permalink / raw)
To: paul, airlied, daniel; +Cc: dri-devel, linux-kernel
Because clk_disable_unprepare already checked NULL clock parameter,
so the additional checks are unnecessary, just remove them.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index b7074161ccf0..9dce02e779ad 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -932,8 +932,7 @@ static int ingenic_drm_bind(struct device *dev, bool has_components)
return 0;
err_devclk_disable:
- if (priv->lcd_clk)
- clk_disable_unprepare(priv->lcd_clk);
+ clk_disable_unprepare(priv->lcd_clk);
err_pixclk_disable:
clk_disable_unprepare(priv->pix_clk);
return ret;
@@ -953,8 +952,7 @@ static void ingenic_drm_unbind(struct device *dev)
{
struct ingenic_drm *priv = dev_get_drvdata(dev);
- if (priv->lcd_clk)
- clk_disable_unprepare(priv->lcd_clk);
+ clk_disable_unprepare(priv->lcd_clk);
clk_disable_unprepare(priv->pix_clk);
drm_dev_unregister(&priv->drm);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] drm/ingenic: remove redundant null check
@ 2020-09-30 8:24 ` Xu Wang
0 siblings, 0 replies; 2+ messages in thread
From: Xu Wang @ 2020-09-30 8:24 UTC (permalink / raw)
To: paul, airlied, daniel; +Cc: linux-kernel, dri-devel
Because clk_disable_unprepare already checked NULL clock parameter,
so the additional checks are unnecessary, just remove them.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index b7074161ccf0..9dce02e779ad 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -932,8 +932,7 @@ static int ingenic_drm_bind(struct device *dev, bool has_components)
return 0;
err_devclk_disable:
- if (priv->lcd_clk)
- clk_disable_unprepare(priv->lcd_clk);
+ clk_disable_unprepare(priv->lcd_clk);
err_pixclk_disable:
clk_disable_unprepare(priv->pix_clk);
return ret;
@@ -953,8 +952,7 @@ static void ingenic_drm_unbind(struct device *dev)
{
struct ingenic_drm *priv = dev_get_drvdata(dev);
- if (priv->lcd_clk)
- clk_disable_unprepare(priv->lcd_clk);
+ clk_disable_unprepare(priv->lcd_clk);
clk_disable_unprepare(priv->pix_clk);
drm_dev_unregister(&priv->drm);
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-01 8:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 8:24 [PATCH] drm/ingenic: remove redundant null check Xu Wang
2020-09-30 8:24 ` Xu Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.