From: Daniel Vetter <daniel@ffwll.ch> To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>, Jonathan Corbet <corbet@lwn.net>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 20/52] drm: drm_dsc.h: fix a kernel-doc markup Date: Wed, 30 Sep 2020 16:42:34 +0200 [thread overview] Message-ID: <20200930144234.GB438822@phenom.ffwll.local> (raw) In-Reply-To: <3d467022325e15bba8dcb13da8fb730099303266.1601467849.git.mchehab+huawei@kernel.org> On Wed, Sep 30, 2020 at 03:24:43PM +0200, Mauro Carvalho Chehab wrote: > As warned by Sphinx: > > ./Documentation/gpu/drm-kms-helpers:305: ./include/drm/drm_dsc.h:587: WARNING: Unparseable C cross-reference: 'struct' > Invalid C declaration: Expected identifier in nested name, got keyword: struct [error at 6] > struct > ------^ > > The markup for one struct is wrong, as struct is used twice. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Applied to drm-misc-fixes, thanks for your patch. -Daniel > --- > include/drm/drm_dsc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_dsc.h b/include/drm/drm_dsc.h > index 887954cbfc60..732f32740c86 100644 > --- a/include/drm/drm_dsc.h > +++ b/include/drm/drm_dsc.h > @@ -588,7 +588,7 @@ struct drm_dsc_picture_parameter_set { > * This structure represents the DSC PPS infoframe required to send the Picture > * Parameter Set metadata required before enabling VESA Display Stream > * Compression. This is based on the DP Secondary Data Packet structure and > - * comprises of SDP Header as defined &struct struct dp_sdp_header in drm_dp_helper.h > + * comprises of SDP Header as defined &struct dp_sdp_header in drm_dp_helper.h > * and PPS payload defined in &struct drm_dsc_picture_parameter_set. > * > * @pps_header: Header for PPS as per DP SDP header format of type > -- > 2.26.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de>, Jonathan Corbet <corbet@lwn.net>, David Airlie <airlied@linux.ie>, Linux Doc Mailing List <linux-doc@vger.kernel.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 20/52] drm: drm_dsc.h: fix a kernel-doc markup Date: Wed, 30 Sep 2020 16:42:34 +0200 [thread overview] Message-ID: <20200930144234.GB438822@phenom.ffwll.local> (raw) In-Reply-To: <3d467022325e15bba8dcb13da8fb730099303266.1601467849.git.mchehab+huawei@kernel.org> On Wed, Sep 30, 2020 at 03:24:43PM +0200, Mauro Carvalho Chehab wrote: > As warned by Sphinx: > > ./Documentation/gpu/drm-kms-helpers:305: ./include/drm/drm_dsc.h:587: WARNING: Unparseable C cross-reference: 'struct' > Invalid C declaration: Expected identifier in nested name, got keyword: struct [error at 6] > struct > ------^ > > The markup for one struct is wrong, as struct is used twice. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Applied to drm-misc-fixes, thanks for your patch. -Daniel > --- > include/drm/drm_dsc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_dsc.h b/include/drm/drm_dsc.h > index 887954cbfc60..732f32740c86 100644 > --- a/include/drm/drm_dsc.h > +++ b/include/drm/drm_dsc.h > @@ -588,7 +588,7 @@ struct drm_dsc_picture_parameter_set { > * This structure represents the DSC PPS infoframe required to send the Picture > * Parameter Set metadata required before enabling VESA Display Stream > * Compression. This is based on the DP Secondary Data Packet structure and > - * comprises of SDP Header as defined &struct struct dp_sdp_header in drm_dp_helper.h > + * comprises of SDP Header as defined &struct dp_sdp_header in drm_dp_helper.h > * and PPS payload defined in &struct drm_dsc_picture_parameter_set. > * > * @pps_header: Header for PPS as per DP SDP header format of type > -- > 2.26.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-30 14:42 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-30 13:24 [PATCH v4 00/52] Fix html build with Sphinx 3.1 and above Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 01/52] docs: cdomain.py: add support for a new Sphinx 3.1+ tag Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 02/52] docs: cdomain.py: extend it to handle new Sphinx 3.x tags Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 03/52] docs: conf.py: disable automarkup for Sphinx 3.x Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 04/52] scripts: kernel-doc: make it more compatible with " Mauro Carvalho Chehab 2020-10-01 21:41 ` Jonathan Corbet 2020-10-01 23:02 ` Jonathan Corbet 2020-10-02 6:22 ` Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 05/52] scripts: kernel-doc: use a less pedantic markup for funcs on " Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 06/52] scripts: kernel-doc: fix troubles with line counts Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 07/52] scripts: kernel-doc: reimplement -nofunction argument Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 08/52] scripts: kernel-doc: fix typedef identification Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 09/52] scripts: kernel-doc: don't mangle with parameter list Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 10/52] docs: kerneldoc.py: append the name of the parsed doc file Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 11/52] docs: kerneldoc.py: add support for kerneldoc -nosymbol Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 12/52] media: docs: make CEC documents compatible with Sphinx 3.1+ Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 13/52] media: docs: make V4L documents more " Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 14/52] media: docs: make DVB " Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 15/52] media: docs: make MC " Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 16/52] media: docs: make RC " Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 17/52] media: cec-core.rst: don't use c:type for structs Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 18/52] math64.h: kernel-docs: Convert some markups into normal comments Mauro Carvalho Chehab 2020-09-30 13:46 ` Vincenzo Frascino 2020-09-30 13:24 ` [PATCH v4 19/52] memblock: get rid of a :c:type leftover Mauro Carvalho Chehab 2020-09-30 14:23 ` Mike Rapoport 2020-09-30 15:13 ` Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 20/52] drm: drm_dsc.h: fix a kernel-doc markup Mauro Carvalho Chehab 2020-09-30 13:24 ` Mauro Carvalho Chehab 2020-09-30 14:42 ` Daniel Vetter [this message] 2020-09-30 14:42 ` Daniel Vetter 2020-09-30 13:24 ` [PATCH v4 21/52] docs: remove some replace macros like |struct foo| Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 22/52] docs: get rid of :c:type explicit declarations for structs Mauro Carvalho Chehab 2020-09-30 13:24 ` Mauro Carvalho Chehab 2020-09-30 14:26 ` Mike Rapoport 2020-09-30 14:26 ` Mike Rapoport 2020-09-30 15:01 ` Takashi Iwai 2020-09-30 15:01 ` Takashi Iwai 2020-09-30 16:50 ` André Almeida 2020-09-30 16:50 ` André Almeida 2020-09-30 13:24 ` [PATCH v4 23/52] docs: trace-uses.rst: remove bogus c-domain tags Mauro Carvalho Chehab 2020-09-30 16:35 ` Steven Rostedt 2020-10-01 6:06 ` Kamalesh Babulal 2020-10-01 6:41 ` Mauro Carvalho Chehab 2020-10-01 8:27 ` Kamalesh Babulal 2020-09-30 13:24 ` [PATCH v4 24/52] docs: it_IT: fix namespace collisions at locking.rst Mauro Carvalho Chehab 2020-10-01 12:04 ` Federico Vaga 2020-09-30 13:24 ` [PATCH v4 25/52] docs: net: ieee802154.rst: fix C expressions Mauro Carvalho Chehab 2020-09-30 21:23 ` David Miller 2020-09-30 13:24 ` [PATCH v4 26/52] docs: genericirq.rst: don't document chip.c functions twice Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 27/52] docs: kernel-api.rst: drop kernel/irq/manage.c kernel-doc tag Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 28/52] docs: remove sound API duplication Mauro Carvalho Chehab 2020-09-30 13:24 ` Mauro Carvalho Chehab 2020-09-30 14:57 ` Takashi Iwai 2020-09-30 14:57 ` Takashi Iwai 2020-09-30 13:24 ` [PATCH v4 29/52] docs: basics.rst: move kernel-doc workqueue markups to workqueue.rst Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 30/52] docs: scsi: target.rst: remove iSCSI transport class kernel-doc markup Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 31/52] docs: device_link.rst: remove duplicated kernel-doc include Mauro Carvalho Chehab 2020-09-30 21:03 ` Saravana Kannan 2020-09-30 13:24 ` [PATCH v4 32/52] docs: basics.rst: get rid of rcu kernel-doc macros Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 33/52] docs: net: statistics.rst: remove a duplicated kernel-doc Mauro Carvalho Chehab 2020-09-30 21:23 ` David Miller 2020-09-30 13:24 ` [PATCH v4 34/52] docs: pstore-blk.rst: fix kernel-doc tags Mauro Carvalho Chehab 2020-09-30 23:23 ` Kees Cook 2020-09-30 13:24 ` [PATCH v4 35/52] docs: fs: fscrypt.rst: get rid of :c:type: tags Mauro Carvalho Chehab 2020-09-30 16:21 ` Eric Biggers 2020-09-30 16:53 ` Mauro Carvalho Chehab 2020-09-30 17:06 ` Eric Biggers 2020-10-05 12:06 ` Mauro Carvalho Chehab 2020-10-05 19:08 ` Eric Biggers 2020-10-06 8:23 ` Mauro Carvalho Chehab 2020-09-30 13:24 ` [PATCH v4 36/52] docs: devices.rst: get rid of :c:type macros Mauro Carvalho Chehab 2020-09-30 13:25 ` [PATCH v4 37/52] docs: sound: writing-an-alsa-driver.rst: get rid of :c:type Mauro Carvalho Chehab 2020-09-30 13:25 ` Mauro Carvalho Chehab 2020-09-30 14:59 ` Takashi Iwai 2020-09-30 14:59 ` Takashi Iwai 2020-09-30 13:25 ` [PATCH v4 38/52] docs: block: typec_bus.rst: " Mauro Carvalho Chehab 2020-09-30 16:48 ` André Almeida 2020-09-30 13:25 ` [PATCH v4 39/52] docs: writing-an-alsa-driver.rst: fix some bad c:func: markups Mauro Carvalho Chehab 2020-09-30 13:25 ` Mauro Carvalho Chehab 2020-09-30 14:58 ` Takashi Iwai 2020-09-30 14:58 ` Takashi Iwai 2020-09-30 13:25 ` [PATCH v4 40/52] docs: fpga: replace :c:member: macros Mauro Carvalho Chehab 2020-09-30 23:46 ` Moritz Fischer 2020-09-30 13:25 ` [PATCH v4 41/52] docs: kgdb.rst: fix :c:type: usages Mauro Carvalho Chehab 2020-10-01 11:29 ` Daniel Thompson 2020-09-30 13:25 ` [PATCH v4 42/52] docs: libata.rst: fix a wrong usage of :c:type: tag Mauro Carvalho Chehab 2020-09-30 13:25 ` [PATCH v4 43/52] docs: infrastructure.rst: don't include firmware kernel-doc Mauro Carvalho Chehab 2020-09-30 13:25 ` [PATCH v4 44/52] docs: gpu: i915.rst: Fix several C duplication warnings Mauro Carvalho Chehab 2020-09-30 13:25 ` [Intel-gfx] " Mauro Carvalho Chehab 2020-09-30 13:25 ` Mauro Carvalho Chehab 2020-09-30 13:25 ` [PATCH v4 45/52] docs: devices.rst: fix a C reference markup Mauro Carvalho Chehab 2020-09-30 13:25 ` [PATCH v4 46/52] docs: it_IT: hacking.rst: fix a typo on a markup Mauro Carvalho Chehab 2020-10-01 12:05 ` Federico Vaga 2020-09-30 13:25 ` [PATCH v4 47/52] docs: mei.rst: fix a C expression markup Mauro Carvalho Chehab 2020-09-30 20:30 ` Winkler, Tomas 2020-09-30 13:25 ` [PATCH v4 48/52] docs: basics.rst: avoid duplicated C function declaration Mauro Carvalho Chehab 2020-09-30 13:25 ` [PATCH v4 49/52] workqueue: fix a kernel-doc warning Mauro Carvalho Chehab 2020-09-30 15:57 ` Tejun Heo 2020-09-30 13:25 ` [PATCH v4 50/52] scripts: kernel-doc: try to use c:function if possible Mauro Carvalho Chehab 2020-09-30 13:25 ` [PATCH v4 51/52] docs: conf.py: fix c:function support with Sphinx 3.x Mauro Carvalho Chehab 2020-09-30 13:25 ` [PATCH v4 52/52] docs: conf.py: change the Sphinx 3.x+ text Mauro Carvalho Chehab 2020-10-01 21:48 ` [PATCH v4 00/52] Fix html build with Sphinx 3.1 and above Jonathan Corbet 2020-10-02 6:52 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200930144234.GB438822@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=airlied@linux.ie \ --cc=corbet@lwn.net \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mchehab+huawei@kernel.org \ --cc=mripard@kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.