Re: [PATCH v2] of: address: Work around missing device_type property in pcie nodes

From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Marc Zyngier <maz@kernel.org>
Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Frank Rowand <frowand.list@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	kernel-team@android.com, samuel@dionne-riel.com
Subject: Re: [PATCH v2] of: address: Work around missing device_type property in pcie nodes
Date: Wed, 30 Sep 2020 19:37:44 +0200	[thread overview]
Message-ID: <20200930173744.GG1516931@oden.dyn.berto.se> (raw)
In-Reply-To: <977f60f07a4cb5c59f0e5f8a9dfb3993@kernel.org>

Hi Marc,

On 2020-09-30 18:23:21 +0100, Marc Zyngier wrote:
> Hi Niklas,
> 
> [+ Samuel]
> 
> On 2020-09-30 17:27, Niklas Söderlund wrote:
> > Hi Marc,
> > 
> > I'm afraid this commit breaks booting my rk3399 device.
> > 
> > I bisected the problem to this patch merged as [1]. I'm testing on a
> > Scarlet device and I'm using the unmodified upstream
> > rk3399-gru-scarlet-inx.dtb for my tests.
> > 
> > The problem I'm experience is a black screen after the bootloader and
> > the device is none responsive over the network. I have no serial console
> > to this device so I'm afraid I can't tell you if there is anything
> > useful on to aid debugging there.
> > 
> > If I try to test one commit earlier [2] the system boots as expected and
> > everything works as it did for me in v5.8 and earlier. I have worked
> > little with this device and have no clue about what is really on the PCI
> > buss. But running from [2] I have this info about PCI if it's helpful,
> > please ask if somethings missing.
> 
> Please see the thread at [1]. The problem was reported a few weeks back
> by Samuel, and I was expecting Rob and Lorenzo to push a fix for this.

Thanks for providing a solution.

> 
> Rob, Lorenzo, any update on this?
> 
>         M.
> 
> [1]
> https://lore.kernel.org/linux-devicetree/20200829164920.7d28e01a@DUFFMAN/
> -- 
> Jazz is not dead. It just smells funny...

-- 
Regards,
Niklas Söderlund