[PATCH] RDMA/core: Remove ucontext->closing

[PATCH] RDMA/core: Remove ucontext->closing

[Jason Gunthorpe]

Nothing reads this any more, and the reason for its existance has passed
due to the deferred fput() scheme.

Fixes: 8ea1f989aa07 ("drivers/IB,usnic: reduce scope of mmap_sem")
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/infiniband/core/rdma_core.c | 1 -
 include/rdma/ib_verbs.h             | 6 ------
 2 files changed, 7 deletions(-)

diff --git a/drivers/infiniband/core/rdma_core.c b/drivers/infiniband/core/rdma_core.c
index d2b5417a4d5170..ffe11b03724cf5 100644
--- a/drivers/infiniband/core/rdma_core.c
+++ b/drivers/infiniband/core/rdma_core.c
@@ -889,7 +889,6 @@ void uverbs_destroy_ufile_hw(struct ib_uverbs_file *ufile,
 	if (!ufile->ucontext)
 		goto done;
 
-	ufile->ucontext->closing = true;
 	ufile->ucontext->cleanup_retryable = true;
 	while (!list_empty(&ufile->uobjects))
 		if (__uverbs_cleanup_ufile(ufile, reason)) {
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index f18502984e6f36..5ad997346f7fea 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -1477,12 +1477,6 @@ struct ib_rdmacg_object {
 struct ib_ucontext {
 	struct ib_device       *device;
 	struct ib_uverbs_file  *ufile;
-	/*
-	 * 'closing' can be read by the driver only during a destroy callback,
-	 * it is set when we are closing the file descriptor and indicates
-	 * that mm_sem may be locked.
-	 */
-	bool closing;
 
 	bool cleanup_retryable;
 
-- 
2.28.0

Re: [PATCH] RDMA/core: Remove ucontext->closing

[Leon Romanovsky]

On Tue, Sep 29, 2020 at 01:09:07PM -0300, Jason Gunthorpe wrote:
> Nothing reads this any more, and the reason for its existance has passed
> due to the deferred fput() scheme.
>
> Fixes: 8ea1f989aa07 ("drivers/IB,usnic: reduce scope of mmap_sem")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  drivers/infiniband/core/rdma_core.c | 1 -
>  include/rdma/ib_verbs.h             | 6 ------
>  2 files changed, 7 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Re: [PATCH] RDMA/core: Remove ucontext->closing

[Jason Gunthorpe]

On Tue, Sep 29, 2020 at 01:09:07PM -0300, Jason Gunthorpe wrote:
> Nothing reads this any more, and the reason for its existance has passed
> due to the deferred fput() scheme.
> 
> Fixes: 8ea1f989aa07 ("drivers/IB,usnic: reduce scope of mmap_sem")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/core/rdma_core.c | 1 -
>  include/rdma/ib_verbs.h             | 6 ------
>  2 files changed, 7 deletions(-)

Applied to for-next

Jason