* [PATCH net-next v2] lib8390: Use netif_msg_init to initialize msg_enable bits
@ 2020-09-30 21:00 Armin Wolf
2020-10-02 2:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Armin Wolf @ 2020-09-30 21:00 UTC (permalink / raw)
To: davem; +Cc: netdev
Use netif_msg_init() to process param settings
and use only the proper initialized value of
ei_local->msg_enable for later processing;
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
v2 changes:
- confused ei_local-> msg_enable with default_msg_level
---
drivers/net/ethernet/8390/lib8390.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/8390/lib8390.c b/drivers/net/ethernet/8390/lib8390.c
index deba94d2c909..e84021282edf 100644
--- a/drivers/net/ethernet/8390/lib8390.c
+++ b/drivers/net/ethernet/8390/lib8390.c
@@ -113,8 +113,10 @@ static void do_set_multicast_list(struct net_device *dev);
static void __NS8390_init(struct net_device *dev, int startp);
static unsigned version_printed;
-static u32 msg_enable;
-module_param(msg_enable, uint, 0444);
+static int msg_enable;
+static const int default_msg_level = (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_RX_ERR |
+ NETIF_MSG_TX_ERR);
+module_param(msg_enable, int, 0444);
MODULE_PARM_DESC(msg_enable, "Debug message level (see linux/netdevice.h for bitmap)");
/*
@@ -974,14 +976,14 @@ static void ethdev_setup(struct net_device *dev)
{
struct ei_device *ei_local = netdev_priv(dev);
- if ((msg_enable & NETIF_MSG_DRV) && (version_printed++ == 0))
- pr_info("%s", version);
-
ether_setup(dev);
spin_lock_init(&ei_local->page_lock);
- ei_local->msg_enable = msg_enable;
+ ei_local->msg_enable = netif_msg_init(msg_enable, default_msg_level);
+
+ if (netif_msg_drv(ei_local) && (version_printed++ == 0))
+ pr_info("%s", version);
}
/**
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2] lib8390: Use netif_msg_init to initialize msg_enable bits
2020-09-30 21:00 [PATCH net-next v2] lib8390: Use netif_msg_init to initialize msg_enable bits Armin Wolf
@ 2020-10-02 2:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-10-02 2:09 UTC (permalink / raw)
To: W_Armin; +Cc: netdev
From: Armin Wolf <W_Armin@gmx.de>
Date: Wed, 30 Sep 2020 23:00:16 +0200
> Use netif_msg_init() to process param settings
> and use only the proper initialized value of
> ei_local->msg_enable for later processing;
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> v2 changes:
> - confused ei_local-> msg_enable with default_msg_level
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-02 2:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 21:00 [PATCH net-next v2] lib8390: Use netif_msg_init to initialize msg_enable bits Armin Wolf
2020-10-02 2:09 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.