* [PATCH] ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96
@ 2020-10-01 10:25 Marek Vasut
2020-10-01 13:36 ` Patrice CHOTARD
2020-10-02 9:05 ` Patrick DELAUNAY
0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2020-10-01 10:25 UTC (permalink / raw)
To: u-boot
The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and
flash0 nodes are not included in the reduced SPL DT. This prevents
SPI NOR boot from working at all. Fix this by filling them in.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
---
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
index c73318488d..9d3db20876 100644
--- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
@@ -21,6 +21,10 @@
};
};
+&flash0 {
+ u-boot,dm-spl;
+};
+
&gpiof {
snor-nwp {
gpio-hog;
@@ -49,6 +53,23 @@
u-boot,dm-spl;
};
+&qspi_clk_pins_a {
+ u-boot,dm-spl;
+ pins {
+ u-boot,dm-spl;
+ };
+};
+
+&qspi_bk1_pins_a {
+ u-boot,dm-spl;
+ pins1 {
+ u-boot,dm-spl;
+ };
+ pins2 {
+ u-boot,dm-spl;
+ };
+};
+
&rcc {
st,clksrc = <
CLK_MPU_PLL1P
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96
2020-10-01 10:25 [PATCH] ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96 Marek Vasut
@ 2020-10-01 13:36 ` Patrice CHOTARD
2020-10-02 9:05 ` Patrick DELAUNAY
1 sibling, 0 replies; 6+ messages in thread
From: Patrice CHOTARD @ 2020-10-01 13:36 UTC (permalink / raw)
To: u-boot
Hi Marek
On 10/1/20 12:25 PM, Marek Vasut wrote:
> The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and
> flash0 nodes are not included in the reduced SPL DT. This prevents
> SPI NOR boot from working at all. Fix this by filling them in.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> ---
> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
> index c73318488d..9d3db20876 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
> +++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
> @@ -21,6 +21,10 @@
> };
> };
>
> +&flash0 {
> + u-boot,dm-spl;
> +};
> +
> &gpiof {
> snor-nwp {
> gpio-hog;
> @@ -49,6 +53,23 @@
> u-boot,dm-spl;
> };
>
> +&qspi_clk_pins_a {
> + u-boot,dm-spl;
> + pins {
> + u-boot,dm-spl;
> + };
> +};
> +
> +&qspi_bk1_pins_a {
> + u-boot,dm-spl;
> + pins1 {
> + u-boot,dm-spl;
> + };
> + pins2 {
> + u-boot,dm-spl;
> + };
> +};
> +
> &rcc {
> st,clksrc = <
> CLK_MPU_PLL1P
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96
2020-10-01 10:25 [PATCH] ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96 Marek Vasut
2020-10-01 13:36 ` Patrice CHOTARD
@ 2020-10-02 9:05 ` Patrick DELAUNAY
2020-10-02 12:09 ` Marek Vasut
1 sibling, 1 reply; 6+ messages in thread
From: Patrick DELAUNAY @ 2020-10-02 9:05 UTC (permalink / raw)
To: u-boot
Hi Marek,
> From: Marek Vasut <marex@denx.de>
> Sent: jeudi 1 octobre 2020 12:26
>
> The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and
> flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR
> boot from working at all. Fix this by filling them in.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> ---
> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
2 questions;
It is a regression or SPI boot had never worked on AV96 ?
And the expected target is v2020.10 or v2021.01-rc1 ?
I prefer v2021.01-rc1, except if it is blocking or it is a regression .....
Thanks
Patrick
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96
2020-10-02 9:05 ` Patrick DELAUNAY
@ 2020-10-02 12:09 ` Marek Vasut
2020-10-02 12:31 ` Patrick DELAUNAY
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2020-10-02 12:09 UTC (permalink / raw)
To: u-boot
On 10/2/20 11:05 AM, Patrick DELAUNAY wrote:
> Hi Marek,
Hi,
>> From: Marek Vasut <marex@denx.de>
>> Sent: jeudi 1 octobre 2020 12:26
>>
>> The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and
>> flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR
>> boot from working at all. Fix this by filling them in.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Patrick Delaunay <patrick.delaunay@st.com>
>> Cc: Patrice Chotard <patrice.chotard@st.com>
>> ---
>> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>>
>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
>
> 2 questions;
> It is a regression or SPI boot had never worked on AV96 ?
> And the expected target is v2020.10 or v2021.01-rc1 ?
>
> I prefer v2021.01-rc1, except if it is blocking or it is a regression .....
It used to work before, so 2020.10 please.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96
2020-10-02 12:09 ` Marek Vasut
@ 2020-10-02 12:31 ` Patrick DELAUNAY
2020-10-02 12:58 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Patrick DELAUNAY @ 2020-10-02 12:31 UTC (permalink / raw)
To: u-boot
Hi,
> From: Marek Vasut <marex@denx.de>
> Sent: vendredi 2 octobre 2020 14:09
>
> On 10/2/20 11:05 AM, Patrick DELAUNAY wrote:
> > Hi Marek,
>
> Hi,
>
> >> From: Marek Vasut <marex@denx.de>
> >> Sent: jeudi 1 octobre 2020 12:26
> >>
> >> The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and
> >> flash0 nodes are not included in the reduced SPL DT. This prevents
> >> SPI NOR boot from working at all. Fix this by filling them in.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> >> Cc: Patrice Chotard <patrice.chotard@st.com>
> >> ---
> >> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21
> >> +++++++++++++++++++++
> >> 1 file changed, 21 insertions(+)
> >>
> >
> > Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
> >
> > 2 questions;
> > It is a regression or SPI boot had never worked on AV96 ?
> > And the expected target is v2020.10 or v2021.01-rc1 ?
> >
> > I prefer v2021.01-rc1, except if it is blocking or it is a regression .....
>
> It used to work before, so 2020.10 please.
Ok
Applied to u-boot-stm/master, thanks!
Regards
Patrick
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96
2020-10-02 12:31 ` Patrick DELAUNAY
@ 2020-10-02 12:58 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2020-10-02 12:58 UTC (permalink / raw)
To: u-boot
On 10/2/20 2:31 PM, Patrick DELAUNAY wrote:
> Hi,
>
>> From: Marek Vasut <marex@denx.de>
>> Sent: vendredi 2 octobre 2020 14:09
>>
>> On 10/2/20 11:05 AM, Patrick DELAUNAY wrote:
>>> Hi Marek,
>>
>> Hi,
>>
>>>> From: Marek Vasut <marex@denx.de>
>>>> Sent: jeudi 1 octobre 2020 12:26
>>>>
>>>> The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and
>>>> flash0 nodes are not included in the reduced SPL DT. This prevents
>>>> SPI NOR boot from working at all. Fix this by filling them in.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> Cc: Patrick Delaunay <patrick.delaunay@st.com>
>>>> Cc: Patrice Chotard <patrice.chotard@st.com>
>>>> ---
>>>> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21
>>>> +++++++++++++++++++++
>>>> 1 file changed, 21 insertions(+)
>>>>
>>>
>>> Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
>>>
>>> 2 questions;
>>> It is a regression or SPI boot had never worked on AV96 ?
>>> And the expected target is v2020.10 or v2021.01-rc1 ?
>>>
>>> I prefer v2021.01-rc1, except if it is blocking or it is a regression .....
>>
>> It used to work before, so 2020.10 please.
>
> Ok
>
> Applied to u-boot-stm/master, thanks!
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-02 12:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 10:25 [PATCH] ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96 Marek Vasut
2020-10-01 13:36 ` Patrice CHOTARD
2020-10-02 9:05 ` Patrick DELAUNAY
2020-10-02 12:09 ` Marek Vasut
2020-10-02 12:31 ` Patrick DELAUNAY
2020-10-02 12:58 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.