All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: colyli@suse.de
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	netdev@vger.kernel.org, open-iscsi@googlegroups.com,
	linux-scsi@vger.kernel.org, ceph-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org, chaitanya.kulkarni@wdc.com,
	cleech@redhat.com, hch@lst.de, amwang@redhat.com,
	eric.dumazet@gmail.com, hare@suse.de, idryomov@gmail.com,
	jack@suse.com, jlayton@kernel.org, axboe@kernel.dk,
	lduncan@suse.com, michaelc@cs.wisc.edu,
	mskorzhinskiy@solarflare.com, philipp.reisner@linbit.com,
	sagi@grimberg.me, vvs@virtuozzo.com, vbabka@suse.com
Subject: Re: [PATCH v10 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers
Date: Fri, 02 Oct 2020 15:28:29 -0700 (PDT)	[thread overview]
Message-ID: <20201002.152829.1002796270145913943.davem@davemloft.net> (raw)
In-Reply-To: <20201002082734.13925-1-colyli@suse.de>

From: Coly Li <colyli@suse.de>
Date: Fri,  2 Oct 2020 16:27:27 +0800

> As Sagi Grimberg suggested, the original fix is refind to a more common
> inline routine:
>     static inline bool sendpage_ok(struct page *page)
>     {
>         return  (!PageSlab(page) && page_count(page) >= 1);
>     }
> If sendpage_ok() returns true, the checking page can be handled by the
> concrete zero-copy sendpage method in network layer.

Series applied.

> The v10 series has 7 patches, fixes a WARN_ONCE() usage from v9 series,
 ...

I still haven't heard from you how such a fundamental build failure
was even possible.

If the v9 patch series did not even compile, how in the world did you
perform functional testing of these changes?

Please explain this to me, instead of just quietly fixing it and
posting an updated series.

Thank you.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: colyli@suse.de
Cc: michaelc@cs.wisc.edu, amwang@redhat.com,
	linux-nvme@lists.infradead.org, philipp.reisner@linbit.com,
	hch@lst.de, vbabka@suse.com, sagi@grimberg.me,
	linux-scsi@vger.kernel.org, idryomov@gmail.com,
	open-iscsi@googlegroups.com, mskorzhinskiy@solarflare.com,
	chaitanya.kulkarni@wdc.com, linux-block@vger.kernel.org,
	hare@suse.de, ceph-devel@vger.kernel.org, axboe@kernel.dk,
	cleech@redhat.com, vvs@virtuozzo.com, eric.dumazet@gmail.com,
	netdev@vger.kernel.org, jlayton@kernel.org,
	linux-kernel@vger.kernel.org, lduncan@suse.com, jack@suse.com
Subject: Re: [PATCH v10 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers
Date: Fri, 02 Oct 2020 15:28:29 -0700 (PDT)	[thread overview]
Message-ID: <20201002.152829.1002796270145913943.davem@davemloft.net> (raw)
In-Reply-To: <20201002082734.13925-1-colyli@suse.de>

From: Coly Li <colyli@suse.de>
Date: Fri,  2 Oct 2020 16:27:27 +0800

> As Sagi Grimberg suggested, the original fix is refind to a more common
> inline routine:
>     static inline bool sendpage_ok(struct page *page)
>     {
>         return  (!PageSlab(page) && page_count(page) >= 1);
>     }
> If sendpage_ok() returns true, the checking page can be handled by the
> concrete zero-copy sendpage method in network layer.

Series applied.

> The v10 series has 7 patches, fixes a WARN_ONCE() usage from v9 series,
 ...

I still haven't heard from you how such a fundamental build failure
was even possible.

If the v9 patch series did not even compile, how in the world did you
perform functional testing of these changes?

Please explain this to me, instead of just quietly fixing it and
posting an updated series.

Thank you.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2020-10-02 22:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02  8:27 [PATCH v10 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers Coly Li
2020-10-02  8:27 ` Coly Li
2020-10-02  8:27 ` [PATCH v10 1/7] net: introduce helper sendpage_ok() in include/linux/net.h Coly Li
2020-10-02  8:27   ` Coly Li
2020-10-02  8:27 ` [PATCH v10 2/7] net: add WARN_ONCE in kernel_sendpage() for improper zero-copy send Coly Li
2020-10-02  8:27   ` Coly Li
2020-10-02  8:27 ` [PATCH v10 3/7] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage() Coly Li
2020-10-02  8:27   ` Coly Li
2020-10-02  8:27 ` [PATCH v10 4/7] tcp: use sendpage_ok() to detect misused .sendpage Coly Li
2020-10-02  8:27   ` Coly Li
2020-10-02  8:27 ` [PATCH v10 5/7] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage() Coly Li
2020-10-02  8:27   ` Coly Li
2020-10-02  8:27 ` [PATCH v10 6/7] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map() Coly Li
2020-10-02  8:27   ` Coly Li
2020-10-02  8:27 ` [PATCH v10 7/7] libceph: use sendpage_ok() in ceph_tcp_sendpage() Coly Li
2020-10-02  8:27   ` Coly Li
2020-10-02 22:28 ` David Miller [this message]
2020-10-02 22:28   ` [PATCH v10 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers David Miller
2020-10-03 10:42   ` Coly Li
2020-10-04  3:38   ` [PATCH v10 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers Coly Li
2020-10-04  3:38     ` Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201002.152829.1002796270145913943.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amwang@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=ceph-devel@vger.kernel.org \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=cleech@redhat.com \
    --cc=colyli@suse.de \
    --cc=eric.dumazet@gmail.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=idryomov@gmail.com \
    --cc=jack@suse.com \
    --cc=jlayton@kernel.org \
    --cc=lduncan@suse.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=mskorzhinskiy@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    --cc=philipp.reisner@linbit.com \
    --cc=sagi@grimberg.me \
    --cc=vbabka@suse.com \
    --cc=vvs@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.