All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Roman Gushchin <guro@fb.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: kbuild-all@lists.01.org, LKML <linux-kernel@vger.kernel.org>,
	Bastian Bittorf <bb@npl.de>, Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Shakeel Butt <shakeelb@google.com>
Subject: Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration
Date: Fri, 2 Oct 2020 08:08:40 +0800	[thread overview]
Message-ID: <202010020814.M5nb692Y-lkp@intel.com> (raw)
In-Reply-To: <20201001203931.GD2706729@carbon.DHCP.thefacebook.com>

[-- Attachment #1: Type: text/plain, Size: 2586 bytes --]

Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]

url:    https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: i386-randconfig-s002-20200930 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-201-g24bdaac6-dirty
        # https://github.com/0day-ci/linux/commit/3e4248734433fea1624e4971258042af2f231e02
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114
        git checkout 3e4248734433fea1624e4971258042af2f231e02
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/mm.h:1317,
                    from include/linux/memcontrol.h:20,
                    from include/linux/swap.h:9,
                    from include/linux/suspend.h:5,
                    from arch/x86/kernel/asm-offsets.c:13:
   include/linux/vmstat.h: In function '__mod_node_page_state':
>> include/linux/vmstat.h:295:6: error: implicit declaration of function 'vmstat_item_in_bytes' [-Werror=implicit-function-declaration]
     295 |  if (vmstat_item_in_bytes(item)) {
         |      ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:99: arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1139: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:179: sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

vim +/vmstat_item_in_bytes +295 include/linux/vmstat.h

   291	
   292	static inline void __mod_node_page_state(struct pglist_data *pgdat,
   293				enum node_stat_item item, int delta)
   294	{
 > 295		if (vmstat_item_in_bytes(item)) {
   296			VM_WARN_ON_ONCE(delta & (PAGE_SIZE - 1));
   297			delta >>= PAGE_SHIFT;
   298		}
   299	
   300		node_page_state_add(delta, pgdat, item);
   301	}
   302	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33276 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration
Date: Fri, 02 Oct 2020 08:08:40 +0800	[thread overview]
Message-ID: <202010020814.M5nb692Y-lkp@intel.com> (raw)
In-Reply-To: <20201001203931.GD2706729@carbon.DHCP.thefacebook.com>

[-- Attachment #1: Type: text/plain, Size: 2648 bytes --]

Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]

url:    https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: i386-randconfig-s002-20200930 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-201-g24bdaac6-dirty
        # https://github.com/0day-ci/linux/commit/3e4248734433fea1624e4971258042af2f231e02
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114
        git checkout 3e4248734433fea1624e4971258042af2f231e02
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/mm.h:1317,
                    from include/linux/memcontrol.h:20,
                    from include/linux/swap.h:9,
                    from include/linux/suspend.h:5,
                    from arch/x86/kernel/asm-offsets.c:13:
   include/linux/vmstat.h: In function '__mod_node_page_state':
>> include/linux/vmstat.h:295:6: error: implicit declaration of function 'vmstat_item_in_bytes' [-Werror=implicit-function-declaration]
     295 |  if (vmstat_item_in_bytes(item)) {
         |      ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:99: arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1139: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:179: sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

vim +/vmstat_item_in_bytes +295 include/linux/vmstat.h

   291	
   292	static inline void __mod_node_page_state(struct pglist_data *pgdat,
   293				enum node_stat_item item, int delta)
   294	{
 > 295		if (vmstat_item_in_bytes(item)) {
   296			VM_WARN_ON_ONCE(delta & (PAGE_SIZE - 1));
   297			delta >>= PAGE_SHIFT;
   298		}
   299	
   300		node_page_state_add(delta, pgdat, item);
   301	}
   302	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33276 bytes --]

  reply	other threads:[~2020-10-02  0:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201001065104.apevlkqrs6nid3r5@hp-nas.internet>
2020-10-01 19:19 ` Linux 5.9-rc7 / VmallocTotal wrongly reported Linus Torvalds
2020-10-01 19:56   ` Roman Gushchin
2020-10-01 19:58     ` Linus Torvalds
2020-10-01 20:39       ` Roman Gushchin
2020-10-02  0:08         ` kernel test robot [this message]
2020-10-02  0:08           ` [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration kernel test robot
2020-10-02  0:55           ` Roman Gushchin
2020-10-02  0:55             ` Roman Gushchin
2020-10-02  5:34             ` [kbuild-all] " Philip Li
2020-10-02  5:34               ` Philip Li
2020-10-02 17:55               ` [kbuild-all] " Roman Gushchin
2020-10-02 17:55                 ` Roman Gushchin
2020-10-12 23:05                 ` [kbuild-all] " Philip Li
2020-10-12 23:05                   ` Philip Li
2020-10-13  0:31                   ` [kbuild-all] " Roman Gushchin
2020-10-13  0:31                     ` Roman Gushchin
2020-10-02  7:01         ` Linux 5.9-rc7 / VmallocTotal wrongly reported | Patch OK Bastian Bittorf
2020-10-02 17:52           ` Roman Gushchin
2020-10-02  8:51         ` Linux 5.9-rc7 / VmallocTotal wrongly reported Vlastimil Babka
2020-10-02 21:43         ` [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration kernel test robot
2020-10-02 21:43           ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202010020814.M5nb692Y-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bb@npl.de \
    --cc=guro@fb.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shakeelb@google.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.