* [PATCH] serial: mcf: add sysrq capability
@ 2020-10-02 14:05 Angelo Dureghello
2020-10-07 12:00 ` Greg Ungerer
0 siblings, 1 reply; 2+ messages in thread
From: Angelo Dureghello @ 2020-10-02 14:05 UTC (permalink / raw)
To: gerg, gregkh; +Cc: linux-m68k, linux-serial, Angelo Dureghello
After some unsuccessful attempts to use sysrq over console, figured
out that port->has_sysrq should likely be enabled, as per other
architectures, this when CONFIG_SERIAL_MCF_CONSOLE is also enabled.
Tested some magic sysrq commands (h, p, t, b), they works now
properly. Commands works inside 5 secs after BREAK is sent, as
expected.
Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com>
---
drivers/tty/serial/mcf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
index 7dbfb4cde124..09c88c48fb7b 100644
--- a/drivers/tty/serial/mcf.c
+++ b/drivers/tty/serial/mcf.c
@@ -632,6 +632,7 @@ static int mcf_probe(struct platform_device *pdev)
port->ops = &mcf_uart_ops;
port->flags = UPF_BOOT_AUTOCONF;
port->rs485_config = mcf_config_rs485;
+ port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MCF_CONSOLE);
uart_add_one_port(&mcf_driver, port);
}
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: mcf: add sysrq capability
2020-10-02 14:05 [PATCH] serial: mcf: add sysrq capability Angelo Dureghello
@ 2020-10-07 12:00 ` Greg Ungerer
0 siblings, 0 replies; 2+ messages in thread
From: Greg Ungerer @ 2020-10-07 12:00 UTC (permalink / raw)
To: Angelo Dureghello, gregkh; +Cc: linux-m68k, linux-serial
Hi Angelo,
On 3/10/20 12:05 am, Angelo Dureghello wrote:
> After some unsuccessful attempts to use sysrq over console, figured
> out that port->has_sysrq should likely be enabled, as per other
> architectures, this when CONFIG_SERIAL_MCF_CONSOLE is also enabled.
>
> Tested some magic sysrq commands (h, p, t, b), they works now
> properly. Commands works inside 5 secs after BREAK is sent, as
> expected.
>
> Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com>
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
I can take this via the m68knommu git tree if no one else wants to pick
it up?
Regards
Greg
> ---
> drivers/tty/serial/mcf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
> index 7dbfb4cde124..09c88c48fb7b 100644
> --- a/drivers/tty/serial/mcf.c
> +++ b/drivers/tty/serial/mcf.c
> @@ -632,6 +632,7 @@ static int mcf_probe(struct platform_device *pdev)
> port->ops = &mcf_uart_ops;
> port->flags = UPF_BOOT_AUTOCONF;
> port->rs485_config = mcf_config_rs485;
> + port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MCF_CONSOLE);
>
> uart_add_one_port(&mcf_driver, port);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-07 12:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 14:05 [PATCH] serial: mcf: add sysrq capability Angelo Dureghello
2020-10-07 12:00 ` Greg Ungerer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.