From: "Pali Rohár" <pali@kernel.org> To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: "Rob Herring" <robh@kernel.org>, "Bjorn Helgaas" <bhelgaas@google.com>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "Kishon Vijay Abraham I" <kishon@ti.com>, "Vinod Koul" <vkoul@kernel.org>, "Marek Behún" <marek.behun@nic.cz>, "Tomasz Maciej Nowak" <tmn505@gmail.com>, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF Date: Fri, 2 Oct 2020 17:07:01 +0200 [thread overview] Message-ID: <20201002150701.bvatgxygq4rjssly@pali> (raw) In-Reply-To: <20201002150300.GA25684@e121166-lin.cambridge.arm.com> On Friday 02 October 2020 16:03:09 Lorenzo Pieralisi wrote: > On Fri, Oct 02, 2020 at 04:52:37PM +0200, Pali Rohár wrote: > > On Friday 02 October 2020 15:38:51 Lorenzo Pieralisi wrote: > > > On Fri, Oct 02, 2020 at 04:26:16PM +0200, Pali Rohár wrote: > > > > On Friday 02 October 2020 14:37:13 Lorenzo Pieralisi wrote: > > > > > On Wed, Sep 02, 2020 at 04:43:42PM +0200, Pali Rohár wrote: > > > > > > This patch series fixes regression introduced in commit 366697018c9a > > > > > > ("PCI: aardvark: Add PHY support") which caused aardvark driver > > > > > > initialization failure on EspressoBin board with factory version of > > > > > > Arm Trusted Firmware provided by Marvell. > > > > > > > > > > > > Second patch depends on the first patch, so please add appropriate > > > > > > Fixes/Cc:stable@ tags to have both patches correctly backported to > > > > > > stable kernels. > > > > > > > > > > > > I have tested both patches with Marvell ATF firmware ebin-17.10-uart.zip > > > > > > and with upstream ATF+uboot and aardvark was initialized successfully. > > > > > > Without this patch series on ebin-17.10-uart.zip aardvark initialization > > > > > > failed. > > > > > > > > > > > > Pali Rohár (2): > > > > > > phy: marvell: comphy: Convert internal SMCC firmware return codes to > > > > > > errno > > > > > > PCI: aardvark: Fix initialization with old Marvell's Arm Trusted > > > > > > Firmware > > > > > > > > > > > > drivers/pci/controller/pci-aardvark.c | 4 +++- > > > > > > drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 14 +++++++++++--- > > > > > > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 14 +++++++++++--- > > > > > > 3 files changed, 25 insertions(+), 7 deletions(-) > > > > > > > > > > Applied to pci/aardvark (both patches), thanks. > > > > > > > > Ok! For second patch would be needed to put CC:stable line with > > > > specifying prerequisite of first patch as written in document: > > > > > > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > > > > > > If I understood it correctly, second patch needs following line: > > > > > > > > Cc: <stable@vger.kernel.org> # <commit_id_of_first_path>: comphy: errno return codes > > > > > > > > where <commit_id_of_first_path> is commit id of PATCH 1/2. > > > > > > > > (correct me if I'm wrong) > > > > > > > > Now when first commit has commit id, could you update second commit to > > > > include this information about prerequisite? > > > > > > No I can't because they will be merged at the same time. > > > > And it is a problem? Git commit id of first patch would not be changed, > > so referencing to it is now possible from second commit (unless you do > > rebasing). > > > > > What we can do is mark the second patch for stable > > > > This is done by adding "Cc: <stable@vger.kernel.org>" line to second > > patch which I suggested, right? > > I will apply the stable tag and dependency, it should be fine. Ok! I thought that according to stable-kernel-rules.html that dependent commit could be added after stable email address separated with # char. At least this is how I understood stable-kernel-rules.html and its section: "Additionally, some patches submitted via Option 1 may have additional patch prerequisites which can be cherry-picked." > Please ensure you follow up stable updates especially in case patches > don't backport properly (ie please try). No problem, I can monitor emails about backporting these patches. > Lorenzo
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali@kernel.org> To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: "Tomasz Maciej Nowak" <tmn505@gmail.com>, "Rob Herring" <robh@kernel.org>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "Kishon Vijay Abraham I" <kishon@ti.com>, "Vinod Koul" <vkoul@kernel.org>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Marek Behún" <marek.behun@nic.cz>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF Date: Fri, 2 Oct 2020 17:07:01 +0200 [thread overview] Message-ID: <20201002150701.bvatgxygq4rjssly@pali> (raw) In-Reply-To: <20201002150300.GA25684@e121166-lin.cambridge.arm.com> On Friday 02 October 2020 16:03:09 Lorenzo Pieralisi wrote: > On Fri, Oct 02, 2020 at 04:52:37PM +0200, Pali Rohár wrote: > > On Friday 02 October 2020 15:38:51 Lorenzo Pieralisi wrote: > > > On Fri, Oct 02, 2020 at 04:26:16PM +0200, Pali Rohár wrote: > > > > On Friday 02 October 2020 14:37:13 Lorenzo Pieralisi wrote: > > > > > On Wed, Sep 02, 2020 at 04:43:42PM +0200, Pali Rohár wrote: > > > > > > This patch series fixes regression introduced in commit 366697018c9a > > > > > > ("PCI: aardvark: Add PHY support") which caused aardvark driver > > > > > > initialization failure on EspressoBin board with factory version of > > > > > > Arm Trusted Firmware provided by Marvell. > > > > > > > > > > > > Second patch depends on the first patch, so please add appropriate > > > > > > Fixes/Cc:stable@ tags to have both patches correctly backported to > > > > > > stable kernels. > > > > > > > > > > > > I have tested both patches with Marvell ATF firmware ebin-17.10-uart.zip > > > > > > and with upstream ATF+uboot and aardvark was initialized successfully. > > > > > > Without this patch series on ebin-17.10-uart.zip aardvark initialization > > > > > > failed. > > > > > > > > > > > > Pali Rohár (2): > > > > > > phy: marvell: comphy: Convert internal SMCC firmware return codes to > > > > > > errno > > > > > > PCI: aardvark: Fix initialization with old Marvell's Arm Trusted > > > > > > Firmware > > > > > > > > > > > > drivers/pci/controller/pci-aardvark.c | 4 +++- > > > > > > drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 14 +++++++++++--- > > > > > > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 14 +++++++++++--- > > > > > > 3 files changed, 25 insertions(+), 7 deletions(-) > > > > > > > > > > Applied to pci/aardvark (both patches), thanks. > > > > > > > > Ok! For second patch would be needed to put CC:stable line with > > > > specifying prerequisite of first patch as written in document: > > > > > > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > > > > > > If I understood it correctly, second patch needs following line: > > > > > > > > Cc: <stable@vger.kernel.org> # <commit_id_of_first_path>: comphy: errno return codes > > > > > > > > where <commit_id_of_first_path> is commit id of PATCH 1/2. > > > > > > > > (correct me if I'm wrong) > > > > > > > > Now when first commit has commit id, could you update second commit to > > > > include this information about prerequisite? > > > > > > No I can't because they will be merged at the same time. > > > > And it is a problem? Git commit id of first patch would not be changed, > > so referencing to it is now possible from second commit (unless you do > > rebasing). > > > > > What we can do is mark the second patch for stable > > > > This is done by adding "Cc: <stable@vger.kernel.org>" line to second > > patch which I suggested, right? > > I will apply the stable tag and dependency, it should be fine. Ok! I thought that according to stable-kernel-rules.html that dependent commit could be added after stable email address separated with # char. At least this is how I understood stable-kernel-rules.html and its section: "Additionally, some patches submitted via Option 1 may have additional patch prerequisites which can be cherry-picked." > Please ensure you follow up stable updates especially in case patches > don't backport properly (ie please try). No problem, I can monitor emails about backporting these patches. > Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-02 15:07 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-02 14:43 [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF Pali Rohár 2020-09-02 14:43 ` Pali Rohár 2020-09-02 14:43 ` [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno Pali Rohár 2020-09-02 14:43 ` Pali Rohár 2020-09-02 16:13 ` Andrew Lunn 2020-09-02 16:13 ` Andrew Lunn 2020-09-02 16:56 ` Pali Rohár 2020-09-02 16:56 ` Pali Rohár 2020-09-02 17:00 ` Andrew Lunn 2020-09-02 17:00 ` Andrew Lunn 2020-09-02 17:05 ` Pali Rohár 2020-09-02 17:05 ` Pali Rohár 2020-09-02 17:20 ` Andrew Lunn 2020-09-02 17:20 ` Andrew Lunn 2020-09-02 17:45 ` Pali Rohár 2020-09-02 17:45 ` Pali Rohár 2020-09-30 18:17 ` Rob Herring 2020-09-30 18:17 ` Rob Herring 2020-09-02 14:43 ` [PATCH 2/2] PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware Pali Rohár 2020-09-02 14:43 ` Pali Rohár 2020-09-30 18:17 ` Rob Herring 2020-09-30 18:17 ` Rob Herring 2020-09-16 15:14 ` [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF Tomasz Maciej Nowak 2020-09-16 15:14 ` Tomasz Maciej Nowak 2020-09-21 13:09 ` Pali Rohár 2020-09-21 13:09 ` Pali Rohár 2020-10-02 12:00 ` Pali Rohár 2020-10-02 12:00 ` Pali Rohár 2020-10-02 13:37 ` Lorenzo Pieralisi 2020-10-02 13:37 ` Lorenzo Pieralisi 2020-10-02 14:26 ` Pali Rohár 2020-10-02 14:26 ` Pali Rohár 2020-10-02 14:38 ` Lorenzo Pieralisi 2020-10-02 14:38 ` Lorenzo Pieralisi 2020-10-02 14:52 ` Pali Rohár 2020-10-02 14:52 ` Pali Rohár 2020-10-02 15:03 ` Lorenzo Pieralisi 2020-10-02 15:03 ` Lorenzo Pieralisi 2020-10-02 15:07 ` Pali Rohár [this message] 2020-10-02 15:07 ` Pali Rohár 2020-10-02 15:15 ` Lorenzo Pieralisi 2020-10-02 15:15 ` Lorenzo Pieralisi 2020-10-02 15:20 ` Pali Rohár 2020-10-02 15:20 ` Pali Rohár
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201002150701.bvatgxygq4rjssly@pali \ --to=pali@kernel.org \ --cc=bhelgaas@google.com \ --cc=kishon@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=marek.behun@nic.cz \ --cc=miquel.raynal@bootlin.com \ --cc=robh@kernel.org \ --cc=tmn505@gmail.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.