* [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller
@ 2020-09-17 16:50 Krzysztof Kozlowski
2020-09-17 16:50 ` [PATCH 2/2] arm64: dts: apm: add required gpio-cells to DW APB GPIO controller port Krzysztof Kozlowski
2020-10-02 16:09 ` Krzysztof Kozlowski
0 siblings, 2 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-17 16:50 UTC (permalink / raw)
To: Khuong Dinh, Rob Herring, devicetree, linux-kernel, arm, soc,
Arnd Bergmann, Olof Johansson
Cc: Krzysztof Kozlowski, linux-arm-kernel
The Synopsys DesignWare APB GPIO controller driver does not parse
reg-io-width and dtschema does not allow it so drop it to fix dtschema
warnings like:
arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v1:
1. New patch
---
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 -
arch/arm64/boot/dts/apm/apm-storm.dtsi | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
index 3feb1881bbc2..2da5b8a0cd35 100644
--- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
@@ -709,7 +709,6 @@
dwgpio: gpio@1c024000 {
compatible = "snps,dw-apb-gpio";
reg = <0x0 0x1c024000 0x0 0x1000>;
- reg-io-width = <4>;
#address-cells = <1>;
#size-cells = <0>;
diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 8c802d87e751..560b2a6f2082 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -825,7 +825,6 @@
dwgpio: gpio@1c024000 {
compatible = "snps,dw-apb-gpio";
reg = <0x0 0x1c024000 0x0 0x1000>;
- reg-io-width = <4>;
#address-cells = <1>;
#size-cells = <0>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] arm64: dts: apm: add required gpio-cells to DW APB GPIO controller port
2020-09-17 16:50 [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller Krzysztof Kozlowski
@ 2020-09-17 16:50 ` Krzysztof Kozlowski
2020-10-02 16:09 ` Krzysztof Kozlowski
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-17 16:50 UTC (permalink / raw)
To: Khuong Dinh, Rob Herring, devicetree, linux-kernel, arm, soc,
Arnd Bergmann, Olof Johansson
Cc: Krzysztof Kozlowski, linux-arm-kernel
The Synopsys DesignWare APB GPIO controller port must have gpio-cells
property, as pointed by dtschema:
arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000: gpio-controller@0: '#gpio-cells' is a required property
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v1:
1. New patch
---
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 +
arch/arm64/boot/dts/apm/apm-storm.dtsi | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
index 2da5b8a0cd35..a83c82c50e29 100644
--- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
@@ -715,6 +715,7 @@
porta: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
+ #gpio-cells = <2>;
snps,nr-gpios = <32>;
reg = <0>;
};
diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 560b2a6f2082..0f37e77f5459 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -831,6 +831,7 @@
porta: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
+ #gpio-cells = <2>;
snps,nr-gpios = <32>;
reg = <0>;
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller
2020-09-17 16:50 [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller Krzysztof Kozlowski
@ 2020-10-02 16:09 ` Krzysztof Kozlowski
2020-10-02 16:09 ` Krzysztof Kozlowski
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-02 16:09 UTC (permalink / raw)
To: Arnd Bergmann, Olof Johansson
Cc: Khuong Dinh, Rob Herring, devicetree, linux-kernel, arm, soc,
linux-arm-kernel
On Thu, Sep 17, 2020 at 06:50:39PM +0200, Krzysztof Kozlowski wrote:
> The Synopsys DesignWare APB GPIO controller driver does not parse
> reg-io-width and dtschema does not allow it so drop it to fix dtschema
> warnings like:
>
> arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
> 'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
Dear Arnd and Olof,
There is no response from APM maintainer, so maybe you could apply these
two patches directly? Optionally I could take it and send to you via
pull-request.
Best regards,
Krzysztof
>
> Changes since v1:
> 1. New patch
> ---
> arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 -
> arch/arm64/boot/dts/apm/apm-storm.dtsi | 1 -
> 2 files changed, 2 deletions(-)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller
@ 2020-10-02 16:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-02 16:09 UTC (permalink / raw)
To: Arnd Bergmann, Olof Johansson
Cc: devicetree, Khuong Dinh, arm, linux-kernel, soc, Rob Herring,
linux-arm-kernel
On Thu, Sep 17, 2020 at 06:50:39PM +0200, Krzysztof Kozlowski wrote:
> The Synopsys DesignWare APB GPIO controller driver does not parse
> reg-io-width and dtschema does not allow it so drop it to fix dtschema
> warnings like:
>
> arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
> 'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
Dear Arnd and Olof,
There is no response from APM maintainer, so maybe you could apply these
two patches directly? Optionally I could take it and send to you via
pull-request.
Best regards,
Krzysztof
>
> Changes since v1:
> 1. New patch
> ---
> arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 -
> arch/arm64/boot/dts/apm/apm-storm.dtsi | 1 -
> 2 files changed, 2 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller
2020-10-02 16:09 ` Krzysztof Kozlowski
@ 2020-10-03 19:31 ` Olof Johansson
-1 siblings, 0 replies; 8+ messages in thread
From: Olof Johansson @ 2020-10-03 19:31 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Arnd Bergmann, Khuong Dinh, Rob Herring, devicetree,
linux-kernel, arm, soc, linux-arm-kernel
On Fri, Oct 02, 2020 at 06:09:22PM +0200, Krzysztof Kozlowski wrote:
> On Thu, Sep 17, 2020 at 06:50:39PM +0200, Krzysztof Kozlowski wrote:
> > The Synopsys DesignWare APB GPIO controller driver does not parse
> > reg-io-width and dtschema does not allow it so drop it to fix dtschema
> > warnings like:
> >
> > arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
> > 'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
>
> Dear Arnd and Olof,
>
> There is no response from APM maintainer, so maybe you could apply these
> two patches directly? Optionally I could take it and send to you via
> pull-request.
Sure, applying.
-Olof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller
@ 2020-10-03 19:31 ` Olof Johansson
0 siblings, 0 replies; 8+ messages in thread
From: Olof Johansson @ 2020-10-03 19:31 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Khuong Dinh, arm, Arnd Bergmann, linux-kernel, soc,
Rob Herring, linux-arm-kernel
On Fri, Oct 02, 2020 at 06:09:22PM +0200, Krzysztof Kozlowski wrote:
> On Thu, Sep 17, 2020 at 06:50:39PM +0200, Krzysztof Kozlowski wrote:
> > The Synopsys DesignWare APB GPIO controller driver does not parse
> > reg-io-width and dtschema does not allow it so drop it to fix dtschema
> > warnings like:
> >
> > arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
> > 'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
>
> Dear Arnd and Olof,
>
> There is no response from APM maintainer, so maybe you could apply these
> two patches directly? Optionally I could take it and send to you via
> pull-request.
Sure, applying.
-Olof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller
2020-10-02 16:09 ` Krzysztof Kozlowski
@ 2020-10-03 19:33 ` Olof Johansson
-1 siblings, 0 replies; 8+ messages in thread
From: Olof Johansson @ 2020-10-03 19:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Arnd Bergmann, Khuong Dinh, Rob Herring, devicetree,
linux-kernel, arm, soc, linux-arm-kernel
On Fri, Oct 02, 2020 at 06:09:22PM +0200, Krzysztof Kozlowski wrote:
> On Thu, Sep 17, 2020 at 06:50:39PM +0200, Krzysztof Kozlowski wrote:
> > The Synopsys DesignWare APB GPIO controller driver does not parse
> > reg-io-width and dtschema does not allow it so drop it to fix dtschema
> > warnings like:
> >
> > arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
> > 'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
>
> Dear Arnd and Olof,
>
> There is no response from APM maintainer, so maybe you could apply these
> two patches directly? Optionally I could take it and send to you via
> pull-request.
I've already applied them, so no need. Thanks for following up though, seems
like the patchwork email service hasn't been working on all patches.
-Olof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller
@ 2020-10-03 19:33 ` Olof Johansson
0 siblings, 0 replies; 8+ messages in thread
From: Olof Johansson @ 2020-10-03 19:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Khuong Dinh, arm, Arnd Bergmann, linux-kernel, soc,
Rob Herring, linux-arm-kernel
On Fri, Oct 02, 2020 at 06:09:22PM +0200, Krzysztof Kozlowski wrote:
> On Thu, Sep 17, 2020 at 06:50:39PM +0200, Krzysztof Kozlowski wrote:
> > The Synopsys DesignWare APB GPIO controller driver does not parse
> > reg-io-width and dtschema does not allow it so drop it to fix dtschema
> > warnings like:
> >
> > arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:
> > 'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
>
> Dear Arnd and Olof,
>
> There is no response from APM maintainer, so maybe you could apply these
> two patches directly? Optionally I could take it and send to you via
> pull-request.
I've already applied them, so no need. Thanks for following up though, seems
like the patchwork email service hasn't been working on all patches.
-Olof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-10-04 5:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 16:50 [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller Krzysztof Kozlowski
2020-09-17 16:50 ` [PATCH 2/2] arm64: dts: apm: add required gpio-cells to DW APB GPIO controller port Krzysztof Kozlowski
2020-10-02 16:09 ` [PATCH 1/2] arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller Krzysztof Kozlowski
2020-10-02 16:09 ` Krzysztof Kozlowski
2020-10-03 19:31 ` Olof Johansson
2020-10-03 19:31 ` Olof Johansson
2020-10-03 19:33 ` Olof Johansson
2020-10-03 19:33 ` Olof Johansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.