* [PATCH] dockerfiles: add diffutils to Fedora
@ 2020-10-03 8:50 Paolo Bonzini
2020-10-03 18:00 ` Philippe Mathieu-Daudé
2020-10-04 17:44 ` Neal Gompa
0 siblings, 2 replies; 5+ messages in thread
From: Paolo Bonzini @ 2020-10-03 8:50 UTC (permalink / raw)
To: qemu-devel; +Cc: alex.bennee
For some reason diffutils is not included in the Fedora containers anymore,
causing the build to fail.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/docker/dockerfiles/fedora.docker | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 71e4b56977..ec783418c8 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -11,6 +11,7 @@ ENV PACKAGES \
cyrus-sasl-devel \
dbus-daemon \
device-mapper-multipath-devel \
+ diffutils \
findutils \
gcc \
gcc-c++ \
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dockerfiles: add diffutils to Fedora
2020-10-03 8:50 [PATCH] dockerfiles: add diffutils to Fedora Paolo Bonzini
@ 2020-10-03 18:00 ` Philippe Mathieu-Daudé
2020-10-04 6:34 ` Paolo Bonzini
2020-10-04 17:44 ` Neal Gompa
1 sibling, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-03 18:00 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: alex.bennee
On 10/3/20 10:50 AM, Paolo Bonzini wrote:
> For some reason diffutils is not included in the Fedora containers anymore,
> causing the build to fail.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/docker/dockerfiles/fedora.docker | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 71e4b56977..ec783418c8 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -11,6 +11,7 @@ ENV PACKAGES \
> cyrus-sasl-devel \
> dbus-daemon \
> device-mapper-multipath-devel \
> + diffutils \
> findutils \
> gcc \
> gcc-c++ \
>
What about tests/docker/dockerfiles/fedora-cris-cross.docker
and tests/docker/dockerfiles/fedora-i386-cross.docker?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dockerfiles: add diffutils to Fedora
2020-10-03 18:00 ` Philippe Mathieu-Daudé
@ 2020-10-04 6:34 ` Paolo Bonzini
2020-10-04 9:14 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2020-10-04 6:34 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: alex.bennee
On 03/10/20 20:00, Philippe Mathieu-Daudé wrote:
>>
>> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
>> index 71e4b56977..ec783418c8 100644
>> --- a/tests/docker/dockerfiles/fedora.docker
>> +++ b/tests/docker/dockerfiles/fedora.docker
>> @@ -11,6 +11,7 @@ ENV PACKAGES \
>> cyrus-sasl-devel \
>> dbus-daemon \
>> device-mapper-multipath-devel \
>> + diffutils \
>> findutils \
>> gcc \
>> gcc-c++ \
>>
> What about tests/docker/dockerfiles/fedora-cris-cross.docker
> and tests/docker/dockerfiles/fedora-i386-cross.docker?
>
They're only used for gcc, not to build QEMU.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dockerfiles: add diffutils to Fedora
2020-10-04 6:34 ` Paolo Bonzini
@ 2020-10-04 9:14 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-04 9:14 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: alex.bennee
On 10/4/20 8:34 AM, Paolo Bonzini wrote:
> On 03/10/20 20:00, Philippe Mathieu-Daudé wrote:
>>>
>>> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
>>> index 71e4b56977..ec783418c8 100644
>>> --- a/tests/docker/dockerfiles/fedora.docker
>>> +++ b/tests/docker/dockerfiles/fedora.docker
>>> @@ -11,6 +11,7 @@ ENV PACKAGES \
>>> cyrus-sasl-devel \
>>> dbus-daemon \
>>> device-mapper-multipath-devel \
>>> + diffutils \
>>> findutils \
>>> gcc \
>>> gcc-c++ \
>>>
>> What about tests/docker/dockerfiles/fedora-cris-cross.docker
>> and tests/docker/dockerfiles/fedora-i386-cross.docker?
>>
>
> They're only used for gcc, not to build QEMU.
Ah OK.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Paolo
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dockerfiles: add diffutils to Fedora
2020-10-03 8:50 [PATCH] dockerfiles: add diffutils to Fedora Paolo Bonzini
2020-10-03 18:00 ` Philippe Mathieu-Daudé
@ 2020-10-04 17:44 ` Neal Gompa
1 sibling, 0 replies; 5+ messages in thread
From: Neal Gompa @ 2020-10-04 17:44 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Alex Bennée, QEMU Developers
On Sat, Oct 3, 2020 at 4:51 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> For some reason diffutils is not included in the Fedora containers anymore,
> causing the build to fail.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/docker/dockerfiles/fedora.docker | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 71e4b56977..ec783418c8 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -11,6 +11,7 @@ ENV PACKAGES \
> cyrus-sasl-devel \
> dbus-daemon \
> device-mapper-multipath-devel \
> + diffutils \
> findutils \
> gcc \
> gcc-c++ \
> --
> 2.26.2
>
>
Reviewed-by: Neal Gompa <ngompa13@gmail.com>
--
真実はいつも一つ！/ Always, there's only one truth!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-04 17:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-03 8:50 [PATCH] dockerfiles: add diffutils to Fedora Paolo Bonzini
2020-10-03 18:00 ` Philippe Mathieu-Daudé
2020-10-04 6:34 ` Paolo Bonzini
2020-10-04 9:14 ` Philippe Mathieu-Daudé
2020-10-04 17:44 ` Neal Gompa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.