From: Matthew Wilcox <willy@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
rcu@vger.kernel.org, linux-mm@kvack.org
Subject: Re: Where is the declaration of buffer used in kernel_param_ops .get functions?
Date: Sun, 4 Oct 2020 02:36:26 +0100 [thread overview]
Message-ID: <20201004013626.GE20115@casper.infradead.org> (raw)
In-Reply-To: <250919192de237dadf36218ee6b4dabf1bd4cbde.camel@perches.com>
On Sat, Oct 03, 2020 at 06:19:18PM -0700, Joe Perches wrote:
> These patches came up because I was looking for
> the location of the declaration of the buffer used
> in kernel/params.c struct kernel_param_ops .get
> functions.
>
> I didn't find it.
>
> I want to see if it's appropriate to convert the
> sprintf family of functions used in these .get
> functions to sysfs_emit.
>
> Patches submitted here:
> https://lore.kernel.org/lkml/5d606519698ce4c8f1203a2b35797d8254c6050a.1600285923.git.joe@perches.com/T/
>
> Anyone know if it's appropriate to change the
> sprintf-like uses in these functions to sysfs_emit
> and/or sysfs_emit_at?
There's a lot of preprocessor magic to wade through.
I'm pretty sure this comes through include/linux/moduleparam.h
and kernel/module.c.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: kvm@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
rcu@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: Where is the declaration of buffer used in kernel_param_ops .get functions?
Date: Sun, 4 Oct 2020 02:36:26 +0100 [thread overview]
Message-ID: <20201004013626.GE20115@casper.infradead.org> (raw)
In-Reply-To: <250919192de237dadf36218ee6b4dabf1bd4cbde.camel@perches.com>
On Sat, Oct 03, 2020 at 06:19:18PM -0700, Joe Perches wrote:
> These patches came up because I was looking for
> the location of the declaration of the buffer used
> in kernel/params.c struct kernel_param_ops .get
> functions.
>
> I didn't find it.
>
> I want to see if it's appropriate to convert the
> sprintf family of functions used in these .get
> functions to sysfs_emit.
>
> Patches submitted here:
> https://lore.kernel.org/lkml/5d606519698ce4c8f1203a2b35797d8254c6050a.1600285923.git.joe@perches.com/T/
>
> Anyone know if it's appropriate to change the
> sprintf-like uses in these functions to sysfs_emit
> and/or sysfs_emit_at?
There's a lot of preprocessor magic to wade through.
I'm pretty sure this comes through include/linux/moduleparam.h
and kernel/module.c.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
rcu@vger.kernel.org, linux-mm@kvack.org
Subject: Re: Where is the declaration of buffer used in kernel_param_ops .get functions?
Date: Sun, 04 Oct 2020 01:36:26 +0000 [thread overview]
Message-ID: <20201004013626.GE20115@casper.infradead.org> (raw)
In-Reply-To: <250919192de237dadf36218ee6b4dabf1bd4cbde.camel@perches.com>
On Sat, Oct 03, 2020 at 06:19:18PM -0700, Joe Perches wrote:
> These patches came up because I was looking for
> the location of the declaration of the buffer used
> in kernel/params.c struct kernel_param_ops .get
> functions.
>
> I didn't find it.
>
> I want to see if it's appropriate to convert the
> sprintf family of functions used in these .get
> functions to sysfs_emit.
>
> Patches submitted here:
> https://lore.kernel.org/lkml/5d606519698ce4c8f1203a2b35797d8254c6050a.1600285923.git.joe@perches.com/T/
>
> Anyone know if it's appropriate to change the
> sprintf-like uses in these functions to sysfs_emit
> and/or sysfs_emit_at?
There's a lot of preprocessor magic to wade through.
I'm pretty sure this comes through include/linux/moduleparam.h
and kernel/module.c.
next prev parent reply other threads:[~2020-10-04 1:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 0:18 [PATCH 0/4] treewide: Make definitions of struct kernel_param_ops const Joe Perches
2020-10-04 0:18 ` Joe Perches
2020-10-04 0:18 ` [PATCH 1/4] KVM: PPC: Book3S HV: Make struct kernel_param_ops definition const Joe Perches
2020-10-04 0:18 ` Joe Perches
2020-10-04 0:18 ` Joe Perches
2020-10-19 16:01 ` Paolo Bonzini
2020-10-19 16:01 ` Paolo Bonzini
2020-10-19 16:01 ` Paolo Bonzini
2020-10-04 0:18 ` [PATCH 2/4] kvm x86/mmu: Make struct kernel_param_ops definitions const Joe Perches
2020-10-05 17:14 ` Ben Gardon
2020-10-19 15:50 ` Paolo Bonzini
2020-10-04 0:18 ` [PATCH 3/4] rcu/tree: " Joe Perches
2020-10-04 15:54 ` Paul E. McKenney
2020-10-04 0:18 ` [PATCH 4/4] mm/zswap: " Joe Perches
2020-10-04 1:19 ` Where is the declaration of buffer used in kernel_param_ops .get functions? Joe Perches
2020-10-04 1:19 ` Joe Perches
2020-10-04 1:19 ` Joe Perches
2020-10-04 1:19 ` Joe Perches
2020-10-04 1:36 ` Matthew Wilcox [this message]
2020-10-04 1:36 ` Matthew Wilcox
2020-10-04 1:36 ` Matthew Wilcox
2020-10-04 2:11 ` Joe Perches
2020-10-04 2:11 ` Joe Perches
2020-10-04 2:11 ` Joe Perches
2020-10-04 2:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201004013626.GE20115@casper.infradead.org \
--to=willy@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.