* [PATCH 2/4] ASoC: Intel: bdw-rt5677: Mark FE DAIs as nonatomic
2020-10-04 9:06 [PATCH 1/4] ASoC: Intel: bdw-rt5650: Mark FE DAIs as nonatomic Cezary Rojewski
@ 2020-10-04 9:06 ` Cezary Rojewski
2020-10-04 9:06 ` [PATCH 3/4] ASoC: Intel: broadwell: " Cezary Rojewski
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Cezary Rojewski @ 2020-10-04 9:06 UTC (permalink / raw)
To: alsa-devel
Cc: lgirdwood, Cezary Rojewski, broonie, tiwai, pierre-louis.bossart
PCM operations for DAI links connected with DSP platform component
involve communication with DSP firmware by IPCs. As IPC protocol may
cause thread to sleep while waiting for a response from DSP, propagate
that information to ALSA core by marking all FE DAIs as nonatomic.
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/intel/boards/bdw-rt5677.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/intel/boards/bdw-rt5677.c b/sound/soc/intel/boards/bdw-rt5677.c
index d6584768883b..7a3e773d0a1c 100644
--- a/sound/soc/intel/boards/bdw-rt5677.c
+++ b/sound/soc/intel/boards/bdw-rt5677.c
@@ -323,6 +323,7 @@ static struct snd_soc_dai_link bdw_rt5677_dais[] = {
{
.name = "System PCM",
.stream_name = "System Playback/Capture",
+ .nonatomic = 1,
.dynamic = 1,
.trigger = {
SND_SOC_DPCM_TRIGGER_POST,
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] ASoC: Intel: broadwell: Mark FE DAIs as nonatomic
2020-10-04 9:06 [PATCH 1/4] ASoC: Intel: bdw-rt5650: Mark FE DAIs as nonatomic Cezary Rojewski
2020-10-04 9:06 ` [PATCH 2/4] ASoC: Intel: bdw-rt5677: " Cezary Rojewski
@ 2020-10-04 9:06 ` Cezary Rojewski
2020-10-04 9:06 ` [PATCH 4/4] ASoC: Intel: haswell: " Cezary Rojewski
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Cezary Rojewski @ 2020-10-04 9:06 UTC (permalink / raw)
To: alsa-devel
Cc: lgirdwood, Cezary Rojewski, broonie, tiwai, pierre-louis.bossart
PCM operations for DAI links connected with DSP platform component
involve communication with DSP firmware by IPCs. As IPC protocol may
cause thread to sleep while waiting for a response from DSP, propagate
that information to ALSA core by marking all FE DAIs as nonatomic.
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/intel/boards/broadwell.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/intel/boards/broadwell.c b/sound/soc/intel/boards/broadwell.c
index 648b47190051..77c85f17aca6 100644
--- a/sound/soc/intel/boards/broadwell.c
+++ b/sound/soc/intel/boards/broadwell.c
@@ -174,6 +174,7 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = {
{
.name = "System PCM",
.stream_name = "System Playback/Capture",
+ .nonatomic = 1,
.dynamic = 1,
.trigger = {SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
.ops = &broadwell_fe_ops,
@@ -184,6 +185,7 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = {
{
.name = "Offload0",
.stream_name = "Offload0 Playback",
+ .nonatomic = 1,
.dynamic = 1,
.trigger = {SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
.dpcm_playback = 1,
@@ -192,6 +194,7 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = {
{
.name = "Offload1",
.stream_name = "Offload1 Playback",
+ .nonatomic = 1,
.dynamic = 1,
.trigger = {SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
.dpcm_playback = 1,
@@ -200,6 +203,7 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = {
{
.name = "Loopback PCM",
.stream_name = "Loopback",
+ .nonatomic = 1,
.dynamic = 1,
.trigger = {SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
.dpcm_capture = 1,
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/4] ASoC: Intel: haswell: Mark FE DAIs as nonatomic
2020-10-04 9:06 [PATCH 1/4] ASoC: Intel: bdw-rt5650: Mark FE DAIs as nonatomic Cezary Rojewski
2020-10-04 9:06 ` [PATCH 2/4] ASoC: Intel: bdw-rt5677: " Cezary Rojewski
2020-10-04 9:06 ` [PATCH 3/4] ASoC: Intel: broadwell: " Cezary Rojewski
@ 2020-10-04 9:06 ` Cezary Rojewski
2020-10-05 14:49 ` [PATCH 1/4] ASoC: Intel: bdw-rt5650: " Pierre-Louis Bossart
2020-10-05 17:54 ` Mark Brown
4 siblings, 0 replies; 6+ messages in thread
From: Cezary Rojewski @ 2020-10-04 9:06 UTC (permalink / raw)
To: alsa-devel
Cc: lgirdwood, Cezary Rojewski, broonie, tiwai, pierre-louis.bossart
PCM operations for DAI links connected with DSP platform component
involve communication with DSP firmware by IPCs. As IPC protocol may
cause thread to sleep while waiting for a response from DSP, propagate
that information to ALSA core by marking all FE DAIs as nonatomic.
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/intel/boards/haswell.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/intel/boards/haswell.c b/sound/soc/intel/boards/haswell.c
index c268405e5594..c55d1239e705 100644
--- a/sound/soc/intel/boards/haswell.c
+++ b/sound/soc/intel/boards/haswell.c
@@ -103,6 +103,7 @@ static struct snd_soc_dai_link haswell_rt5640_dais[] = {
{
.name = "System",
.stream_name = "System Playback/Capture",
+ .nonatomic = 1,
.dynamic = 1,
.trigger = {SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
.dpcm_playback = 1,
@@ -112,6 +113,7 @@ static struct snd_soc_dai_link haswell_rt5640_dais[] = {
{
.name = "Offload0",
.stream_name = "Offload0 Playback",
+ .nonatomic = 1,
.dynamic = 1,
.trigger = {SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
.dpcm_playback = 1,
@@ -120,6 +122,7 @@ static struct snd_soc_dai_link haswell_rt5640_dais[] = {
{
.name = "Offload1",
.stream_name = "Offload1 Playback",
+ .nonatomic = 1,
.dynamic = 1,
.trigger = {SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
.dpcm_playback = 1,
@@ -128,6 +131,7 @@ static struct snd_soc_dai_link haswell_rt5640_dais[] = {
{
.name = "Loopback",
.stream_name = "Loopback",
+ .nonatomic = 1,
.dynamic = 1,
.trigger = {SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
.dpcm_capture = 1,
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/4] ASoC: Intel: bdw-rt5650: Mark FE DAIs as nonatomic
2020-10-04 9:06 [PATCH 1/4] ASoC: Intel: bdw-rt5650: Mark FE DAIs as nonatomic Cezary Rojewski
` (2 preceding siblings ...)
2020-10-04 9:06 ` [PATCH 4/4] ASoC: Intel: haswell: " Cezary Rojewski
@ 2020-10-05 14:49 ` Pierre-Louis Bossart
2020-10-05 17:54 ` Mark Brown
4 siblings, 0 replies; 6+ messages in thread
From: Pierre-Louis Bossart @ 2020-10-05 14:49 UTC (permalink / raw)
To: Cezary Rojewski, alsa-devel; +Cc: broonie, tiwai, lgirdwood
On 10/4/20 4:06 AM, Cezary Rojewski wrote:
> PCM operations for DAI links connected with DSP platform component
> involve communication with DSP firmware by IPCs. As IPC protocol may
> cause thread to sleep while waiting for a response from DSP, propagate
> that information to ALSA core by marking all FE DAIs as nonatomic.
I double checked that indeed the machine drivers modified in this series
were the only ones without both .dynamic and .nonatomic set.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks Cezary!
>
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> ---
> sound/soc/intel/boards/bdw-rt5650.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/intel/boards/bdw-rt5650.c b/sound/soc/intel/boards/bdw-rt5650.c
> index c44315af6a4c..aa420b201848 100644
> --- a/sound/soc/intel/boards/bdw-rt5650.c
> +++ b/sound/soc/intel/boards/bdw-rt5650.c
> @@ -232,6 +232,7 @@ static struct snd_soc_dai_link bdw_rt5650_dais[] = {
> {
> .name = "System PCM",
> .stream_name = "System Playback",
> + .nonatomic = 1,
> .dynamic = 1,
> .ops = &bdw_rt5650_fe_ops,
> .trigger = {
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/4] ASoC: Intel: bdw-rt5650: Mark FE DAIs as nonatomic
2020-10-04 9:06 [PATCH 1/4] ASoC: Intel: bdw-rt5650: Mark FE DAIs as nonatomic Cezary Rojewski
` (3 preceding siblings ...)
2020-10-05 14:49 ` [PATCH 1/4] ASoC: Intel: bdw-rt5650: " Pierre-Louis Bossart
@ 2020-10-05 17:54 ` Mark Brown
4 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2020-10-05 17:54 UTC (permalink / raw)
To: alsa-devel, Cezary Rojewski; +Cc: pierre-louis.bossart, tiwai, lgirdwood
On Sun, 4 Oct 2020 11:06:06 +0200, Cezary Rojewski wrote:
> PCM operations for DAI links connected with DSP platform component
> involve communication with DSP firmware by IPCs. As IPC protocol may
> cause thread to sleep while waiting for a response from DSP, propagate
> that information to ALSA core by marking all FE DAIs as nonatomic.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/4] ASoC: Intel: bdw-rt5650: Mark FE DAIs as nonatomic
commit: 4cc62da459aeee438a1fcf009e6101292025476f
[2/4] ASoC: Intel: bdw-rt5677: Mark FE DAIs as nonatomic
commit: fc5c8729c1ef78d54432d68216c1b13791248bb1
[3/4] ASoC: Intel: broadwell: Mark FE DAIs as nonatomic
commit: 727d7d84f74744a6f8d583eb5034e926aecc78e7
[4/4] ASoC: Intel: haswell: Mark FE DAIs as nonatomic
commit: dc155ad5fa6ef7d48fb3c3cc30497b492da0749e
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread