All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: robh@kernel.org, kernel@collabora.com, bleung@chromium.org,
	groeck@chromium.org, sjg@chromium.org, dianders@chromium.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: i2c: convert i2c-cros-ec-tunnel to json-schema
Date: Mon, 5 Oct 2020 11:18:04 +0200	[thread overview]
Message-ID: <20201005091804.2xjwer6ppoog5orm@rcn-XPS-13-9360> (raw)
In-Reply-To: <19e0e78e-f490-8bcb-cfdb-338a577b2205@collabora.com>

Hi Enric, thanks for reviewing the patch.

On lun 05-10-2020 10:52:26, Enric Balletbo i Serra wrote:
> > +examples:
> > +  - |
> > +    cros-ec {
> 
> We try to use always a complete example, and I think that, Rob also prefers
> complete examples, so here you are missing the spi node.

Ok, I'll prepare a new patch with an extended example.

> > +        compatible = "google,cros-ec-spi";
> 
> And, at least, should have a reg. Did not give you an error?

AFAIK, the reg property is only enforced if the node name includes the
unit-address.

Cheers,
Ricardo

  reply	other threads:[~2020-10-05  9:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05  7:13 [PATCH 0/3] Fix checker warnings related to cros-ec binding Ricardo Cañuelo
2020-10-05  7:14 ` [PATCH 1/3] dt-bindings: i2c: convert i2c-cros-ec-tunnel to json-schema Ricardo Cañuelo
2020-10-05  8:52   ` Enric Balletbo i Serra
2020-10-05  9:18     ` Ricardo Cañuelo [this message]
2020-10-05  9:27       ` Enric Balletbo i Serra
2020-10-05 14:04   ` Rob Herring
2020-10-05  7:14 ` [PATCH 2/3] dt-bindings: input: convert cros-ec-keyb " Ricardo Cañuelo
2020-10-05  9:03   ` Enric Balletbo i Serra
2020-10-05  9:35     ` Ricardo Cañuelo
2020-10-05  7:14 ` [PATCH 3/3] dt-bindings: mfd: google,cros-ec: add missing properties Ricardo Cañuelo
2020-10-05  9:23   ` Enric Balletbo i Serra
2020-10-05  9:48     ` Ricardo Cañuelo
2020-10-05 15:37   ` Rob Herring
2020-10-05 15:48     ` Enric Balletbo i Serra
2020-10-06  6:13     ` Ricardo Cañuelo
2020-10-06 11:28       ` Guenter Roeck
2020-10-06 13:07         ` Ricardo Cañuelo
2020-10-06 21:35       ` Rob Herring
2020-10-07  6:31         ` Ricardo Cañuelo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005091804.2xjwer6ppoog5orm@rcn-XPS-13-9360 \
    --to=ricardo.canuelo@collabora.com \
    --cc=bleung@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=kernel@collabora.com \
    --cc=robh@kernel.org \
    --cc=sjg@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.