All of lore.kernel.org
 help / color / mirror / Atom feed
* [chrome-os:chromeos-4.14 1/1] net/qrtr/qrtr.c:206:2: warning: ignoring return value of 'skb_put_padto', declared with attribute warn_unused_result
@ 2020-10-05  8:49 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-10-05  8:49 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 4867 bytes --]

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.14
head:   6f1b377a32a35fa189d19ec97f9c4c1ff7b30602
commit: 6f1b377a32a35fa189d19ec97f9c4c1ff7b30602 [1/1] CHROMIUM: Merge 'v4.14.200' into chromeos-4.14
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
        git fetch --no-tags chrome-os chromeos-4.14
        git checkout 6f1b377a32a35fa189d19ec97f9c4c1ff7b30602
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   net/qrtr/qrtr.c: In function 'qrtr_node_enqueue':
>> net/qrtr/qrtr.c:206:2: warning: ignoring return value of 'skb_put_padto', declared with attribute warn_unused_result [-Wunused-result]
     skb_put_padto(skb, ALIGN(len, 4));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/skb_put_padto +206 net/qrtr/qrtr.c

bdabad3e363d82 Courtney Cavin         2016-05-06  180  
bdabad3e363d82 Courtney Cavin         2016-05-06  181  /* Pass an outgoing packet socket buffer to the endpoint driver. */
29c3f35e9baa2f Bjorn Andersson        2017-10-10  182  static int qrtr_node_enqueue(struct qrtr_node *node, struct sk_buff *skb,
29c3f35e9baa2f Bjorn Andersson        2017-10-10  183  			     int type, struct sockaddr_qrtr *from,
29c3f35e9baa2f Bjorn Andersson        2017-10-10  184  			     struct sockaddr_qrtr *to)
bdabad3e363d82 Courtney Cavin         2016-05-06  185  {
72c0326039d201 Bjorn Andersson        2017-10-10  186  	struct qrtr_hdr_v1 *hdr;
29c3f35e9baa2f Bjorn Andersson        2017-10-10  187  	size_t len = skb->len;
bdabad3e363d82 Courtney Cavin         2016-05-06  188  	int rc = -ENODEV;
bdabad3e363d82 Courtney Cavin         2016-05-06  189  
72c0326039d201 Bjorn Andersson        2017-10-10  190  	hdr = skb_push(skb, sizeof(*hdr));
72c0326039d201 Bjorn Andersson        2017-10-10  191  	hdr->version = cpu_to_le32(QRTR_PROTO_VER_1);
29c3f35e9baa2f Bjorn Andersson        2017-10-10  192  	hdr->type = cpu_to_le32(type);
29c3f35e9baa2f Bjorn Andersson        2017-10-10  193  	hdr->src_node_id = cpu_to_le32(from->sq_node);
29c3f35e9baa2f Bjorn Andersson        2017-10-10  194  	hdr->src_port_id = cpu_to_le32(from->sq_port);
9ab672dce5eec6 Arun Kumar Neelakantam 2018-07-04  195  	if (to->sq_port == QRTR_PORT_CTRL) {
9ab672dce5eec6 Arun Kumar Neelakantam 2018-07-04  196  		hdr->dst_node_id = cpu_to_le32(node->nid);
9ab672dce5eec6 Arun Kumar Neelakantam 2018-07-04  197  		hdr->dst_port_id = cpu_to_le32(QRTR_NODE_BCAST);
9ab672dce5eec6 Arun Kumar Neelakantam 2018-07-04  198  	} else {
29c3f35e9baa2f Bjorn Andersson        2017-10-10  199  		hdr->dst_node_id = cpu_to_le32(to->sq_node);
29c3f35e9baa2f Bjorn Andersson        2017-10-10  200  		hdr->dst_port_id = cpu_to_le32(to->sq_port);
9ab672dce5eec6 Arun Kumar Neelakantam 2018-07-04  201  	}
29c3f35e9baa2f Bjorn Andersson        2017-10-10  202  
29c3f35e9baa2f Bjorn Andersson        2017-10-10  203  	hdr->size = cpu_to_le32(len);
29c3f35e9baa2f Bjorn Andersson        2017-10-10  204  	hdr->confirm_rx = 0;
29c3f35e9baa2f Bjorn Andersson        2017-10-10  205  
29c3f35e9baa2f Bjorn Andersson        2017-10-10 @206  	skb_put_padto(skb, ALIGN(len, 4));
29c3f35e9baa2f Bjorn Andersson        2017-10-10  207  
bdabad3e363d82 Courtney Cavin         2016-05-06  208  	mutex_lock(&node->ep_lock);
bdabad3e363d82 Courtney Cavin         2016-05-06  209  	if (node->ep)
bdabad3e363d82 Courtney Cavin         2016-05-06  210  		rc = node->ep->xmit(node->ep, skb);
bdabad3e363d82 Courtney Cavin         2016-05-06  211  	else
bdabad3e363d82 Courtney Cavin         2016-05-06  212  		kfree_skb(skb);
bdabad3e363d82 Courtney Cavin         2016-05-06  213  	mutex_unlock(&node->ep_lock);
bdabad3e363d82 Courtney Cavin         2016-05-06  214  
bdabad3e363d82 Courtney Cavin         2016-05-06  215  	return rc;
bdabad3e363d82 Courtney Cavin         2016-05-06  216  }
bdabad3e363d82 Courtney Cavin         2016-05-06  217  

:::::: The code at line 206 was first introduced by commit
:::::: 29c3f35e9baa2fc39551c6170e140593d85163a3 UPSTREAM: net: qrtr: Pass source and destination to enqueue functions

:::::: TO: Bjorn Andersson <bjorn.andersson@linaro.org>
:::::: CC: chrome-bot <chrome-bot@chromium.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52656 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-10-05  8:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05  8:49 [chrome-os:chromeos-4.14 1/1] net/qrtr/qrtr.c:206:2: warning: ignoring return value of 'skb_put_padto', declared with attribute warn_unused_result kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.