* [PATCH 7/9 net-next] xfrm: use dev_sw_netstats_rx_add()
@ 2020-10-05 20:36 Fabian Frederick
2020-10-05 23:53 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2020-10-05 20:36 UTC (permalink / raw)
To: davem, kuba, netdev; +Cc: steffen.klassert, herbert, Fabian Frederick
use new helper for netstats settings
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
net/xfrm/xfrm_interface.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
index eb8181987620d..8f8631eafe784 100644
--- a/net/xfrm/xfrm_interface.c
+++ b/net/xfrm/xfrm_interface.c
@@ -210,7 +210,6 @@ static void xfrmi_scrub_packet(struct sk_buff *skb, bool xnet)
static int xfrmi_rcv_cb(struct sk_buff *skb, int err)
{
const struct xfrm_mode *inner_mode;
- struct pcpu_sw_netstats *tstats;
struct net_device *dev;
struct xfrm_state *x;
struct xfrm_if *xi;
@@ -255,13 +254,7 @@ static int xfrmi_rcv_cb(struct sk_buff *skb, int err)
}
xfrmi_scrub_packet(skb, xnet);
-
- tstats = this_cpu_ptr(dev->tstats);
-
- u64_stats_update_begin(&tstats->syncp);
- tstats->rx_packets++;
- tstats->rx_bytes += skb->len;
- u64_stats_update_end(&tstats->syncp);
+ dev_sw_netstats_rx_add(dev, skb->len);
return 0;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 7/9 net-next] xfrm: use dev_sw_netstats_rx_add()
2020-10-05 20:36 [PATCH 7/9 net-next] xfrm: use dev_sw_netstats_rx_add() Fabian Frederick
@ 2020-10-05 23:53 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2020-10-05 23:53 UTC (permalink / raw)
To: Fabian Frederick; +Cc: davem, kuba, netdev, steffen.klassert
On Mon, Oct 05, 2020 at 10:36:34PM +0200, Fabian Frederick wrote:
> use new helper for netstats settings
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> net/xfrm/xfrm_interface.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-05 23:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 20:36 [PATCH 7/9 net-next] xfrm: use dev_sw_netstats_rx_add() Fabian Frederick
2020-10-05 23:53 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.