From: Catalin Marinas <catalin.marinas@arm.com>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: sudeep.holla@arm.com, will@kernel.org, linux@armlinux.org.uk,
rjw@rjwysocki.net, viresh.kumar@linaro.org,
dietmar.eggemann@arm.com, valentin.schneider@arm.com,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cpufreq,arm,arm64: restructure definitions of arch_set_freq_scale()
Date: Wed, 7 Oct 2020 16:21:18 +0100 [thread overview]
Message-ID: <20201007152117.GM3462@gaia> (raw)
In-Reply-To: <20200924123016.13427-2-ionela.voinescu@arm.com>
On Thu, Sep 24, 2020 at 01:30:15PM +0100, Ionela Voinescu wrote:
> Compared to other arch_* functions, arch_set_freq_scale() has an atypical
> weak definition that can be replaced by a strong architecture specific
> implementation.
>
> The more typical support for architectural functions involves defining
> an empty stub in a header file if the symbol is not already defined in
> architecture code. Some examples involve:
> - #define arch_scale_freq_capacity topology_get_freq_scale
> - #define arch_scale_freq_invariant topology_scale_freq_invariant
> - #define arch_scale_cpu_capacity topology_get_cpu_scale
> - #define arch_update_cpu_topology topology_update_cpu_topology
> - #define arch_scale_thermal_pressure topology_get_thermal_pressure
> - #define arch_set_thermal_pressure topology_set_thermal_pressure
>
> Bring arch_set_freq_scale() in line with these functions by renaming it to
> topology_set_freq_scale() in the arch topology driver, and by defining the
> arch_set_freq_scale symbol to point to the new function for arm and arm64.
>
> While there are other users of the arch_topology driver, this patch defines
> arch_set_freq_scale for arm and arm64 only, due to their existing
> definitions of arch_scale_freq_capacity. This is the getter function of the
> frequency invariance scale factor and without a getter function, the
> setter function - arch_set_freq_scale() has not purpose.
>
> Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
For the arm64 changes:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
viresh.kumar@linaro.org, rjw@rjwysocki.net,
linux@armlinux.org.uk, valentin.schneider@arm.com,
sudeep.holla@arm.com, will@kernel.org, dietmar.eggemann@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] cpufreq,arm,arm64: restructure definitions of arch_set_freq_scale()
Date: Wed, 7 Oct 2020 16:21:18 +0100 [thread overview]
Message-ID: <20201007152117.GM3462@gaia> (raw)
In-Reply-To: <20200924123016.13427-2-ionela.voinescu@arm.com>
On Thu, Sep 24, 2020 at 01:30:15PM +0100, Ionela Voinescu wrote:
> Compared to other arch_* functions, arch_set_freq_scale() has an atypical
> weak definition that can be replaced by a strong architecture specific
> implementation.
>
> The more typical support for architectural functions involves defining
> an empty stub in a header file if the symbol is not already defined in
> architecture code. Some examples involve:
> - #define arch_scale_freq_capacity topology_get_freq_scale
> - #define arch_scale_freq_invariant topology_scale_freq_invariant
> - #define arch_scale_cpu_capacity topology_get_cpu_scale
> - #define arch_update_cpu_topology topology_update_cpu_topology
> - #define arch_scale_thermal_pressure topology_get_thermal_pressure
> - #define arch_set_thermal_pressure topology_set_thermal_pressure
>
> Bring arch_set_freq_scale() in line with these functions by renaming it to
> topology_set_freq_scale() in the arch topology driver, and by defining the
> arch_set_freq_scale symbol to point to the new function for arm and arm64.
>
> While there are other users of the arch_topology driver, this patch defines
> arch_set_freq_scale for arm and arm64 only, due to their existing
> definitions of arch_scale_freq_capacity. This is the getter function of the
> frequency invariance scale factor and without a getter function, the
> setter function - arch_set_freq_scale() has not purpose.
>
> Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
For the arm64 changes:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-07 15:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 12:30 [PATCH 0/2]cpufreq,topology,arm: disable FI for BL_SWITCHER Ionela Voinescu
2020-09-24 12:30 ` Ionela Voinescu
2020-09-24 12:30 ` [PATCH 1/2] cpufreq,arm,arm64: restructure definitions of arch_set_freq_scale() Ionela Voinescu
2020-09-24 12:30 ` [PATCH 1/2] cpufreq, arm, arm64: " Ionela Voinescu
2020-10-06 7:05 ` [PATCH 1/2] cpufreq,arm,arm64: " Viresh Kumar
2020-10-06 7:05 ` Viresh Kumar
2020-10-06 17:09 ` Ionela Voinescu
2020-10-06 17:09 ` Ionela Voinescu
2020-10-07 5:12 ` Viresh Kumar
2020-10-07 5:12 ` Viresh Kumar
2020-10-07 15:21 ` Catalin Marinas [this message]
2020-10-07 15:21 ` Catalin Marinas
2020-09-24 12:30 ` [PATCH 2/2] arm: disable frequency invariance for CONFIG_BL_SWITCHER Ionela Voinescu
2020-09-24 12:30 ` Ionela Voinescu
2020-10-06 7:10 ` Viresh Kumar
2020-10-06 7:10 ` Viresh Kumar
2020-10-07 14:34 ` [PATCH 0/2]cpufreq,topology,arm: disable FI for BL_SWITCHER Rafael J. Wysocki
2020-10-07 14:34 ` Rafael J. Wysocki
2020-10-08 14:05 ` Sudeep Holla
2020-10-08 14:05 ` Sudeep Holla
2020-10-08 15:18 ` Rafael J. Wysocki
2020-10-08 15:18 ` Rafael J. Wysocki
2020-10-08 16:07 ` Ionela Voinescu
2020-10-08 16:07 ` Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007152117.GM3462@gaia \
--to=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=valentin.schneider@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.