* [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional"
@ 2020-10-05 14:18 Marco Felsch
2020-10-06 13:27 ` [OE-core] " Richard Purdie
2020-10-07 11:28 ` Richard Purdie
0 siblings, 2 replies; 7+ messages in thread
From: Marco Felsch @ 2020-10-05 14:18 UTC (permalink / raw)
To: openembedded-core; +Cc: mfe
This reverts commit 1217ddf070261c5fe523729b2a833bd38f1e4ccd.
This commit breaks compiling if no initramfs is used because the kernel
image can be compressed too using lzo.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
meta/classes/kernel.bbclass | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 78def5bbc1..06150e8072 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -4,8 +4,7 @@ KERNEL_PACKAGE_NAME ??= "kernel"
KERNEL_DEPLOYSUBDIR ??= "${@ "" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else d.getVar("KERNEL_PACKAGE_NAME") }"
PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
-DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native bison-native"
-DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lzo", "lzop-native", "", d)}"
+DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native bison-native"
DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lz4", "lz4-native", "", d)}"
PACKAGE_WRITE_DEPS += "depmodwrapper-cross"
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional"
2020-10-05 14:18 [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional" Marco Felsch
@ 2020-10-06 13:27 ` Richard Purdie
2020-10-06 14:26 ` Marco Felsch
2020-10-07 11:28 ` Richard Purdie
1 sibling, 1 reply; 7+ messages in thread
From: Richard Purdie @ 2020-10-06 13:27 UTC (permalink / raw)
To: Marco Felsch, openembedded-core; +Cc: mfe
On Mon, 2020-10-05 at 16:18 +0200, Marco Felsch wrote:
> This reverts commit 1217ddf070261c5fe523729b2a833bd38f1e4ccd.
>
> This commit breaks compiling if no initramfs is used because the
> kernel image can be compressed too using lzo.
Can we detect if the kernel is due to be compressed with lzo through
any of our configuration variables?
Cheers,
Richard
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional"
2020-10-06 13:27 ` [OE-core] " Richard Purdie
@ 2020-10-06 14:26 ` Marco Felsch
2020-10-06 14:27 ` Richard Purdie
0 siblings, 1 reply; 7+ messages in thread
From: Marco Felsch @ 2020-10-06 14:26 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 20-10-06 14:27, Richard Purdie wrote:
> On Mon, 2020-10-05 at 16:18 +0200, Marco Felsch wrote:
> > This reverts commit 1217ddf070261c5fe523729b2a833bd38f1e4ccd.
> >
> > This commit breaks compiling if no initramfs is used because the
> > kernel image can be compressed too using lzo.
>
> Can we detect if the kernel is due to be compressed with lzo through
> any of our configuration variables?
I thought about it too.. We need to grep the .config and check if the
Kconfig was set either by the defconfig we are providing or by some
inheritance.
Regards,
Marco
>
> Cheers,
>
> Richard
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional"
2020-10-06 14:26 ` Marco Felsch
@ 2020-10-06 14:27 ` Richard Purdie
2020-10-06 15:57 ` Marco Felsch
0 siblings, 1 reply; 7+ messages in thread
From: Richard Purdie @ 2020-10-06 14:27 UTC (permalink / raw)
To: Marco Felsch; +Cc: openembedded-core
On Tue, 2020-10-06 at 16:26 +0200, Marco Felsch wrote:
> On 20-10-06 14:27, Richard Purdie wrote:
> > On Mon, 2020-10-05 at 16:18 +0200, Marco Felsch wrote:
> > > This reverts commit 1217ddf070261c5fe523729b2a833bd38f1e4ccd.
> > >
> > > This commit breaks compiling if no initramfs is used because the
> > > kernel image can be compressed too using lzo.
> >
> > Can we detect if the kernel is due to be compressed with lzo
> > through
> > any of our configuration variables?
>
> I thought about it too.. We need to grep the .config and check if the
> Kconfig was set either by the defconfig we are providing or by some
> inheritance.
Grepping the .config isn't an option as we need to determine this at
parse time. I did wondering the kernel type/output name style variables
would tell us but it sounds like that isn't the case :(
Cheers,
Richard
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional"
2020-10-06 14:27 ` Richard Purdie
@ 2020-10-06 15:57 ` Marco Felsch
0 siblings, 0 replies; 7+ messages in thread
From: Marco Felsch @ 2020-10-06 15:57 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 20-10-06 15:27, Richard Purdie wrote:
> On Tue, 2020-10-06 at 16:26 +0200, Marco Felsch wrote:
> > On 20-10-06 14:27, Richard Purdie wrote:
> > > On Mon, 2020-10-05 at 16:18 +0200, Marco Felsch wrote:
> > > > This reverts commit 1217ddf070261c5fe523729b2a833bd38f1e4ccd.
> > > >
> > > > This commit breaks compiling if no initramfs is used because the
> > > > kernel image can be compressed too using lzo.
> > >
> > > Can we detect if the kernel is due to be compressed with lzo
> > > through
> > > any of our configuration variables?
> >
> > I thought about it too.. We need to grep the .config and check if the
> > Kconfig was set either by the defconfig we are providing or by some
> > inheritance.
>
> Grepping the .config isn't an option as we need to determine this at
> parse time.
That was my conclusion too.
> I did wondering the kernel type/output name style variables
> would tell us but it sounds like that isn't the case :(
Nope you can't, e.g. arm compressed images are always named
zImage.
Regards,
Marco
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional"
2020-10-05 14:18 [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional" Marco Felsch
2020-10-06 13:27 ` [OE-core] " Richard Purdie
@ 2020-10-07 11:28 ` Richard Purdie
2020-10-07 15:59 ` Marco Felsch
1 sibling, 1 reply; 7+ messages in thread
From: Richard Purdie @ 2020-10-07 11:28 UTC (permalink / raw)
To: Marco Felsch, openembedded-core; +Cc: mfe, Bruce Ashfield
On Mon, 2020-10-05 at 16:18 +0200, Marco Felsch wrote:
> This reverts commit 1217ddf070261c5fe523729b2a833bd38f1e4ccd.
>
> This commit breaks compiling if no initramfs is used because the kernel
> image can be compressed too using lzo.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> meta/classes/kernel.bbclass | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 78def5bbc1..06150e8072 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -4,8 +4,7 @@ KERNEL_PACKAGE_NAME ??= "kernel"
> KERNEL_DEPLOYSUBDIR ??= "${@ "" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else d.getVar("KERNEL_PACKAGE_NAME") }"
>
> PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
> -DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native bison-native"
> -DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lzo", "lzop-native", "", d)}"
> +DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native bison-native"
> DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lz4", "lz4-native", "", d)}"
> PACKAGE_WRITE_DEPS += "depmodwrapper-cross"
I've been giving this more thought, we can't simply add every possible
DEPENDS in kernel.bbclass.
In this case if a recipe is enabling lzo compression on the kernel,
perhaps it should just add DEPENDS += "lzop-native" itself?
Cheers,
Richard
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional"
2020-10-07 11:28 ` Richard Purdie
@ 2020-10-07 15:59 ` Marco Felsch
0 siblings, 0 replies; 7+ messages in thread
From: Marco Felsch @ 2020-10-07 15:59 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core, Bruce Ashfield
On 20-10-07 12:28, Richard Purdie wrote:
> On Mon, 2020-10-05 at 16:18 +0200, Marco Felsch wrote:
> > This reverts commit 1217ddf070261c5fe523729b2a833bd38f1e4ccd.
> >
> > This commit breaks compiling if no initramfs is used because the kernel
> > image can be compressed too using lzo.
> >
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> > meta/classes/kernel.bbclass | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> > index 78def5bbc1..06150e8072 100644
> > --- a/meta/classes/kernel.bbclass
> > +++ b/meta/classes/kernel.bbclass
> > @@ -4,8 +4,7 @@ KERNEL_PACKAGE_NAME ??= "kernel"
> > KERNEL_DEPLOYSUBDIR ??= "${@ "" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else d.getVar("KERNEL_PACKAGE_NAME") }"
> >
> > PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
> > -DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native bison-native"
> > -DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lzo", "lzop-native", "", d)}"
> > +DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native bison-native"
> > DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lz4", "lz4-native", "", d)}"
> > PACKAGE_WRITE_DEPS += "depmodwrapper-cross"
>
> I've been giving this more thought, we can't simply add every possible
> DEPENDS in kernel.bbclass.
>
> In this case if a recipe is enabling lzo compression on the kernel,
> perhaps it should just add DEPENDS += "lzop-native" itself?
You're absolutely right and I would have no doubts going this way if we
won't have this dependency since 2016. I think this will break a lot of
builds. We can go this if that doesn't matter, but I would drop the
dynamically added DEPENDS which would be added in case of
INITRAMFS_FSTYPES. So the BSP needs to specify the correct DEPS all the
time.
Regards,
Marco
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-07 15:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 14:18 [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional" Marco Felsch
2020-10-06 13:27 ` [OE-core] " Richard Purdie
2020-10-06 14:26 ` Marco Felsch
2020-10-06 14:27 ` Richard Purdie
2020-10-06 15:57 ` Marco Felsch
2020-10-07 11:28 ` Richard Purdie
2020-10-07 15:59 ` Marco Felsch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.