All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2] arm64: dts imx8mn: Remove non-existent USB OTG2
@ 2020-10-08 18:33 ` Adam Ford
  0 siblings, 0 replies; 6+ messages in thread
From: Adam Ford @ 2020-10-08 18:33 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: aford, krzk, Adam Ford, Rob Herring, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Anson Huang, devicetree, linux-kernel

According to the i.MX8MN TRM, there is only one OTG port.  The
address for OTG2 is reserved on Nano.

This patch removes the non-existent OTG2, usbphynop2, and the usbmisc2
nodes.

Fixes: 6c3debcbae47 ("arm64: dts: freescale: Add i.MX8MN dtsi support")

Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2:  Remove usbmisc2 and usbphynop2 in addition to the otg2 node.

diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 746faf1cf2fb..16c7202885d7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -790,28 +790,6 @@ usbmisc1: usbmisc@32e40200 {
 				#index-cells = <1>;
 				reg = <0x32e40200 0x200>;
 			};
-
-			usbotg2: usb@32e50000 {
-				compatible = "fsl,imx8mn-usb", "fsl,imx7d-usb";
-				reg = <0x32e50000 0x200>;
-				interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MN_CLK_USB1_CTRL_ROOT>;
-				clock-names = "usb1_ctrl_root_clk";
-				assigned-clocks = <&clk IMX8MN_CLK_USB_BUS>,
-						  <&clk IMX8MN_CLK_USB_CORE_REF>;
-				assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_500M>,
-							 <&clk IMX8MN_SYS_PLL1_100M>;
-				fsl,usbphy = <&usbphynop2>;
-				fsl,usbmisc = <&usbmisc2 0>;
-				status = "disabled";
-			};
-
-			usbmisc2: usbmisc@32e50200 {
-				compatible = "fsl,imx8mn-usbmisc", "fsl,imx7d-usbmisc";
-				#index-cells = <1>;
-				reg = <0x32e50200 0x200>;
-			};
-
 		};
 
 		dma_apbh: dma-controller@33000000 {
@@ -876,12 +854,4 @@ usbphynop1: usbphynop1 {
 		assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_100M>;
 		clock-names = "main_clk";
 	};
-
-	usbphynop2: usbphynop2 {
-		compatible = "usb-nop-xceiv";
-		clocks = <&clk IMX8MN_CLK_USB_PHY_REF>;
-		assigned-clocks = <&clk IMX8MN_CLK_USB_PHY_REF>;
-		assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_100M>;
-		clock-names = "main_clk";
-	};
 };
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH V2] arm64: dts imx8mn: Remove non-existent USB OTG2
@ 2020-10-08 18:33 ` Adam Ford
  0 siblings, 0 replies; 6+ messages in thread
From: Adam Ford @ 2020-10-08 18:33 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: devicetree, Fabio Estevam, Anson Huang, Adam Ford, Sascha Hauer,
	aford, krzk, linux-kernel, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo

According to the i.MX8MN TRM, there is only one OTG port.  The
address for OTG2 is reserved on Nano.

This patch removes the non-existent OTG2, usbphynop2, and the usbmisc2
nodes.

Fixes: 6c3debcbae47 ("arm64: dts: freescale: Add i.MX8MN dtsi support")

Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2:  Remove usbmisc2 and usbphynop2 in addition to the otg2 node.

diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 746faf1cf2fb..16c7202885d7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -790,28 +790,6 @@ usbmisc1: usbmisc@32e40200 {
 				#index-cells = <1>;
 				reg = <0x32e40200 0x200>;
 			};
-
-			usbotg2: usb@32e50000 {
-				compatible = "fsl,imx8mn-usb", "fsl,imx7d-usb";
-				reg = <0x32e50000 0x200>;
-				interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MN_CLK_USB1_CTRL_ROOT>;
-				clock-names = "usb1_ctrl_root_clk";
-				assigned-clocks = <&clk IMX8MN_CLK_USB_BUS>,
-						  <&clk IMX8MN_CLK_USB_CORE_REF>;
-				assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_500M>,
-							 <&clk IMX8MN_SYS_PLL1_100M>;
-				fsl,usbphy = <&usbphynop2>;
-				fsl,usbmisc = <&usbmisc2 0>;
-				status = "disabled";
-			};
-
-			usbmisc2: usbmisc@32e50200 {
-				compatible = "fsl,imx8mn-usbmisc", "fsl,imx7d-usbmisc";
-				#index-cells = <1>;
-				reg = <0x32e50200 0x200>;
-			};
-
 		};
 
 		dma_apbh: dma-controller@33000000 {
@@ -876,12 +854,4 @@ usbphynop1: usbphynop1 {
 		assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_100M>;
 		clock-names = "main_clk";
 	};
-
-	usbphynop2: usbphynop2 {
-		compatible = "usb-nop-xceiv";
-		clocks = <&clk IMX8MN_CLK_USB_PHY_REF>;
-		assigned-clocks = <&clk IMX8MN_CLK_USB_PHY_REF>;
-		assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_100M>;
-		clock-names = "main_clk";
-	};
 };
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] arm64: dts imx8mn: Remove non-existent USB OTG2
  2020-10-08 18:33 ` Adam Ford
@ 2020-10-08 18:34   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-08 18:34 UTC (permalink / raw)
  To: Adam Ford
  Cc: linux-arm-kernel, aford, Rob Herring, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Anson Huang, devicetree, linux-kernel

On Thu, Oct 08, 2020 at 01:33:00PM -0500, Adam Ford wrote:
> According to the i.MX8MN TRM, there is only one OTG port.  The
> address for OTG2 is reserved on Nano.
> 
> This patch removes the non-existent OTG2, usbphynop2, and the usbmisc2
> nodes.
> 
> Fixes: 6c3debcbae47 ("arm64: dts: freescale: Add i.MX8MN dtsi support")
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2:  Remove usbmisc2 and usbphynop2 in addition to the otg2 node.
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] arm64: dts imx8mn: Remove non-existent USB OTG2
@ 2020-10-08 18:34   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-08 18:34 UTC (permalink / raw)
  To: Adam Ford
  Cc: devicetree, Anson Huang, Fabio Estevam, Sascha Hauer, aford,
	linux-kernel, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo, linux-arm-kernel

On Thu, Oct 08, 2020 at 01:33:00PM -0500, Adam Ford wrote:
> According to the i.MX8MN TRM, there is only one OTG port.  The
> address for OTG2 is reserved on Nano.
> 
> This patch removes the non-existent OTG2, usbphynop2, and the usbmisc2
> nodes.
> 
> Fixes: 6c3debcbae47 ("arm64: dts: freescale: Add i.MX8MN dtsi support")
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2:  Remove usbmisc2 and usbphynop2 in addition to the otg2 node.
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] arm64: dts imx8mn: Remove non-existent USB OTG2
  2020-10-08 18:33 ` Adam Ford
@ 2020-10-30  8:34   ` Shawn Guo
  -1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-10-30  8:34 UTC (permalink / raw)
  To: Adam Ford
  Cc: linux-arm-kernel, aford, krzk, Rob Herring, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Anson Huang, devicetree, linux-kernel

On Thu, Oct 08, 2020 at 01:33:00PM -0500, Adam Ford wrote:
> According to the i.MX8MN TRM, there is only one OTG port.  The
> address for OTG2 is reserved on Nano.
> 
> This patch removes the non-existent OTG2, usbphynop2, and the usbmisc2
> nodes.
> 
> Fixes: 6c3debcbae47 ("arm64: dts: freescale: Add i.MX8MN dtsi support")
> 

This newline is not really necessary.

> Signed-off-by: Adam Ford <aford173@gmail.com>

Applied, thanks.

> ---
> V2:  Remove usbmisc2 and usbphynop2 in addition to the otg2 node.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] arm64: dts imx8mn: Remove non-existent USB OTG2
@ 2020-10-30  8:34   ` Shawn Guo
  0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-10-30  8:34 UTC (permalink / raw)
  To: Adam Ford
  Cc: devicetree, Anson Huang, Sascha Hauer, aford, krzk, linux-kernel,
	Rob Herring, NXP Linux Team, Pengutronix Kernel Team,
	Fabio Estevam, linux-arm-kernel

On Thu, Oct 08, 2020 at 01:33:00PM -0500, Adam Ford wrote:
> According to the i.MX8MN TRM, there is only one OTG port.  The
> address for OTG2 is reserved on Nano.
> 
> This patch removes the non-existent OTG2, usbphynop2, and the usbmisc2
> nodes.
> 
> Fixes: 6c3debcbae47 ("arm64: dts: freescale: Add i.MX8MN dtsi support")
> 

This newline is not really necessary.

> Signed-off-by: Adam Ford <aford173@gmail.com>

Applied, thanks.

> ---
> V2:  Remove usbmisc2 and usbphynop2 in addition to the otg2 node.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-10-30  8:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 18:33 [PATCH V2] arm64: dts imx8mn: Remove non-existent USB OTG2 Adam Ford
2020-10-08 18:33 ` Adam Ford
2020-10-08 18:34 ` Krzysztof Kozlowski
2020-10-08 18:34   ` Krzysztof Kozlowski
2020-10-30  8:34 ` Shawn Guo
2020-10-30  8:34   ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.