* [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify()
@ 2020-10-08 18:53 Heinrich Schuchardt
2020-10-12 3:34 ` Simon Glass
2020-10-13 14:07 ` Tom Rini
0 siblings, 2 replies; 5+ messages in thread
From: Heinrich Schuchardt @ 2020-10-08 18:53 UTC (permalink / raw)
To: u-boot
Remove initialization of ret with unused value.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
lib/rsa/rsa-verify.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c
index 2057f6819d..be55a4376f 100644
--- a/lib/rsa/rsa-verify.c
+++ b/lib/rsa/rsa-verify.c
@@ -540,7 +540,7 @@ int rsa_verify(struct image_sign_info *info,
{
/* Reserve memory for maximum checksum-length */
uint8_t hash[info->crypto->key_len];
- int ret = -EACCES;
+ int ret;
/*
* Verify that the checksum-length does not exceed the
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify()
2020-10-08 18:53 [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify() Heinrich Schuchardt
@ 2020-10-12 3:34 ` Simon Glass
2020-10-13 14:07 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Simon Glass @ 2020-10-12 3:34 UTC (permalink / raw)
To: u-boot
On Thu, 8 Oct 2020 at 12:53, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Remove initialization of ret with unused value.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> lib/rsa/rsa-verify.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify()
2020-10-08 18:53 [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify() Heinrich Schuchardt
2020-10-12 3:34 ` Simon Glass
@ 2020-10-13 14:07 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2020-10-13 14:07 UTC (permalink / raw)
To: u-boot
On Thu, Oct 08, 2020 at 08:53:13PM +0200, Heinrich Schuchardt wrote:
> Remove initialization of ret with unused value.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201013/7baef586/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify()
2020-08-20 18:29 Heinrich Schuchardt
@ 2020-08-22 15:09 ` Simon Glass
0 siblings, 0 replies; 5+ messages in thread
From: Simon Glass @ 2020-08-22 15:09 UTC (permalink / raw)
To: u-boot
On Thu, 20 Aug 2020 at 12:29, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Remove initialization of ret with unused value.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> lib/rsa/rsa-verify.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify()
@ 2020-08-20 18:29 Heinrich Schuchardt
2020-08-22 15:09 ` Simon Glass
0 siblings, 1 reply; 5+ messages in thread
From: Heinrich Schuchardt @ 2020-08-20 18:29 UTC (permalink / raw)
To: u-boot
Remove initialization of ret with unused value.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
lib/rsa/rsa-verify.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c
index 2057f6819d..be55a4376f 100644
--- a/lib/rsa/rsa-verify.c
+++ b/lib/rsa/rsa-verify.c
@@ -540,7 +540,7 @@ int rsa_verify(struct image_sign_info *info,
{
/* Reserve memory for maximum checksum-length */
uint8_t hash[info->crypto->key_len];
- int ret = -EACCES;
+ int ret;
/*
* Verify that the checksum-length does not exceed the
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-13 14:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 18:53 [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify() Heinrich Schuchardt
2020-10-12 3:34 ` Simon Glass
2020-10-13 14:07 ` Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2020-08-20 18:29 Heinrich Schuchardt
2020-08-22 15:09 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.