* Re: [PATCH 08/14] mpt3sas: Update hba_port objects after host reset
@ 2020-10-09 23:49 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2020-10-09 23:49 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 7775 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201009171440.4949-9-sreekanth.reddy@broadcom.com>
References: <20201009171440.4949-9-sreekanth.reddy@broadcom.com>
TO: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
TO: martin.petersen(a)oracle.com
CC: linux-scsi(a)vger.kernel.org
CC: sathya.prakash(a)broadcom.com
CC: suganath-prabu.subramani(a)broadcom.com
CC: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Hi Sreekanth,
I love your patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on mkp-scsi/for-next v5.9-rc8 next-20201009]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sreekanth-Reddy/mpt3sas-Add-support-for-multi-port-path-topology/20201010-011607
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: s390-randconfig-m031-20201009 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/scsi/mpt3sas/mpt3sas_scsih.c:5940 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'.
Old smatch warnings:
drivers/scsi/mpt3sas/mpt3sas_scsih.c:5949 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'.
drivers/scsi/mpt3sas/mpt3sas_scsih.c:5961 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'.
drivers/scsi/mpt3sas/mpt3sas_scsih.c:6472 _scsih_expander_add() warn: returning -1 instead of -ENOMEM is sloppy
drivers/scsi/mpt3sas/mpt3sas_scsih.c:10234 _mpt3sas_fw_work() warn: inconsistent indenting
vim +/matched_code +5940 drivers/scsi/mpt3sas/mpt3sas_scsih.c
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5897
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5898 /**
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5899 * _scsih_look_and_get_matched_port_entry - Get matched hba port entry
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5900 * from HBA port table
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5901 * @ioc: per adapter object
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5902 * @port_entry - hba port entry from temporary port table which needs to be
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5903 * searched for matched entry in the HBA port table
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5904 * @matched_port_entry - save matched hba port entry here
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5905 * @count - count of matched entries
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5906 *
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5907 * return type of matched entry found.
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5908 */
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5909 static enum hba_port_matched_codes
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5910 _scsih_look_and_get_matched_port_entry(struct MPT3SAS_ADAPTER *ioc,
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5911 struct hba_port *port_entry,
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5912 struct hba_port **matched_port_entry, int *count)
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5913 {
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5914 struct hba_port *port_table_entry, *matched_port = NULL;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5915 enum hba_port_matched_codes matched_code;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5916 int lcount = 0;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5917 *matched_port_entry = NULL;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5918
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5919 list_for_each_entry(port_table_entry, &ioc->port_table_list, list) {
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5920 if (!(port_table_entry->flags & HBA_PORT_FLAG_DIRTY_PORT))
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5921 continue;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5922
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5923 if ((port_table_entry->sas_address == port_entry->sas_address)
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5924 && (port_table_entry->phy_mask == port_entry->phy_mask)) {
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5925 matched_code = MATCHED_WITH_ADDR_AND_PHYMASK;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5926 matched_port = port_table_entry;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5927 break;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5928 }
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5929
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5930 if ((port_table_entry->sas_address == port_entry->sas_address)
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5931 && (port_table_entry->phy_mask & port_entry->phy_mask)
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5932 && (port_table_entry->port_id == port_entry->port_id)) {
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5933 matched_code = MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5934 matched_port = port_table_entry;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5935 continue;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5936 }
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5937
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5938 if ((port_table_entry->sas_address == port_entry->sas_address)
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5939 && (port_table_entry->phy_mask & port_entry->phy_mask)) {
2756bd46f6fdde Sreekanth Reddy 2020-10-09 @5940 if (matched_code ==
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5941 MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT)
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5942 continue;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5943 matched_code = MATCHED_WITH_ADDR_AND_SUBPHYMASK;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5944 matched_port = port_table_entry;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5945 continue;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5946 }
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5947
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5948 if (port_table_entry->sas_address == port_entry->sas_address) {
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5949 if (matched_code ==
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5950 MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT)
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5951 continue;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5952 if (matched_code == MATCHED_WITH_ADDR_AND_SUBPHYMASK)
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5953 continue;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5954 matched_code = MATCHED_WITH_ADDR;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5955 matched_port = port_table_entry;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5956 lcount++;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5957 }
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5958 }
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5959
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5960 *matched_port_entry = matched_port;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5961 if (matched_code == MATCHED_WITH_ADDR)
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5962 *count = lcount;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5963 return matched_code;
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5964 }
2756bd46f6fdde Sreekanth Reddy 2020-10-09 5965
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29356 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 00/14] mpt3sas: Add support for multi-port path topology
@ 2020-10-09 17:14 Sreekanth Reddy
2020-10-09 17:14 ` [PATCH 08/14] mpt3sas: Update hba_port objects after host reset Sreekanth Reddy
0 siblings, 1 reply; 5+ messages in thread
From: Sreekanth Reddy @ 2020-10-09 17:14 UTC (permalink / raw)
To: martin.petersen
Cc: linux-scsi, sathya.prakash, suganath-prabu.subramani, Sreekanth Reddy
[-- Attachment #1: Type: text/plain, Size: 4278 bytes --]
Multi-port path topology example:
Zone 1 Zone 2
|-----------------| |----------------|
| HD1 ..... HD25 | | HD26 ......HD50|
| |==================================| |
| | | | | |
| | Expander | |
| |==================================| |
| | | | | |
|-----------|-----| |----|-----------|
x8| |x8
_______|______________|_______
| HBA |
|____________________________|
In this topology, zoning is enabled in such a way that drives from HD1
to HD25 are accessible only through zone1 and drives from HD26 to HD50 are
accessible only through zone2. Here the first x8 connection bw HBA to
Expander in zone1 will have one PortID and second x8 connection bw HBA to
Expander in Zone2 will another PortID.
Problem statement:
When zoning is enabled in expander then we will have two expander
instances (for a single real expander), one instance is accessible through
the first x8 connection and second instance is accessible through
second x8 connection from HBA. But for both the instances the
SAS Address of the expander will be the same.
But in current mpt3sas driver, driver add's only one expander instance,
when second expander instance's 'add' event comes then driver ignores
this event assumues that it is duplicate instance as it already
has a sas_expander object in it's sas_expander_list list with
the same SAS Address. So in this topology users will see only 25 drives
instead of 50 drives.
Current mpt3sas driver use ‘SAS Address’ as a key to uniquely identify
the End devices or Expander devices, but on the multi-port path topologies
(such as above topology) HBA firmware will provide multiple device entries
with different Device handles for a single device.
So here driver can't use ‘SAS Address’ as a key instead driver can use
‘SAS Address’ & ‘PhysicalPort (i.e. PortID)’ number as key to uniquely
identify the device.
where, PhysicalPort is a HBA port number through which the device is
accessible.
Solution:
Now driver uses both 'SAS Address' & 'PhysicalPort' number as a key to
uniquely identify the device object from the corresponding device
list's. So, when 'add' event comes for second instance of expander,
now driver can't find the sas_expander object with same 'SAS Address' &
'PhysicalPort' number (since for this second instance PhysicalPort
number will be different from first instance's PhysicalPort number)
from the sas_expander_list list. So the driver processes this event and
will create a new sas_expander object for this expander instance
and adds it sas_expander_list.
With this solution, the driver will have two sas_expander objects, one
object is for the first instance of the expander, another object is for
second instance of the driver. Now users will access all 50 drives from
above topology.
Like device SAS Address, PhysicalPort number is readily available
from below config pages,
* SAS IO Unit Page 0,
* SAS Device Page 0,
* SAS Expander Page 0,
* SAS Phy Page 0, etc
Through this patch set, the driver now manages the sas_device &
sas_expander objects using 'SAS Address' & 'PhysicalPort'
number as key.
Sreekanth Reddy (14):
mpt3sas: Define hba_port structure
mpt3sas: Allocate memory for hba_port objects
mpt3sas: Rearrange _scsih_mark_responding_sas_device()
mpt3sas: Update hba_port's sas_address & phy_mask
mpt3sas: Get device objects using sas_address & portID
mpt3sas: Rename transport_del_phy_from_an_existing_port
mpt3sas: Get sas_device objects using device's rphy
mpt3sas: Update hba_port objects after host reset
mpt3sas: Set valid PhysicalPort in SMPPassThrough
mpt3sas: Handling HBA vSES device
mpt3sas: Add bypass_dirty_port_flag parameter
mpt3sas: Handle vSES vphy object during HBA reset
mpt3sas: add module parameter multipath_on_hba
mpt3sas: Bump driver version to 35.101.00.00
drivers/scsi/mpt3sas/mpt3sas_base.h | 102 +-
drivers/scsi/mpt3sas/mpt3sas_ctl.c | 6 +-
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1237 +++++++++++++++++++---
drivers/scsi/mpt3sas/mpt3sas_transport.c | 312 +++++-
4 files changed, 1455 insertions(+), 202 deletions(-)
--
2.18.4
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4175 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 08/14] mpt3sas: Update hba_port objects after host reset 2020-10-09 17:14 [PATCH 00/14] mpt3sas: Add support for multi-port path topology Sreekanth Reddy @ 2020-10-09 17:14 ` Sreekanth Reddy 2020-10-12 12:22 ` Dan Carpenter 0 siblings, 1 reply; 5+ messages in thread From: Sreekanth Reddy @ 2020-10-09 17:14 UTC (permalink / raw) To: martin.petersen Cc: linux-scsi, sathya.prakash, suganath-prabu.subramani, Sreekanth Reddy [-- Attachment #1: Type: text/plain, Size: 18932 bytes --] During host reset there are chances that the Port number allocated by the firmware for the attached devices may change. Also it may be possible that some HBA phy’s may go down/come up after reset. So the driver can’t just trust the HBA Port table that it has populated before host reset as valid. So it has to update the HBA Port table in such a way that it shouldn’t disturb the drives which are still accessible even after host reset. Driver follows below algorithm to update the ‘HBA Port table’ during host reset, I. After host reset operation and before marking the devices as responding/non-responding, create a temporary Port table called “New Port table” by parsing each of the HBA PHY’s Phy data info read from SAS IOUnit Page0, a. Check whether Phy’s negotiated link rate is greater than 1.5Gbps, if not go to next Phy, b. Get the SAS Address of the attached device, c. Create a new entry in the ‘New Port table’ with SAS Address field filled with attached device’s SAS Address, port number with Phy’s Port number (read from SAS IOUnit Page0) and enable bit in the ‘Phy mask’ field corresponding to current Phy number. New entry is created only if the driver won’t find any entry in the ‘New Port table’ which matches with attached device ‘SAS Address’ & ‘Port Number’. If it finds an entry with matches with attached device ‘SAS Address’ & ‘Port Number’ then the driver takes that matched entry and will enable current Phy number bit in the ‘Phy mask’ field. d. After parsing all the HBA phy’s info, the driver will have complete Port table info in “New Port table”. II. Mark all the existing sas_device & sas_expander device structures as ‘dirty’. III. Mark each entry of the HBA Port list’s as ‘dirty’. IV. Take each entry from ‘New Port table’ one by one and check whether the taken entry has any corresponding matched entry (which is marked as ‘dirty’) in the HBA Port table or not. While looking for a corresponding matched entry, look for matched entry in the sequence from top row to bottom row listed in below table. If you find any matched entry (according to any of the rules tabulated below) then perform the action mentioned in the ‘Action’ column in that matched rule. =========================================================================== |Search |SAS | Phy Mask | Port | Possibilities| Action | |every |Address | or | Number | | required | |entry |matched?| subset of| matched?| | | |in below| | phy mask | | | | |sequence| | matched? | | | | =========================================================================== | 1 |matched | matched | matched | nothing |* unmark HBA port | | | | | | changed |table entry as | | | | | | |dirty | --------------------------------------------------------------------------- | 2 |matched | matched | not | port number |* Update port | | | | | matched | is changed |number in the | | | | | | |matched port table | | | | | | |entry | | | | | | |* unmask HBA port | | | | | | |table entry as | | | | | | | dirty | --------------------------------------------------------------------------- | 3.a |matched | subset of| matched |some phys |*Add these new phys| | | | phy mask | (or) |might have |to current port in | | | | matched | not |enabled which |STL | | | | | matched |are previously|* Update phy mask | | | | | (but |disabled |field in HBA's port| | | | | first | |tables's matched | | | | | look for| |entry, | | | | | matched | |*Update port number| | | | | one) | |in the matched port| | | | | | |table entry (if | | | | | | |port number is | | | | | | |changed), | | | | | | |* Unmask HBA port | | | | | | |table entry as | | | | | | |dirty | --------------------------------------------------------------------------- | 3.b |matched | subset of| matched |some phys |*Remove these phys | | | | phy mask | (or) |might have |from current port | | | | matched | not |disabled which|in STL | | | | | matched |are previously|* Update phy mask | | | | | (but |enabled |field in HBA's port| | | | | first | |tables's matched | | | | | look for| |entry, | | | | | matched | |*Update port number| | | | | one) | |in the matched port| | | | | | |table entry (if | | | | | | |port number is | | | | | | |changed), | | | | | | |* Unmask HBA port | | | | | | |table entry as | | | | | | |dirty | --------------------------------------------------------------------------- | 4 |matched | not | matched |A cable |*Remove old phys & | | | | matched | (or) |attached to an|new phys to current| | | | | not |expander is |port in STL | | | | | matched |changed to |* Update phy mask | | | | | |another HBA |field in HBA's port| | | | | |port during |tables's matched | | | | | |reset |entry, | | | | | | |*Update port number| | | | | | |in the matched port| | | | | | |table entry (if | | | | | | |port number is | | | | | | |changed), | | | | | | |* Unmask HBA port | | | | | | |table entry as | | | | | | |dirty | --------------------------------------------------------------------------- V. Delete the hba_port objects which are still marked as dirty. Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 337 +++++++++++++++++++++++++++ 1 file changed, 337 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index afb381d..05d43c4 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -5816,6 +5816,341 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index, u32 reply) return 0; } +/** + * _scsih_get_port_table_after_reset - Construct temporary port table + * @ioc: per adapter object + * @port_table: address where port table needs to be constructed + * + * return number of HBA port entries available after reset. + */ +static int +_scsih_get_port_table_after_reset(struct MPT3SAS_ADAPTER *ioc, + struct hba_port *port_table) +{ + u16 sz, ioc_status; + int i, j; + Mpi2ConfigReply_t mpi_reply; + Mpi2SasIOUnitPage0_t *sas_iounit_pg0 = NULL; + u16 attached_handle; + u64 attached_sas_addr; + u8 found = 0, port_count = 0, port_id; + + sz = offsetof(Mpi2SasIOUnitPage0_t, PhyData) + (ioc->sas_hba.num_phys + * sizeof(Mpi2SasIOUnit0PhyData_t)); + sas_iounit_pg0 = kzalloc(sz, GFP_KERNEL); + if (!sas_iounit_pg0) { + ioc_err(ioc, "failure at %s:%d/%s()!\n", + __FILE__, __LINE__, __func__); + return port_count; + } + + if ((mpt3sas_config_get_sas_iounit_pg0(ioc, &mpi_reply, + sas_iounit_pg0, sz)) != 0) + goto out; + ioc_status = le16_to_cpu(mpi_reply.IOCStatus) & MPI2_IOCSTATUS_MASK; + if (ioc_status != MPI2_IOCSTATUS_SUCCESS) + goto out; + for (i = 0; i < ioc->sas_hba.num_phys; i++) { + found = 0; + if ((sas_iounit_pg0->PhyData[i].NegotiatedLinkRate >> 4) < + MPI2_SAS_NEG_LINK_RATE_1_5) + continue; + attached_handle = + le16_to_cpu(sas_iounit_pg0->PhyData[i].AttachedDevHandle); + if (_scsih_get_sas_address( + ioc, attached_handle, &attached_sas_addr) != 0) { + ioc_err(ioc, "failure at %s:%d/%s()!\n", + __FILE__, __LINE__, __func__); + continue; + } + + for (j = 0; j < port_count; j++) { + port_id = sas_iounit_pg0->PhyData[i].Port; + if (port_table[j].port_id == port_id && + port_table[j].sas_address == attached_sas_addr) { + port_table[j].phy_mask |= (1 << i); + found = 1; + break; + } + } + + if (found) + continue; + + port_id = sas_iounit_pg0->PhyData[i].Port; + port_table[port_count].port_id = port_id; + port_table[port_count].phy_mask = (1 << i); + port_table[port_count].sas_address = attached_sas_addr; + port_count++; + } +out: + kfree(sas_iounit_pg0); + return port_count; +} + +enum hba_port_matched_codes { + MATCHED_WITH_ADDR_AND_PHYMASK = 1, + MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT, + MATCHED_WITH_ADDR_AND_SUBPHYMASK, + MATCHED_WITH_ADDR, +}; + +/** + * _scsih_look_and_get_matched_port_entry - Get matched hba port entry + * from HBA port table + * @ioc: per adapter object + * @port_entry - hba port entry from temporary port table which needs to be + * searched for matched entry in the HBA port table + * @matched_port_entry - save matched hba port entry here + * @count - count of matched entries + * + * return type of matched entry found. + */ +static enum hba_port_matched_codes +_scsih_look_and_get_matched_port_entry(struct MPT3SAS_ADAPTER *ioc, + struct hba_port *port_entry, + struct hba_port **matched_port_entry, int *count) +{ + struct hba_port *port_table_entry, *matched_port = NULL; + enum hba_port_matched_codes matched_code; + int lcount = 0; + *matched_port_entry = NULL; + + list_for_each_entry(port_table_entry, &ioc->port_table_list, list) { + if (!(port_table_entry->flags & HBA_PORT_FLAG_DIRTY_PORT)) + continue; + + if ((port_table_entry->sas_address == port_entry->sas_address) + && (port_table_entry->phy_mask == port_entry->phy_mask)) { + matched_code = MATCHED_WITH_ADDR_AND_PHYMASK; + matched_port = port_table_entry; + break; + } + + if ((port_table_entry->sas_address == port_entry->sas_address) + && (port_table_entry->phy_mask & port_entry->phy_mask) + && (port_table_entry->port_id == port_entry->port_id)) { + matched_code = MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT; + matched_port = port_table_entry; + continue; + } + + if ((port_table_entry->sas_address == port_entry->sas_address) + && (port_table_entry->phy_mask & port_entry->phy_mask)) { + if (matched_code == + MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT) + continue; + matched_code = MATCHED_WITH_ADDR_AND_SUBPHYMASK; + matched_port = port_table_entry; + continue; + } + + if (port_table_entry->sas_address == port_entry->sas_address) { + if (matched_code == + MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT) + continue; + if (matched_code == MATCHED_WITH_ADDR_AND_SUBPHYMASK) + continue; + matched_code = MATCHED_WITH_ADDR; + matched_port = port_table_entry; + lcount++; + } + } + + *matched_port_entry = matched_port; + if (matched_code == MATCHED_WITH_ADDR) + *count = lcount; + return matched_code; +} + +/** + * _scsih_del_phy_part_of_anther_port - remove phy if it + * is a part of anther port + *@ioc: per adapter object + *@port_table: port table after reset + *@index: hba port entry index + *@port_count: number of ports available after host reset + *@offset: HBA phy bit offset + * + */ +static void +_scsih_del_phy_part_of_anther_port(struct MPT3SAS_ADAPTER *ioc, + struct hba_port *port_table, + int index, u8 port_count, int offset) +{ + struct _sas_node *sas_node = &ioc->sas_hba; + u32 i, found = 0; + + for (i = 0; i < port_count; i++) { + if (i == index) + continue; + + if (port_table[i].phy_mask & (1 << offset)) { + mpt3sas_transport_del_phy_from_an_existing_port( + ioc, sas_node, &sas_node->phy[offset]); + found = 1; + break; + } + } + if (!found) + port_table[index].phy_mask |= (1 << offset); +} + +/** + * _scsih_add_or_del_phys_from_existing_port - add/remove phy to/from + * right port + *@ioc: per adapter object + *@hba_port_entry: hba port table entry + *@port_table: temporary port table + *@index: hba port entry index + *@port_count: number of ports available after host reset + * + */ +static void +_scsih_add_or_del_phys_from_existing_port(struct MPT3SAS_ADAPTER *ioc, + struct hba_port *hba_port_entry, struct hba_port *port_table, + int index, int port_count) +{ + u32 phy_mask, offset = 0; + struct _sas_node *sas_node = &ioc->sas_hba; + + phy_mask = hba_port_entry->phy_mask ^ port_table[index].phy_mask; + + for (offset = 0; offset < ioc->sas_hba.num_phys; offset++) { + if (phy_mask & (1 << offset)) { + if (!(port_table[index].phy_mask & (1 << offset))) { + _scsih_del_phy_part_of_anther_port( + ioc, port_table, index, port_count, + offset); + continue; + } + if (sas_node->phy[offset].phy_belongs_to_port) + mpt3sas_transport_del_phy_from_an_existing_port( + ioc, sas_node, &sas_node->phy[offset]); + mpt3sas_transport_add_phy_to_an_existing_port( + ioc, sas_node, &sas_node->phy[offset], + hba_port_entry->sas_address, + hba_port_entry); + } + } +} + +/** + * _scsih_del_dirty_port_entries - delete dirty port entries from port list + * after host reset + *@ioc: per adapter object + * + */ +static void +_scsih_del_dirty_port_entries(struct MPT3SAS_ADAPTER *ioc) +{ + struct hba_port *port, *port_next; + + list_for_each_entry_safe(port, port_next, + &ioc->port_table_list, list) { + if (!(port->flags & HBA_PORT_FLAG_DIRTY_PORT) || + port->flags & HBA_PORT_FLAG_NEW_PORT) + continue; + + drsprintk(ioc, ioc_info(ioc, + "Deleting port table entry %p having Port: %d\t Phy_mask 0x%08x\n", + port, port->port_id, port->phy_mask)); + list_del(&port->list); + kfree(port); + } +} + +/** + * _scsih_sas_port_refresh - Update HBA port table after host reset + * @ioc: per adapter object + */ +static void +_scsih_sas_port_refresh(struct MPT3SAS_ADAPTER *ioc) +{ + u32 port_count = 0; + struct hba_port *port_table; + struct hba_port *port_table_entry; + struct hba_port *port_entry = NULL; + int i, j, count = 0, lcount = 0; + int ret; + u64 sas_addr; + + drsprintk(ioc, ioc_info(ioc, + "updating ports for sas_host(0x%016llx)\n", + (unsigned long long)ioc->sas_hba.sas_address)); + + port_table = kcalloc(ioc->sas_hba.num_phys, + sizeof(struct hba_port), GFP_KERNEL); + if (!port_table) + return; + + port_count = _scsih_get_port_table_after_reset(ioc, port_table); + if (!port_count) + return; + + drsprintk(ioc, ioc_info(ioc, "New Port table\n")); + for (j = 0; j < port_count; j++) + drsprintk(ioc, ioc_info(ioc, + "Port: %d\t Phy_mask 0x%08x\t sas_addr(0x%016llx)\n", + port_table[j].port_id, + port_table[j].phy_mask, port_table[j].sas_address)); + + list_for_each_entry(port_table_entry, &ioc->port_table_list, list) + port_table_entry->flags |= HBA_PORT_FLAG_DIRTY_PORT; + + drsprintk(ioc, ioc_info(ioc, "Old Port table\n")); + port_table_entry = NULL; + list_for_each_entry(port_table_entry, &ioc->port_table_list, list) { + drsprintk(ioc, ioc_info(ioc, + "Port: %d\t Phy_mask 0x%08x\t sas_addr(0x%016llx)\n", + port_table_entry->port_id, + port_table_entry->phy_mask, + port_table_entry->sas_address)); + } + + for (j = 0; j < port_count; j++) { + ret = _scsih_look_and_get_matched_port_entry(ioc, + &port_table[j], &port_entry, &count); + if (!port_entry) { + drsprintk(ioc, ioc_info(ioc, + "No Matched entry for sas_addr(0x%16llx), Port:%d\n", + port_table[j].sas_address, + port_table[j].port_id)); + continue; + } + + switch (ret) { + case MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT: + case MATCHED_WITH_ADDR_AND_SUBPHYMASK: + _scsih_add_or_del_phys_from_existing_port(ioc, + port_entry, port_table, j, port_count); + break; + case MATCHED_WITH_ADDR: + sas_addr = port_table[j].sas_address; + for (i = 0; i < port_count; i++) { + if (port_table[i].sas_address == sas_addr) + lcount++; + } + + if (count > 1 || lcount > 1) + port_entry = NULL; + else + _scsih_add_or_del_phys_from_existing_port(ioc, + port_entry, port_table, j, port_count); + } + + if (!port_entry) + continue; + + if (port_entry->port_id != port_table[j].port_id) + port_entry->port_id = port_table[j].port_id; + port_entry->flags &= ~HBA_PORT_FLAG_DIRTY_PORT; + port_entry->phy_mask = port_table[j].phy_mask; + } + + port_table_entry = NULL; +} + /** * _scsih_sas_host_refresh - refreshing sas host object contents * @ioc: per adapter object @@ -9790,6 +10125,7 @@ mpt3sas_scsih_reset_done_handler(struct MPT3SAS_ADAPTER *ioc) dtmprintk(ioc, ioc_info(ioc, "%s: MPT3_IOC_DONE_RESET\n", __func__)); if ((!ioc->is_driver_loading) && !(disable_discovery > 0 && !ioc->sas_hba.num_phys)) { + _scsih_sas_port_refresh(ioc); _scsih_prep_device_scan(ioc); _scsih_create_enclosure_list_after_reset(ioc); _scsih_search_responding_sas_devices(ioc); @@ -9837,6 +10173,7 @@ _mpt3sas_fw_work(struct MPT3SAS_ADAPTER *ioc, struct fw_event_work *fw_event) ssleep(1); } _scsih_remove_unresponding_devices(ioc); + _scsih_del_dirty_port_entries(ioc); _scsih_scan_for_devices_after_reset(ioc); _scsih_set_nvme_max_shutdown_latency(ioc); break; -- 2.18.4 [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4175 bytes --] ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 08/14] mpt3sas: Update hba_port objects after host reset 2020-10-09 17:14 ` [PATCH 08/14] mpt3sas: Update hba_port objects after host reset Sreekanth Reddy 2020-10-12 12:22 ` Dan Carpenter @ 2020-10-12 12:22 ` Dan Carpenter 0 siblings, 0 replies; 5+ messages in thread From: Dan Carpenter @ 2020-10-12 12:22 UTC (permalink / raw) To: kbuild, Sreekanth Reddy, martin.petersen Cc: lkp, kbuild-all, linux-scsi, sathya.prakash, suganath-prabu.subramani, Sreekanth Reddy [-- Attachment #1: Type: text/plain, Size: 6226 bytes --] Hi Sreekanth, url: https://github.com/0day-ci/linux/commits/Sreekanth-Reddy/mpt3sas-Add-support-for-multi-port-path-topology/20201010-011607 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: s390-randconfig-m031-20201009 (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> New smatch warnings: drivers/scsi/mpt3sas/mpt3sas_scsih.c:5940 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'. Old smatch warnings: drivers/scsi/mpt3sas/mpt3sas_scsih.c:5949 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'. drivers/scsi/mpt3sas/mpt3sas_scsih.c:5961 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'. drivers/scsi/mpt3sas/mpt3sas_scsih.c:6472 _scsih_expander_add() warn: returning -1 instead of -ENOMEM is sloppy drivers/scsi/mpt3sas/mpt3sas_scsih.c:10234 _mpt3sas_fw_work() warn: inconsistent indenting vim +/matched_code +5940 drivers/scsi/mpt3sas/mpt3sas_scsih.c 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5909 static enum hba_port_matched_codes 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5910 _scsih_look_and_get_matched_port_entry(struct MPT3SAS_ADAPTER *ioc, 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5911 struct hba_port *port_entry, 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5912 struct hba_port **matched_port_entry, int *count) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5913 { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5914 struct hba_port *port_table_entry, *matched_port = NULL; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5915 enum hba_port_matched_codes matched_code; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5916 int lcount = 0; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5917 *matched_port_entry = NULL; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5918 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5919 list_for_each_entry(port_table_entry, &ioc->port_table_list, list) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5920 if (!(port_table_entry->flags & HBA_PORT_FLAG_DIRTY_PORT)) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5921 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5922 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5923 if ((port_table_entry->sas_address == port_entry->sas_address) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5924 && (port_table_entry->phy_mask == port_entry->phy_mask)) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5925 matched_code = MATCHED_WITH_ADDR_AND_PHYMASK; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5926 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5927 break; This is a break statement. 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5928 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5929 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5930 if ((port_table_entry->sas_address == port_entry->sas_address) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5931 && (port_table_entry->phy_mask & port_entry->phy_mask) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5932 && (port_table_entry->port_id == port_entry->port_id)) { This is only true if "port_table_entry->port_id == port_entry->port_id" 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5933 matched_code = MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5934 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5935 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5936 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5937 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5938 if ((port_table_entry->sas_address == port_entry->sas_address) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5939 && (port_table_entry->phy_mask & port_entry->phy_mask)) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 @5940 if (matched_code == ^^^^^^^^^^^^ Possibly uninitialized. Smatch only complains about the first intance otherwise it would probably complain about after the loop as well. 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5941 MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5942 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5943 matched_code = MATCHED_WITH_ADDR_AND_SUBPHYMASK; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5944 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5945 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5946 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5947 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5948 if (port_table_entry->sas_address == port_entry->sas_address) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5949 if (matched_code == 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5950 MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5951 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5952 if (matched_code == MATCHED_WITH_ADDR_AND_SUBPHYMASK) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5953 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5954 matched_code = MATCHED_WITH_ADDR; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5955 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5956 lcount++; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5957 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5958 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5959 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5960 *matched_port_entry = matched_port; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5961 if (matched_code == MATCHED_WITH_ADDR) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5962 *count = lcount; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5963 return matched_code; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5964 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 29356 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 08/14] mpt3sas: Update hba_port objects after host reset @ 2020-10-12 12:22 ` Dan Carpenter 0 siblings, 0 replies; 5+ messages in thread From: Dan Carpenter @ 2020-10-12 12:22 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 6323 bytes --] Hi Sreekanth, url: https://github.com/0day-ci/linux/commits/Sreekanth-Reddy/mpt3sas-Add-support-for-multi-port-path-topology/20201010-011607 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: s390-randconfig-m031-20201009 (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> New smatch warnings: drivers/scsi/mpt3sas/mpt3sas_scsih.c:5940 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'. Old smatch warnings: drivers/scsi/mpt3sas/mpt3sas_scsih.c:5949 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'. drivers/scsi/mpt3sas/mpt3sas_scsih.c:5961 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'. drivers/scsi/mpt3sas/mpt3sas_scsih.c:6472 _scsih_expander_add() warn: returning -1 instead of -ENOMEM is sloppy drivers/scsi/mpt3sas/mpt3sas_scsih.c:10234 _mpt3sas_fw_work() warn: inconsistent indenting vim +/matched_code +5940 drivers/scsi/mpt3sas/mpt3sas_scsih.c 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5909 static enum hba_port_matched_codes 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5910 _scsih_look_and_get_matched_port_entry(struct MPT3SAS_ADAPTER *ioc, 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5911 struct hba_port *port_entry, 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5912 struct hba_port **matched_port_entry, int *count) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5913 { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5914 struct hba_port *port_table_entry, *matched_port = NULL; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5915 enum hba_port_matched_codes matched_code; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5916 int lcount = 0; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5917 *matched_port_entry = NULL; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5918 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5919 list_for_each_entry(port_table_entry, &ioc->port_table_list, list) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5920 if (!(port_table_entry->flags & HBA_PORT_FLAG_DIRTY_PORT)) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5921 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5922 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5923 if ((port_table_entry->sas_address == port_entry->sas_address) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5924 && (port_table_entry->phy_mask == port_entry->phy_mask)) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5925 matched_code = MATCHED_WITH_ADDR_AND_PHYMASK; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5926 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5927 break; This is a break statement. 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5928 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5929 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5930 if ((port_table_entry->sas_address == port_entry->sas_address) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5931 && (port_table_entry->phy_mask & port_entry->phy_mask) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5932 && (port_table_entry->port_id == port_entry->port_id)) { This is only true if "port_table_entry->port_id == port_entry->port_id" 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5933 matched_code = MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5934 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5935 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5936 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5937 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5938 if ((port_table_entry->sas_address == port_entry->sas_address) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5939 && (port_table_entry->phy_mask & port_entry->phy_mask)) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 @5940 if (matched_code == ^^^^^^^^^^^^ Possibly uninitialized. Smatch only complains about the first intance otherwise it would probably complain about after the loop as well. 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5941 MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5942 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5943 matched_code = MATCHED_WITH_ADDR_AND_SUBPHYMASK; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5944 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5945 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5946 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5947 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5948 if (port_table_entry->sas_address == port_entry->sas_address) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5949 if (matched_code == 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5950 MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5951 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5952 if (matched_code == MATCHED_WITH_ADDR_AND_SUBPHYMASK) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5953 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5954 matched_code = MATCHED_WITH_ADDR; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5955 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5956 lcount++; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5957 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5958 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5959 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5960 *matched_port_entry = matched_port; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5961 if (matched_code == MATCHED_WITH_ADDR) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5962 *count = lcount; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5963 return matched_code; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5964 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 29356 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 08/14] mpt3sas: Update hba_port objects after host reset @ 2020-10-12 12:22 ` Dan Carpenter 0 siblings, 0 replies; 5+ messages in thread From: Dan Carpenter @ 2020-10-12 12:22 UTC (permalink / raw) To: kbuild [-- Attachment #1: Type: text/plain, Size: 6323 bytes --] Hi Sreekanth, url: https://github.com/0day-ci/linux/commits/Sreekanth-Reddy/mpt3sas-Add-support-for-multi-port-path-topology/20201010-011607 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: s390-randconfig-m031-20201009 (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> New smatch warnings: drivers/scsi/mpt3sas/mpt3sas_scsih.c:5940 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'. Old smatch warnings: drivers/scsi/mpt3sas/mpt3sas_scsih.c:5949 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'. drivers/scsi/mpt3sas/mpt3sas_scsih.c:5961 _scsih_look_and_get_matched_port_entry() error: uninitialized symbol 'matched_code'. drivers/scsi/mpt3sas/mpt3sas_scsih.c:6472 _scsih_expander_add() warn: returning -1 instead of -ENOMEM is sloppy drivers/scsi/mpt3sas/mpt3sas_scsih.c:10234 _mpt3sas_fw_work() warn: inconsistent indenting vim +/matched_code +5940 drivers/scsi/mpt3sas/mpt3sas_scsih.c 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5909 static enum hba_port_matched_codes 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5910 _scsih_look_and_get_matched_port_entry(struct MPT3SAS_ADAPTER *ioc, 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5911 struct hba_port *port_entry, 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5912 struct hba_port **matched_port_entry, int *count) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5913 { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5914 struct hba_port *port_table_entry, *matched_port = NULL; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5915 enum hba_port_matched_codes matched_code; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5916 int lcount = 0; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5917 *matched_port_entry = NULL; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5918 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5919 list_for_each_entry(port_table_entry, &ioc->port_table_list, list) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5920 if (!(port_table_entry->flags & HBA_PORT_FLAG_DIRTY_PORT)) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5921 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5922 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5923 if ((port_table_entry->sas_address == port_entry->sas_address) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5924 && (port_table_entry->phy_mask == port_entry->phy_mask)) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5925 matched_code = MATCHED_WITH_ADDR_AND_PHYMASK; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5926 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5927 break; This is a break statement. 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5928 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5929 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5930 if ((port_table_entry->sas_address == port_entry->sas_address) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5931 && (port_table_entry->phy_mask & port_entry->phy_mask) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5932 && (port_table_entry->port_id == port_entry->port_id)) { This is only true if "port_table_entry->port_id == port_entry->port_id" 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5933 matched_code = MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5934 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5935 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5936 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5937 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5938 if ((port_table_entry->sas_address == port_entry->sas_address) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5939 && (port_table_entry->phy_mask & port_entry->phy_mask)) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 @5940 if (matched_code == ^^^^^^^^^^^^ Possibly uninitialized. Smatch only complains about the first intance otherwise it would probably complain about after the loop as well. 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5941 MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5942 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5943 matched_code = MATCHED_WITH_ADDR_AND_SUBPHYMASK; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5944 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5945 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5946 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5947 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5948 if (port_table_entry->sas_address == port_entry->sas_address) { 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5949 if (matched_code == 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5950 MATCHED_WITH_ADDR_SUBPHYMASK_AND_PORT) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5951 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5952 if (matched_code == MATCHED_WITH_ADDR_AND_SUBPHYMASK) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5953 continue; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5954 matched_code = MATCHED_WITH_ADDR; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5955 matched_port = port_table_entry; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5956 lcount++; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5957 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5958 } 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5959 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5960 *matched_port_entry = matched_port; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5961 if (matched_code == MATCHED_WITH_ADDR) 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5962 *count = lcount; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5963 return matched_code; 2756bd46f6fdde Sreekanth Reddy 2020-10-09 5964 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 29356 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-12 12:25 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-10-09 23:49 [PATCH 08/14] mpt3sas: Update hba_port objects after host reset kernel test robot -- strict thread matches above, loose matches on Subject: below -- 2020-10-09 17:14 [PATCH 00/14] mpt3sas: Add support for multi-port path topology Sreekanth Reddy 2020-10-09 17:14 ` [PATCH 08/14] mpt3sas: Update hba_port objects after host reset Sreekanth Reddy 2020-10-12 12:22 ` Dan Carpenter 2020-10-12 12:22 ` Dan Carpenter 2020-10-12 12:22 ` Dan Carpenter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.