[jpirko-mlxsw:jiri_devel_xmrouter 21/40] drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:95 mlxsw_sp_router_ll_xm_fib_entry_pack() error: uninitialized symbol 'xmdr_c_ltr_op'.

[jpirko-mlxsw:jiri_devel_xmrouter 21/40] drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:95 mlxsw_sp_router_ll_xm_fib_entry_pack() error: uninitialized symbol 'xmdr_c_ltr_op'.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5038 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Jiri Pirko <jiri@nvidia.com>

tree:   https://github.com/jpirko/linux_mlxsw jiri_devel_xmrouter
head:   bc715a64f0df05038d9ec9d1ae7e1e97927e08c4
commit: a1edb1380783dd81b2cc3578c67ffb8839a400d1 [21/40] mlxsw: spectrum_router: Introduce XM implementation of router low-level ops
:::::: branch date: 10 hours ago
:::::: commit date: 12 hours ago
config: x86_64-randconfig-m001-20201009 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:95 mlxsw_sp_router_ll_xm_fib_entry_pack() error: uninitialized symbol 'xmdr_c_ltr_op'.

Old smatch warnings:
drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:100 mlxsw_sp_router_ll_xm_fib_entry_pack() error: uninitialized symbol 'xmdr_c_ltr_op'.

vim +/xmdr_c_ltr_op +95 drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c

a1edb1380783dd Jiri Pirko 2020-06-09   63  
a1edb1380783dd Jiri Pirko 2020-06-09   64  static void mlxsw_sp_router_ll_xm_fib_entry_pack(struct mlxsw_sp_fib_entry_op_ctx *op_ctx,
a1edb1380783dd Jiri Pirko 2020-06-09   65  						 enum mlxsw_sp_l3proto proto,
a1edb1380783dd Jiri Pirko 2020-06-09   66  						 enum mlxsw_sp_fib_entry_op op,
a1edb1380783dd Jiri Pirko 2020-06-09   67  						 u16 virtual_router, u8 prefix_len,
a1edb1380783dd Jiri Pirko 2020-06-09   68  						 unsigned char *addr,
a1edb1380783dd Jiri Pirko 2020-06-09   69  						 struct mlxsw_sp_fib_entry_priv *priv)
a1edb1380783dd Jiri Pirko 2020-06-09   70  {
a1edb1380783dd Jiri Pirko 2020-06-09   71  	struct mlxsw_sp_fib_entry_op_ctx_xm *op_ctx_xm = (void *) op_ctx->ll_priv;
a1edb1380783dd Jiri Pirko 2020-06-09   72  	struct mlxsw_sp_router_xm_fib_entry *fib_entry = (void *) priv->priv;
a1edb1380783dd Jiri Pirko 2020-06-09   73  	enum mlxsw_reg_xmdr_c_ltr_op xmdr_c_ltr_op;
a1edb1380783dd Jiri Pirko 2020-06-09   74  	unsigned int len;
a1edb1380783dd Jiri Pirko 2020-06-09   75  
a1edb1380783dd Jiri Pirko 2020-06-09   76  	mlxsw_sp_router_ll_xm_op_ctx_check_init(op_ctx, op_ctx_xm);
a1edb1380783dd Jiri Pirko 2020-06-09   77  
a1edb1380783dd Jiri Pirko 2020-06-09   78  	switch (op) {
a1edb1380783dd Jiri Pirko 2020-06-09   79  	case MLXSW_SP_FIB_ENTRY_OP_WRITE:
a1edb1380783dd Jiri Pirko 2020-06-09   80  		xmdr_c_ltr_op = MLXSW_REG_XMDR_C_LTR_OP_WRITE;
a1edb1380783dd Jiri Pirko 2020-06-09   81  		break;
a1edb1380783dd Jiri Pirko 2020-06-09   82  	case MLXSW_SP_FIB_ENTRY_OP_UPDATE:
a1edb1380783dd Jiri Pirko 2020-06-09   83  		xmdr_c_ltr_op = MLXSW_REG_XMDR_C_LTR_OP_UPDATE;
a1edb1380783dd Jiri Pirko 2020-06-09   84  		break;
a1edb1380783dd Jiri Pirko 2020-06-09   85  	case MLXSW_SP_FIB_ENTRY_OP_DELETE:
a1edb1380783dd Jiri Pirko 2020-06-09   86  		xmdr_c_ltr_op = MLXSW_REG_XMDR_C_LTR_OP_DELETE;
a1edb1380783dd Jiri Pirko 2020-06-09   87  		break;
a1edb1380783dd Jiri Pirko 2020-06-09   88  	default:
a1edb1380783dd Jiri Pirko 2020-06-09   89  		WARN_ON(1);
a1edb1380783dd Jiri Pirko 2020-06-09   90  	}
a1edb1380783dd Jiri Pirko 2020-06-09   91  
a1edb1380783dd Jiri Pirko 2020-06-09   92  	switch (proto) {
a1edb1380783dd Jiri Pirko 2020-06-09   93  	case MLXSW_SP_L3_PROTO_IPV4:
a1edb1380783dd Jiri Pirko 2020-06-09   94  		len = mlxsw_reg_xmdr_c_ltr_pack4(op_ctx_xm->xmdr_pl, op_ctx_xm->trans_offset,
a1edb1380783dd Jiri Pirko 2020-06-09  @95  						 op_ctx_xm->entries_count, xmdr_c_ltr_op,
a1edb1380783dd Jiri Pirko 2020-06-09   96  						 virtual_router, prefix_len, (u32 *) addr);
a1edb1380783dd Jiri Pirko 2020-06-09   97  		break;
a1edb1380783dd Jiri Pirko 2020-06-09   98  	case MLXSW_SP_L3_PROTO_IPV6:
a1edb1380783dd Jiri Pirko 2020-06-09   99  		len = mlxsw_reg_xmdr_c_ltr_pack6(op_ctx_xm->xmdr_pl, op_ctx_xm->trans_offset,
a1edb1380783dd Jiri Pirko 2020-06-09  100  						 op_ctx_xm->entries_count, xmdr_c_ltr_op,
a1edb1380783dd Jiri Pirko 2020-06-09  101  						 virtual_router, prefix_len, addr);
a1edb1380783dd Jiri Pirko 2020-06-09  102  		break;
a1edb1380783dd Jiri Pirko 2020-06-09  103  	default:
a1edb1380783dd Jiri Pirko 2020-06-09  104  		WARN_ON(true);
a1edb1380783dd Jiri Pirko 2020-06-09  105  		return;
a1edb1380783dd Jiri Pirko 2020-06-09  106  	}
a1edb1380783dd Jiri Pirko 2020-06-09  107  	if (!op_ctx_xm->trans_offset)
a1edb1380783dd Jiri Pirko 2020-06-09  108  		op_ctx_xm->trans_item_len = len;
a1edb1380783dd Jiri Pirko 2020-06-09  109  	else
a1edb1380783dd Jiri Pirko 2020-06-09  110  		WARN_ON(op_ctx_xm->trans_item_len != len);
a1edb1380783dd Jiri Pirko 2020-06-09  111  
a1edb1380783dd Jiri Pirko 2020-06-09  112  	op_ctx_xm->entries[op_ctx_xm->entries_count] = fib_entry;
a1edb1380783dd Jiri Pirko 2020-06-09  113  }
a1edb1380783dd Jiri Pirko 2020-06-09  114  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41038 bytes --]