* [PATCH] nfsd: remove unneeded break
@ 2020-10-11 15:51 trix
2020-10-12 14:19 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-10-11 15:51 UTC (permalink / raw)
To: bfields, chuck.lever; +Cc: linux-nfs, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
Because every path through nfs4_find_file()'s
switch does an explicit return, the break is not needed.
Signed-off-by: Tom Rix <trix@redhat.com>
---
fs/nfsd/nfs4state.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index c09a2a4281ec..741f64672d96 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -5722,7 +5722,6 @@ nfs4_find_file(struct nfs4_stid *s, int flags)
return find_readable_file(s->sc_file);
else
return find_writeable_file(s->sc_file);
- break;
}
return NULL;
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfsd: remove unneeded break
2020-10-11 15:51 [PATCH] nfsd: remove unneeded break trix
@ 2020-10-12 14:19 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2020-10-12 14:19 UTC (permalink / raw)
To: trix; +Cc: chuck.lever, linux-nfs, linux-kernel
On Sun, Oct 11, 2020 at 08:51:55AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Because every path through nfs4_find_file()'s
> switch does an explicit return, the break is not needed.
OK, applying.--b.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> fs/nfsd/nfs4state.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index c09a2a4281ec..741f64672d96 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -5722,7 +5722,6 @@ nfs4_find_file(struct nfs4_stid *s, int flags)
> return find_readable_file(s->sc_file);
> else
> return find_writeable_file(s->sc_file);
> - break;
> }
>
> return NULL;
> --
> 2.18.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-12 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-11 15:51 [PATCH] nfsd: remove unneeded break trix
2020-10-12 14:19 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.