[linux-next:master 11142/14669] drivers/net/wireless/realtek/rtw88/fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' will always evaluate to 'true'

* [linux-next:master 11142/14669] drivers/net/wireless/realtek/rtw88/fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' will always evaluate to 'true'
@ 2020-10-12 11:08 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-10-12 11:08 UTC (permalink / raw)
  To: Tzu-En Huang
  Cc: kbuild-all, clang-built-linux, Linux Memory Management List, Kalle Valo

[-- Attachment #1: Type: text/plain, Size: 2548 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   d67bc7812221606e1886620a357b13f906814af7
commit: 0fbc2f0f34cc57e8d6076631733e0095ac031995 [11142/14669] rtw88: add dump firmware fifo support
config: powerpc-randconfig-r033-20201012 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9e72d3eaf38f217698f72cb8fdc969a6e72dad3a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0fbc2f0f34cc57e8d6076631733e0095ac031995
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 0fbc2f0f34cc57e8d6076631733e0095ac031995
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/realtek/rtw88/fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' will always evaluate to 'true' [-Wpointer-bool-conversion]
           if (!rtwdev->chip->fw_fifo_addr) {
               ~~~~~~~~~~~~~~~^~~~~~~~~~~~
   1 warning generated.

vim +1485 drivers/net/wireless/realtek/rtw88/fw.c

  1481	
  1482	int rtw_fw_dump_fifo(struct rtw_dev *rtwdev, u8 fifo_sel, u32 addr, u32 size,
  1483			     u32 *buffer)
  1484	{
> 1485		if (!rtwdev->chip->fw_fifo_addr) {
  1486			rtw_dbg(rtwdev, RTW_DBG_FW, "chip not support dump fw fifo\n");
  1487			return -ENOTSUPP;
  1488		}
  1489	
  1490		if (size == 0 || !buffer)
  1491			return -EINVAL;
  1492	
  1493		if (size & 0x3) {
  1494			rtw_dbg(rtwdev, RTW_DBG_FW, "not 4byte alignment\n");
  1495			return -EINVAL;
  1496		}
  1497	
  1498		if (!rtw_fw_dump_check_size(rtwdev, fifo_sel, addr, size)) {
  1499			rtw_dbg(rtwdev, RTW_DBG_FW, "fw fifo dump size overflow\n");
  1500			return -EINVAL;
  1501		}
  1502	
  1503		rtw_fw_read_fifo(rtwdev, fifo_sel, addr, size, buffer);
  1504	
  1505		return 0;
  1506	}
  1507	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42374 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread