[PATCH v3 1/2] staging: media: imx: remove commented code

[PATCH v3 1/2] staging: media: imx: remove commented code

[Deepak R Varma]

Commented code in the "#if 0" block does not appear to be useful anymore
since the virtual channel is always treated as 0 once the stream enters
CSI's.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

---

Changes since v2:
   - None
Changes since v1:
   - Implement feedback from Julia to be exact with the patch description

 drivers/staging/media/imx/imx-media-csi.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 21ebf7769696..9320e3974d86 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -1131,13 +1131,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
 		 * enters the CSI's however, they are treated internally
 		 * in the IPU as virtual channel 0.
 		 */
-#if 0
-		mutex_unlock(&priv->lock);
-		vc_num = imx_media_find_mipi_csi2_channel(&priv->sd.entity);
-		if (vc_num < 0)
-			return vc_num;
-		mutex_lock(&priv->lock);
-#endif
 		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
 					  &priv->format_mbus[CSI_SINK_PAD]);
 	}
-- 
2.25.1

[PATCH v3 2/2] staging: media: imx: remove unnecessary variable use

[Deepak R Varma]

Use of variable vc_num is unnecessary here as it is used only once.
Instead, the value can directly be used in place of the variable. 

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

---

Changes since v2:
   - Implement feedback from Vaishali to simply the patch log message.

Changes since v1:
   - None.

 drivers/staging/media/imx/imx-media-csi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 9320e3974d86..db77fef07654 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -1123,7 +1123,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
 	priv->upstream_ep = upstream_ep;
 	is_csi2 = !is_parallel_bus(&upstream_ep);
 	if (is_csi2) {
-		int vc_num = 0;
 		/*
 		 * NOTE! It seems the virtual channels from the mipi csi-2
 		 * receiver are used only for routing by the video mux's,
@@ -1131,7 +1130,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
 		 * enters the CSI's however, they are treated internally
 		 * in the IPU as virtual channel 0.
 		 */
-		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
+		ipu_csi_set_mipi_datatype(priv->csi, 0,
 					  &priv->format_mbus[CSI_SINK_PAD]);
 	}
 
-- 
2.25.1

Re: [Outreachy kernel] [PATCH v3 2/2] staging: media: imx: remove unnecessary variable use

[Helen Koike]

Hello,

On 10/13/20 12:04 PM, Deepak R Varma wrote:
> Use of variable vc_num is unnecessary here as it is used only once.
> Instead, the value can directly be used in place of the variable. 
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

As mentioned by Vaishali in the previous version, if you found this
through checkpatch.pl, please, mention it here.

You can even copy the warning you are fixing:

Example: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e4d7efbb91efc3040e3f1c645571c1769095ae79

This is nice, because you are giving credit to the tool, and also let
others know how you found it, and maybe other people can check too.
Please let us know if you have any doubts :)

Regards,
Helen

> 
> ---
> 
> Changes since v2:
>    - Implement feedback from Vaishali to simply the patch log message.
> 
> Changes since v1:
>    - None.
> 
>  drivers/staging/media/imx/imx-media-csi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 9320e3974d86..db77fef07654 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1123,7 +1123,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>  	priv->upstream_ep = upstream_ep;
>  	is_csi2 = !is_parallel_bus(&upstream_ep);
>  	if (is_csi2) {
> -		int vc_num = 0;
>  		/*
>  		 * NOTE! It seems the virtual channels from the mipi csi-2
>  		 * receiver are used only for routing by the video mux's,
> @@ -1131,7 +1130,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>  		 * enters the CSI's however, they are treated internally
>  		 * in the IPU as virtual channel 0.
>  		 */
> -		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
> +		ipu_csi_set_mipi_datatype(priv->csi, 0,
>  					  &priv->format_mbus[CSI_SINK_PAD]);
>  	}
>  
> 

Re: [Outreachy kernel] [PATCH v3 2/2] staging: media: imx: remove unnecessary variable use

[Deepak R Varma]

On Tue, Oct 13, 2020 at 12:48:10PM -0300, Helen Koike wrote:
> Hello,
> 
> On 10/13/20 12:04 PM, Deepak R Varma wrote:
> > Use of variable vc_num is unnecessary here as it is used only once.
> > Instead, the value can directly be used in place of the variable. 
> > 
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> 
> As mentioned by Vaishali in the previous version, if you found this
> through checkpatch.pl, please, mention it here.
> 
> You can even copy the warning you are fixing:
> 
> Example: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e4d7efbb91efc3040e3f1c645571c1769095ae79
> 
> This is nice, because you are giving credit to the tool, and also let
> others know how you found it, and maybe other people can check too.
> Please let us know if you have any doubts :)
> 
> Regards,
> Helen
> 

Hello,
This was not flagged by checkpatch, this is my observation. However 
patch 1/2 was outcome of checkpatch warning. I will update and 
resend the patch set.

Thank you.
Deepak.

> > 
> > ---
> > 
> > Changes since v2:
> >    - Implement feedback from Vaishali to simply the patch log message.
> > 
> > Changes since v1:
> >    - None.
> > 
> >  drivers/staging/media/imx/imx-media-csi.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> > index 9320e3974d86..db77fef07654 100644
> > --- a/drivers/staging/media/imx/imx-media-csi.c
> > +++ b/drivers/staging/media/imx/imx-media-csi.c
> > @@ -1123,7 +1123,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
> >  	priv->upstream_ep = upstream_ep;
> >  	is_csi2 = !is_parallel_bus(&upstream_ep);
> >  	if (is_csi2) {
> > -		int vc_num = 0;
> >  		/*
> >  		 * NOTE! It seems the virtual channels from the mipi csi-2
> >  		 * receiver are used only for routing by the video mux's,
> > @@ -1131,7 +1130,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
> >  		 * enters the CSI's however, they are treated internally
> >  		 * in the IPU as virtual channel 0.
> >  		 */
> > -		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
> > +		ipu_csi_set_mipi_datatype(priv->csi, 0,
> >  					  &priv->format_mbus[CSI_SINK_PAD]);
> >  	}
> >  
> >