* [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming
@ 2020-10-13 21:49 Khem Raj
2020-10-13 21:51 ` [meta-ti] " Denys Dmytriyenko
2020-10-14 15:35 ` Dan Murphy
0 siblings, 2 replies; 7+ messages in thread
From: Khem Raj @ 2020-10-13 21:49 UTC (permalink / raw)
To: meta-ti; +Cc: Khem Raj
latest OE-core does not promote using trailing slash to make pseudo's
life easier
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
v2: Strip slash from S if it exists
classes/ti-pdk-fetch.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/classes/ti-pdk-fetch.bbclass b/classes/ti-pdk-fetch.bbclass
index 0c9879be..cacd71a4 100644
--- a/classes/ti-pdk-fetch.bbclass
+++ b/classes/ti-pdk-fetch.bbclass
@@ -15,7 +15,7 @@ TI_PDK_SOURCE_PN = "ti-pdk-source"
TI_PDK_SOURCE_WORKDIR = "${TMPDIR}/work-shared/ti-pdk-${PV}"
TI_PDK_SOURCE = "${TI_PDK_SOURCE_WORKDIR}/git"
-S = "${WORKDIR}/git/${TI_PDK_COMP_PATH}"
+S = "${@'${WORKDIR}/git/${TI_PDK_COMP_PATH}'.rstrip('/')}"
# Hard-link only required sources from PDK
python do_unpack_append() {
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming
2020-10-13 21:49 [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming Khem Raj
@ 2020-10-13 21:51 ` Denys Dmytriyenko
2020-10-14 15:35 ` Dan Murphy
1 sibling, 0 replies; 7+ messages in thread
From: Denys Dmytriyenko @ 2020-10-13 21:51 UTC (permalink / raw)
To: Khem Raj; +Cc: meta-ti
On Tue, Oct 13, 2020 at 02:49:11PM -0700, Khem Raj wrote:
> latest OE-core does not promote using trailing slash to make pseudo's
> life easier
This should be fine.
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Reviewed-by: Denys Dmytriyenko <denys@ti.com>
> ---
> v2: Strip slash from S if it exists
>
> classes/ti-pdk-fetch.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/classes/ti-pdk-fetch.bbclass b/classes/ti-pdk-fetch.bbclass
> index 0c9879be..cacd71a4 100644
> --- a/classes/ti-pdk-fetch.bbclass
> +++ b/classes/ti-pdk-fetch.bbclass
> @@ -15,7 +15,7 @@ TI_PDK_SOURCE_PN = "ti-pdk-source"
> TI_PDK_SOURCE_WORKDIR = "${TMPDIR}/work-shared/ti-pdk-${PV}"
> TI_PDK_SOURCE = "${TI_PDK_SOURCE_WORKDIR}/git"
>
> -S = "${WORKDIR}/git/${TI_PDK_COMP_PATH}"
> +S = "${@'${WORKDIR}/git/${TI_PDK_COMP_PATH}'.rstrip('/')}"
>
> # Hard-link only required sources from PDK
> python do_unpack_append() {
> --
> 2.28.0
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming
2020-10-13 21:49 [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming Khem Raj
2020-10-13 21:51 ` [meta-ti] " Denys Dmytriyenko
@ 2020-10-14 15:35 ` Dan Murphy
2020-10-14 15:37 ` Denys Dmytriyenko
2020-10-14 15:51 ` Khem Raj
1 sibling, 2 replies; 7+ messages in thread
From: Dan Murphy @ 2020-10-14 15:35 UTC (permalink / raw)
To: Khem Raj, meta-ti
Khem
On 10/13/20 4:49 PM, Khem Raj wrote:
> latest OE-core does not promote using trailing slash to make pseudo's
> life easier
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> v2: Strip slash from S if it exists
There were 2 patches submitted with v1. Do we just drop the RTOS patch now?
Dan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming
2020-10-14 15:35 ` Dan Murphy
@ 2020-10-14 15:37 ` Denys Dmytriyenko
2020-10-14 15:39 ` Dan Murphy
2020-10-14 15:51 ` Khem Raj
1 sibling, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2020-10-14 15:37 UTC (permalink / raw)
To: dmurphy; +Cc: Khem Raj, meta-ti
On Wed, Oct 14, 2020 at 10:35:13AM -0500, Dan Murphy via lists.yoctoproject.org wrote:
> Khem
>
> On 10/13/20 4:49 PM, Khem Raj wrote:
> >latest OE-core does not promote using trailing slash to make pseudo's
> >life easier
> >
> >Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >---
> >v2: Strip slash from S if it exists
>
> There were 2 patches submitted with v1. Do we just drop the RTOS patch now?
Dan,
I believe it is also needed.
Denys
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming
2020-10-14 15:37 ` Denys Dmytriyenko
@ 2020-10-14 15:39 ` Dan Murphy
0 siblings, 0 replies; 7+ messages in thread
From: Dan Murphy @ 2020-10-14 15:39 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: Khem Raj, meta-ti
Denys
On 10/14/20 10:37 AM, Denys Dmytriyenko wrote:
> On Wed, Oct 14, 2020 at 10:35:13AM -0500, Dan Murphy via lists.yoctoproject.org wrote:
>> Khem
>>
>> On 10/13/20 4:49 PM, Khem Raj wrote:
>>> latest OE-core does not promote using trailing slash to make pseudo's
>>> life easier
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> v2: Strip slash from S if it exists
>> There were 2 patches submitted with v1. Do we just drop the RTOS patch now?
> Dan,
>
> I believe it is also needed.
Yes I believe it is needed as well just need Khem to confirm or resubmit
the series
Dan
> Denys
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming
2020-10-14 15:35 ` Dan Murphy
2020-10-14 15:37 ` Denys Dmytriyenko
@ 2020-10-14 15:51 ` Khem Raj
2020-10-14 15:54 ` Dan Murphy
1 sibling, 1 reply; 7+ messages in thread
From: Khem Raj @ 2020-10-14 15:51 UTC (permalink / raw)
To: Dan Murphy; +Cc: meta-ti
On Wed, Oct 14, 2020 at 8:35 AM Dan Murphy <dmurphy@ti.com> wrote:
>
> Khem
>
> On 10/13/20 4:49 PM, Khem Raj wrote:
> > latest OE-core does not promote using trailing slash to make pseudo's
> > life easier
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > v2: Strip slash from S if it exists
>
> There were 2 patches submitted with v1. Do we just drop the RTOS patch now?
>
right you need v1 of one patch and v2 of the other. I usually update
the series with the resent patches. If you want whole series to be
resent I can do that.
> Dan
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming
2020-10-14 15:51 ` Khem Raj
@ 2020-10-14 15:54 ` Dan Murphy
0 siblings, 0 replies; 7+ messages in thread
From: Dan Murphy @ 2020-10-14 15:54 UTC (permalink / raw)
To: Khem Raj; +Cc: meta-ti
Khem
On 10/14/20 10:51 AM, Khem Raj wrote:
> On Wed, Oct 14, 2020 at 8:35 AM Dan Murphy <dmurphy@ti.com> wrote:
>> Khem
>>
>> On 10/13/20 4:49 PM, Khem Raj wrote:
>>> latest OE-core does not promote using trailing slash to make pseudo's
>>> life easier
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> v2: Strip slash from S if it exists
>> There were 2 patches submitted with v1. Do we just drop the RTOS patch now?
>>
> right you need v1 of one patch and v2 of the other. I usually update
> the series with the resent patches. If you want whole series to be
> resent I can do that.
OK. I will apply them. Generally when you promote a patch version in a
series the full series should be promoted and re-sent.
Otherwise patches might be missed.
Dan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-14 15:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-13 21:49 [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming Khem Raj
2020-10-13 21:51 ` [meta-ti] " Denys Dmytriyenko
2020-10-14 15:35 ` Dan Murphy
2020-10-14 15:37 ` Denys Dmytriyenko
2020-10-14 15:39 ` Dan Murphy
2020-10-14 15:51 ` Khem Raj
2020-10-14 15:54 ` Dan Murphy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.