From: Dwaipayan Ray <dwaipayanray1@gmail.com> To: joe@perches.com Cc: linux-kernel-mentees@lists.linuxfoundation.org, dwaipayanray1@gmail.com, linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com Subject: [PATCH] checkpatch: add new exception to repeated word check Date: Wed, 14 Oct 2020 19:26:37 +0530 [thread overview] Message-ID: <20201014135637.92319-1-dwaipayanray1@gmail.com> (raw) Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") moved the repeated word test to check for more file types. But after this, if checkpatch.pl is run on MAINTAINERS, it generates several new warnings of the type: WARNING: Possible repeated word: 'git' For example: WARNING: Possible repeated word: 'git' +T: git git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git So, the pattern "git git://..." is a false positive in this case. Add 'git' to the exception list for repeated word check. This effectively fixes all the newly generated false positives. Fixes: 4f6ad8aa1eac ("checkpatch: move repeated word test") Link: https://lore.kernel.org/linux-kernel-mentees/b6cd81b936671a8868fe98536d7c80771bdfd61c.camel@perches.com/ Suggested-by: Joe Perches <joe@perches.com> Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f1a4e61917eb..b55d83360366 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3063,7 +3063,7 @@ sub process { } next if ($first ne $second); - next if ($first eq 'long'); + next if ($first =~ /(?:long|git)$/); if (WARN("REPEATED_WORD", "Possible repeated word: '$first'\n" . $herecurr) && -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Dwaipayan Ray <dwaipayanray1@gmail.com> To: joe@perches.com Cc: dwaipayanray1@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: [Linux-kernel-mentees] [PATCH] checkpatch: add new exception to repeated word check Date: Wed, 14 Oct 2020 19:26:37 +0530 [thread overview] Message-ID: <20201014135637.92319-1-dwaipayanray1@gmail.com> (raw) Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") moved the repeated word test to check for more file types. But after this, if checkpatch.pl is run on MAINTAINERS, it generates several new warnings of the type: WARNING: Possible repeated word: 'git' For example: WARNING: Possible repeated word: 'git' +T: git git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git So, the pattern "git git://..." is a false positive in this case. Add 'git' to the exception list for repeated word check. This effectively fixes all the newly generated false positives. Fixes: 4f6ad8aa1eac ("checkpatch: move repeated word test") Link: https://lore.kernel.org/linux-kernel-mentees/b6cd81b936671a8868fe98536d7c80771bdfd61c.camel@perches.com/ Suggested-by: Joe Perches <joe@perches.com> Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f1a4e61917eb..b55d83360366 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3063,7 +3063,7 @@ sub process { } next if ($first ne $second); - next if ($first eq 'long'); + next if ($first =~ /(?:long|git)$/); if (WARN("REPEATED_WORD", "Possible repeated word: '$first'\n" . $herecurr) && -- 2.27.0 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next reply other threads:[~2020-10-14 13:57 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-14 13:56 Dwaipayan Ray [this message] 2020-10-14 13:56 ` [Linux-kernel-mentees] [PATCH] checkpatch: add new exception to repeated word check Dwaipayan Ray 2020-10-14 16:17 ` Joe Perches 2020-10-14 16:17 ` [Linux-kernel-mentees] " Joe Perches 2020-10-14 16:33 ` Dwaipayan Ray 2020-10-14 16:33 ` [Linux-kernel-mentees] " Dwaipayan Ray
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201014135637.92319-1-dwaipayanray1@gmail.com \ --to=dwaipayanray1@gmail.com \ --cc=joe@perches.com \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lukas.bulwahn@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.