All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] staging: vt6655: rearrange lines exceeding 100 columns
@ 2020-10-14 17:38 Deepak R Varma
  2020-10-16  8:32 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Deepak R Varma @ 2020-10-14 17:38 UTC (permalink / raw)
  To: outreachy-kernel, Forest Bond, Greg Kroah-Hartman

Rearrange lines that are longer than 100 columns width. Issue reported
by chckpatch script.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

---
Changes since v1:
   - Removed unnecessary {} for the single line statement post if
     condition.
   - Suggested by Julia.

 drivers/staging/vt6655/device_main.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 09ab6d6f2429..9c7d70ebb405 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -461,7 +461,10 @@ static bool device_init_rings(struct vnt_private *priv)
 		priv->opts.rx_descs0 * sizeof(struct vnt_rx_desc);
 
 	priv->tx0_bufs = dma_alloc_coherent(&priv->pcid->dev,
-					    priv->opts.tx_descs[0] * PKT_BUF_SZ + priv->opts.tx_descs[1] * PKT_BUF_SZ + CB_BEACON_BUF_SIZE + CB_MAX_BUF_SIZE,
+					    priv->opts.tx_descs[0] * PKT_BUF_SZ +
+					    priv->opts.tx_descs[1] * PKT_BUF_SZ +
+					    CB_BEACON_BUF_SIZE +
+					    CB_MAX_BUF_SIZE,
 					    &priv->tx_bufs_dma0, GFP_ATOMIC);
 	if (!priv->tx0_bufs) {
 		dev_err(&priv->pcid->dev, "allocate buf dma memory failed\n");
@@ -1075,10 +1078,10 @@ static void vnt_interrupt_process(struct vnt_private *priv)
 
 			if ((priv->op_mode == NL80211_IFTYPE_AP ||
 			    priv->op_mode == NL80211_IFTYPE_ADHOC) &&
-			    priv->vif->bss_conf.enable_beacon) {
+			    priv->vif->bss_conf.enable_beacon)
 				MACvOneShotTimer1MicroSec(priv,
-							  (priv->vif->bss_conf.beacon_int - MAKE_BEACON_RESERVED) << 10);
-			}
+							  (priv->vif->bss_conf.beacon_int -
+							   MAKE_BEACON_RESERVED) << 10);
 
 			/* TODO: adhoc PS mode */
 		}
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] staging: vt6655: rearrange lines exceeding 100 columns
  2020-10-14 17:38 [PATCH v2] staging: vt6655: rearrange lines exceeding 100 columns Deepak R Varma
@ 2020-10-16  8:32 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2020-10-16  8:32 UTC (permalink / raw)
  To: Deepak R Varma; +Cc: outreachy-kernel, Forest Bond

On Wed, Oct 14, 2020 at 11:08:05PM +0530, Deepak R Varma wrote:
> Rearrange lines that are longer than 100 columns width. Issue reported
> by chckpatch script.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> 
> ---
> Changes since v1:
>    - Removed unnecessary {} for the single line statement post if
>      condition.

You need to mention this in the changelog text as well.  Please fix that
up and resend.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-16  8:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 17:38 [PATCH v2] staging: vt6655: rearrange lines exceeding 100 columns Deepak R Varma
2020-10-16  8:32 ` Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.