All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Cc: kbuild-all@lists.01.org, davem@davemloft.net,
	netdev@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net-next 3/9] net: 8021q: resolve forwarding path for vlan devices
Date: Thu, 15 Oct 2020 15:48:02 +0800	[thread overview]
Message-ID: <202010151556.KaO8lHFC-lkp@intel.com> (raw)
In-Reply-To: <20201015011630.2399-4-pablo@netfilter.org>

[-- Attachment #1: Type: text/plain, Size: 2322 bytes --]

Hi Pablo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-flowtable-bridge-and-vlan-enhancements/20201015-091818
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 50172733d01c3097b23ac8d45bf1fff72af0ba98
config: riscv-randconfig-s031-20201015 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-rc1-dirty
        # https://github.com/0day-ci/linux/commit/fbe6da32dfe77e080e449951ba7a5d3308938304
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pablo-Neira-Ayuso/netfilter-flowtable-bridge-and-vlan-enhancements/20201015-091818
        git checkout fbe6da32dfe77e080e449951ba7a5d3308938304
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> net/8021q/vlan_dev.c:776:23: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __be16 [usertype] id @@     got unsigned short [usertype] vlan_id @@
>> net/8021q/vlan_dev.c:776:23: sparse:     expected restricted __be16 [usertype] id
>> net/8021q/vlan_dev.c:776:23: sparse:     got unsigned short [usertype] vlan_id

vim +776 net/8021q/vlan_dev.c

   769	
   770	static int vlan_dev_fill_forward_path(struct net_device_path_ctx *ctx,
   771					      struct net_device_path *path)
   772	{
   773		struct vlan_dev_priv *vlan = vlan_dev_priv(ctx->dev);
   774	
   775		path->type = DEV_PATH_VLAN;
 > 776		path->vlan.id = vlan->vlan_id;
   777		path->vlan.proto = vlan->vlan_proto;
   778		path->dev = ctx->dev;
   779		ctx->dev = vlan->real_dev;
   780	
   781		return 0;
   782	}
   783	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31027 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next 3/9] net: 8021q: resolve forwarding path for vlan devices
Date: Thu, 15 Oct 2020 15:48:02 +0800	[thread overview]
Message-ID: <202010151556.KaO8lHFC-lkp@intel.com> (raw)
In-Reply-To: <20201015011630.2399-4-pablo@netfilter.org>

[-- Attachment #1: Type: text/plain, Size: 2376 bytes --]

Hi Pablo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-flowtable-bridge-and-vlan-enhancements/20201015-091818
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 50172733d01c3097b23ac8d45bf1fff72af0ba98
config: riscv-randconfig-s031-20201015 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-rc1-dirty
        # https://github.com/0day-ci/linux/commit/fbe6da32dfe77e080e449951ba7a5d3308938304
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pablo-Neira-Ayuso/netfilter-flowtable-bridge-and-vlan-enhancements/20201015-091818
        git checkout fbe6da32dfe77e080e449951ba7a5d3308938304
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> net/8021q/vlan_dev.c:776:23: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __be16 [usertype] id @@     got unsigned short [usertype] vlan_id @@
>> net/8021q/vlan_dev.c:776:23: sparse:     expected restricted __be16 [usertype] id
>> net/8021q/vlan_dev.c:776:23: sparse:     got unsigned short [usertype] vlan_id

vim +776 net/8021q/vlan_dev.c

   769	
   770	static int vlan_dev_fill_forward_path(struct net_device_path_ctx *ctx,
   771					      struct net_device_path *path)
   772	{
   773		struct vlan_dev_priv *vlan = vlan_dev_priv(ctx->dev);
   774	
   775		path->type = DEV_PATH_VLAN;
 > 776		path->vlan.id = vlan->vlan_id;
   777		path->vlan.proto = vlan->vlan_proto;
   778		path->dev = ctx->dev;
   779		ctx->dev = vlan->real_dev;
   780	
   781		return 0;
   782	}
   783	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31027 bytes --]

  reply	other threads:[~2020-10-15  7:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15  1:16 [PATCH net-next 0/9] netfilter: flowtable bridge and vlan enhancements Pablo Neira Ayuso
2020-10-15  1:16 ` [PATCH net-next 1/9] netfilter: flowtable: add xmit path types Pablo Neira Ayuso
2020-10-15  1:16 ` [PATCH net-next 2/9] net: resolve forwarding path from virtual netdevice and HW destination address Pablo Neira Ayuso
2020-10-15  1:16 ` [PATCH net-next 3/9] net: 8021q: resolve forwarding path for vlan devices Pablo Neira Ayuso
2020-10-15  7:48   ` kernel test robot [this message]
2020-10-15  7:48     ` kernel test robot
2020-10-15  1:16 ` [PATCH net-next 4/9] bridge: resolve forwarding path for bridge devices Pablo Neira Ayuso
2020-10-15  1:16 ` [PATCH net-next 5/9] netfilter: flowtable: use dev_fill_forward_path() to obtain ingress device Pablo Neira Ayuso
2020-10-15  1:16 ` [PATCH net-next 6/9] netfilter: flowtable: use dev_fill_forward_path() to obtain egress device Pablo Neira Ayuso
2020-10-15  1:16 ` [PATCH net-next 7/9] netfilter: flowtable: add direct xmit path Pablo Neira Ayuso
2020-10-15  1:16 ` [PATCH net-next 8/9] netfilter: flowtable: bridge port support Pablo Neira Ayuso
2020-10-15  1:16 ` [PATCH net-next 9/9] netfilter: flowtable: add vlan support Pablo Neira Ayuso
2020-10-15 15:10   ` Jakub Kicinski
2020-10-15 15:28     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202010151556.KaO8lHFC-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=davem@davemloft.net \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.