* [Buildroot] [PATCH v2] package/dvb-apps: fix build failure with glibc 2.31
@ 2020-09-26 17:09 Dagg Stompler
2020-10-15 21:12 ` Thomas Petazzoni
2020-10-28 17:08 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Dagg Stompler @ 2020-09-26 17:09 UTC (permalink / raw)
To: buildroot
dvb-apps fails to build with glibc 2.31 with the following error:
| dvbdate.c: In function set_time:
| dvbdate.c:312:6: warning: implicit declaration of function stime; did you mean ctime? [-Wimplicit-function-declaration]
| 312 | if (stime(new_time)) {
| | ^~~~~
| | ctime
Fixes:
http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
references:
1. https://gitweb.gentoo.org/repo/gentoo.git/commit/media-tv/linuxtv-dvb-apps/files/linuxtv-dvb-apps-glibc-2.31.patch?id=eb705f892eae45b93306c1de1407c1c22ac23956
2. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964223
Signed-off-by: Dagg Stompler <daggs@gmx.com>
---
Changes v1 -> v2:
1. fix coomit header (Thomas Petazzoni)
2. add reference to autobuilder failure (Thomas Petazzoni)
3. rework patch (Thomas Petazzoni)
4. added maintainer to CC
package/dvb-apps/0006-fix-glibc-2.31.patch | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 package/dvb-apps/0006-fix-glibc-2.31.patch
diff --git a/package/dvb-apps/0006-fix-glibc-2.31.patch b/package/dvb-apps/0006-fix-glibc-2.31.patch
new file mode 100644
index 0000000000..079a24f149
--- /dev/null
+++ b/package/dvb-apps/0006-fix-glibc-2.31.patch
@@ -0,0 +1,21 @@
+dvbdate: fix compilation error with glibc 2.31
+
+as stime func doesn't exists anymore in newer versions of glibc >= 2.31 due
+to obseletion, a replacment with clock_settime is inorder to fix the issue.
+
+Signed-off-by: Dagg Stompler <daggs@gmx.com>
+
+--- a/util/dvbdate/dvbdate.c
++++ b/util/dvbdate/dvbdate.c
+@@ -309,7 +309,10 @@
+ */
+ int set_time(time_t * new_time)
+ {
+- if (stime(new_time)) {
++ struct timespec s = {0};
++ s.tv_sec = new_time;
++
++ if (clock_settime(CLOCK_REALTIME, &s)) {
+ perror("Unable to set time");
+ return -1;
+ }
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] package/dvb-apps: fix build failure with glibc 2.31
2020-09-26 17:09 [Buildroot] [PATCH v2] package/dvb-apps: fix build failure with glibc 2.31 Dagg Stompler
@ 2020-10-15 21:12 ` Thomas Petazzoni
2020-10-16 20:59 ` Yann E. MORIN
2020-10-28 17:08 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2020-10-15 21:12 UTC (permalink / raw)
To: buildroot
On Sat, 26 Sep 2020 20:09:20 +0300
Dagg Stompler <daggs@gmx.com> wrote:
> dvb-apps fails to build with glibc 2.31 with the following error:
> | dvbdate.c: In function set_time:
> | dvbdate.c:312:6: warning: implicit declaration of function stime; did you mean ctime? [-Wimplicit-function-declaration]
> | 312 | if (stime(new_time)) {
> | | ^~~~~
> | | ctime
>
> Fixes:
>
> http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
>
> references:
> 1. https://gitweb.gentoo.org/repo/gentoo.git/commit/media-tv/linuxtv-dvb-apps/files/linuxtv-dvb-apps-glibc-2.31.patch?id=eb705f892eae45b93306c1de1407c1c22ac23956
> 2. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964223
>
> Signed-off-by: Dagg Stompler <daggs@gmx.com>
> ---
> Changes v1 -> v2:
> 1. fix coomit header (Thomas Petazzoni)
> 2. add reference to autobuilder failure (Thomas Petazzoni)
> 3. rework patch (Thomas Petazzoni)
> 4. added maintainer to CC
Applied to master, thanks. I'm wondering: is dvb-apps still useful? It
doesn't seem to really be maintained anywhere...
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] package/dvb-apps: fix build failure with glibc 2.31
2020-10-15 21:12 ` Thomas Petazzoni
@ 2020-10-16 20:59 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-10-16 20:59 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2020-10-15 23:12 +0200, Thomas Petazzoni spake thusly:
> On Sat, 26 Sep 2020 20:09:20 +0300
> > dvb-apps fails to build with glibc 2.31 with the following error:
> > Fixes:
> > http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
> Applied to master, thanks. I'm wondering: is dvb-apps still useful? It
> doesn't seem to really be maintained anywhere...
Last commit was on 2014-03-21, more than 6 years ago now. The project is
in the "Old projects not maintained anymore at LinuxTV.org" section of
linuxtv.org.
The homepage https://www.linuxtv.org/wiki/index.php/LinuxTV_dvb-apps has
not been updated since 2013-02-16.
It seems they have been replaced by a set of utilties in the v4l-utils
tree: https://git.linuxtv.org/v4l-utils.git/tree/utils at least
regarding the scanning utilities, and by a repository dedicated to
hosting the scnan tables: https://git.linuxtv.org/dtv-scan-tables.git/
dvb-apps still has a few utilities that are not avilable elsewhere, like
dvbdate, to set the clock from the DTV signal, for example.
TBH, I lost most interest in these DTV-related packages since the time I
added them, 6 to 8 years ago now, and I no longer use them anymore, so I
am not really sure how they relate to each other now...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] package/dvb-apps: fix build failure with glibc 2.31
2020-09-26 17:09 [Buildroot] [PATCH v2] package/dvb-apps: fix build failure with glibc 2.31 Dagg Stompler
2020-10-15 21:12 ` Thomas Petazzoni
@ 2020-10-28 17:08 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-10-28 17:08 UTC (permalink / raw)
To: buildroot
>>>>> "Dagg" == Dagg Stompler <daggs@gmx.com> writes:
> dvb-apps fails to build with glibc 2.31 with the following error:
> | dvbdate.c: In function set_time:
> | dvbdate.c:312:6: warning: implicit declaration of function stime; did you mean ctime? [-Wimplicit-function-declaration]
> | 312 | if (stime(new_time)) {
> | | ^~~~~
> | | ctime
> Fixes:
> http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
> references:
> 1. https://gitweb.gentoo.org/repo/gentoo.git/commit/media-tv/linuxtv-dvb-apps/files/linuxtv-dvb-apps-glibc-2.31.patch?id=eb705f892eae45b93306c1de1407c1c22ac23956
> 2. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964223
> Signed-off-by: Dagg Stompler <daggs@gmx.com>
> ---
> Changes v1 -> v2:
> 1. fix coomit header (Thomas Petazzoni)
> 2. add reference to autobuilder failure (Thomas Petazzoni)
> 3. rework patch (Thomas Petazzoni)
> 4. added maintainer to CC
Committed to 2020.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-28 17:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-26 17:09 [Buildroot] [PATCH v2] package/dvb-apps: fix build failure with glibc 2.31 Dagg Stompler
2020-10-15 21:12 ` Thomas Petazzoni
2020-10-16 20:59 ` Yann E. MORIN
2020-10-28 17:08 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.