* Re: [PATCH] ASoC: Intel: boards: Add CML_RT1015 m/c driver
[not found] <1602864145-32249-1-git-send-email-keith.tzeng@quantatw.com>
@ 2020-10-16 16:04 ` Mark Brown
2020-10-16 16:19 ` Pierre-Louis Bossart
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2020-10-16 16:04 UTC (permalink / raw)
To: matsufan; +Cc: alsa-devel, Keith Tzeng, mac.chiang, Keith Tzeng
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
On Sat, Oct 17, 2020 at 12:02:24AM +0800, matsufan@gmail.com wrote:
> +<<<<<<< HEAD
> obj-$(CONFIG_SND_SOC_INTEL_SOF_CML_RT1011_RT5682_MACH) += snd-soc-cml_rt1011_rt5682.o
> +=======
> +obj-$(CONFIG_SND_SOC_INTEL_SOF_CML_RT1011_RT5682_MACH) += cml_rt1011_rt5682.o
> +obj-$(CONFIG_SND_SOC_INTEL_SOF_CML_RT1015_RT5682_MACH) += cml_rt1015_rt5682.o
> +>>>>>>> 955c356... CHROMIUM: ASoC: Intel: boards: Add CML_RT1015 m/c driver
There's an unresolved conflict here :/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Intel: boards: Add CML_RT1015 m/c driver
2020-10-16 16:04 ` [PATCH] ASoC: Intel: boards: Add CML_RT1015 m/c driver Mark Brown
@ 2020-10-16 16:19 ` Pierre-Louis Bossart
2020-10-16 16:34 ` Mark Brown
2020-10-16 17:55 ` Lu, Brent
0 siblings, 2 replies; 4+ messages in thread
From: Pierre-Louis Bossart @ 2020-10-16 16:19 UTC (permalink / raw)
To: Mark Brown, matsufan; +Cc: alsa-devel, Keith Tzeng, mac.chiang, Keith Tzeng
On 10/16/20 11:04 AM, Mark Brown wrote:
> On Sat, Oct 17, 2020 at 12:02:24AM +0800, matsufan@gmail.com wrote:
>
>> +<<<<<<< HEAD
>> obj-$(CONFIG_SND_SOC_INTEL_SOF_CML_RT1011_RT5682_MACH) += snd-soc-cml_rt1011_rt5682.o
>> +=======
>> +obj-$(CONFIG_SND_SOC_INTEL_SOF_CML_RT1011_RT5682_MACH) += cml_rt1011_rt5682.o
>> +obj-$(CONFIG_SND_SOC_INTEL_SOF_CML_RT1015_RT5682_MACH) += cml_rt1015_rt5682.o
>> +>>>>>>> 955c356... CHROMIUM: ASoC: Intel: boards: Add CML_RT1015 m/c driver
>
> There's an unresolved conflict here :/
Was this patch shared on the mailing list? I don't see it in my inbox
and in the archives?
At any rate, I am not hot on adding yet another machine driver just to
change an amplifier version. It's really horrible to maintain all of
these permutations by code duplication.
Adding a variant in a existing machine driver is a much better idea, and
pretty much all new machine drivers follow this model. You could either
rename the existing driver as cml_rt101x_rt5682 or use sof_rt5682.
Thanks
-Pierre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Intel: boards: Add CML_RT1015 m/c driver
2020-10-16 16:19 ` Pierre-Louis Bossart
@ 2020-10-16 16:34 ` Mark Brown
2020-10-16 17:55 ` Lu, Brent
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2020-10-16 16:34 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: matsufan, alsa-devel, Keith Tzeng, mac.chiang, Keith Tzeng
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
On Fri, Oct 16, 2020 at 11:19:41AM -0500, Pierre-Louis Bossart wrote:
> On 10/16/20 11:04 AM, Mark Brown wrote:
> > There's an unresolved conflict here :/
> Was this patch shared on the mailing list? I don't see it in my inbox and in
> the archives?
I did a reply all - it might've been held for moderation on the list?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ASoC: Intel: boards: Add CML_RT1015 m/c driver
2020-10-16 16:19 ` Pierre-Louis Bossart
2020-10-16 16:34 ` Mark Brown
@ 2020-10-16 17:55 ` Lu, Brent
1 sibling, 0 replies; 4+ messages in thread
From: Lu, Brent @ 2020-10-16 17:55 UTC (permalink / raw)
To: Pierre-Louis Bossart, Mark Brown, matsufan, Jimmy Cheng-Yi Chiang
Cc: alsa-devel, Keith Tzeng, Chiang, Mac, Keith Tzeng
>
> Was this patch shared on the mailing list? I don't see it in my inbox and in the
> archives?
>
> At any rate, I am not hot on adding yet another machine driver just to change
> an amplifier version. It's really horrible to maintain all of these permutations
> by code duplication.
>
> Adding a variant in a existing machine driver is a much better idea, and pretty
> much all new machine drivers follow this model. You could either rename the
> existing driver as cml_rt101x_rt5682 or use sof_rt5682.
>
> Thanks
> -Pierre
+ Jimmy from google
Hi Jimmy,
Any opinion about CML machine drivers for Chromebooks?
We may keep the separated driver in CHROMIUM or modify existing Helios driver
to adopt the architecture in sof_rt5682 to work with multiple amps.
Regards,
Brent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-16 17:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1602864145-32249-1-git-send-email-keith.tzeng@quantatw.com>
2020-10-16 16:04 ` [PATCH] ASoC: Intel: boards: Add CML_RT1015 m/c driver Mark Brown
2020-10-16 16:19 ` Pierre-Louis Bossart
2020-10-16 16:34 ` Mark Brown
2020-10-16 17:55 ` Lu, Brent
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.