* [PATCH net] net/sched: act_ct: Fix adding udp port mangle operation
@ 2020-10-19 9:02 Roi Dayan
2020-10-20 23:20 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Roi Dayan @ 2020-10-19 9:02 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Paul Blakey, Oz Shlomo, Roi Dayan
Need to use the udp header type and not tcp.
Fixes: 9c26ba9b1f45 ("net/sched: act_ct: Instantiate flow table entry actions")
Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Paul Blakey <paulb@nvidia.com>
---
net/sched/act_ct.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
index a780afdf570d..0bac241a4123 100644
--- a/net/sched/act_ct.c
+++ b/net/sched/act_ct.c
@@ -156,11 +156,11 @@ tcf_ct_flow_table_add_action_nat_udp(const struct nf_conntrack_tuple *tuple,
__be16 target_dst = target.dst.u.udp.port;
if (target_src != tuple->src.u.udp.port)
- tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_TCP,
+ tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_UDP,
offsetof(struct udphdr, source),
0xFFFF, be16_to_cpu(target_src));
if (target_dst != tuple->dst.u.udp.port)
- tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_TCP,
+ tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_UDP,
offsetof(struct udphdr, dest),
0xFFFF, be16_to_cpu(target_dst));
}
--
2.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net/sched: act_ct: Fix adding udp port mangle operation
2020-10-19 9:02 [PATCH net] net/sched: act_ct: Fix adding udp port mangle operation Roi Dayan
@ 2020-10-20 23:20 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-10-20 23:20 UTC (permalink / raw)
To: Roi Dayan; +Cc: netdev, David S. Miller, Paul Blakey, Oz Shlomo
On Mon, 19 Oct 2020 12:02:44 +0300 Roi Dayan wrote:
> Need to use the udp header type and not tcp.
>
> Fixes: 9c26ba9b1f45 ("net/sched: act_ct: Instantiate flow table entry actions")
> Signed-off-by: Roi Dayan <roid@nvidia.com>
> Reviewed-by: Paul Blakey <paulb@nvidia.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-20 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 9:02 [PATCH net] net/sched: act_ct: Fix adding udp port mangle operation Roi Dayan
2020-10-20 23:20 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.