Re: [PATCH v3 5/5] tools/virtiofsd: xattr name mappings: Simple 'map'

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: dinechin@redhat.com, virtio-fs@redhat.com, qemu-devel@nongnu.org,
	vgoyal@redhat.com
Subject: Re: [PATCH v3 5/5] tools/virtiofsd: xattr name mappings: Simple 'map'
Date: Tue, 20 Oct 2020 11:09:22 +0100	[thread overview]
Message-ID: <20201020100922.GF140014@stefanha-x1.localdomain> (raw)
In-Reply-To: <20201014180209.49299-6-dgilbert@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

On Wed, Oct 14, 2020 at 07:02:09PM +0100, Dr. David Alan Gilbert (git) wrote:
> +static XattrMapEntry *parse_xattrmap_map(const char *rule,
> +                                         XattrMapEntry *map,
> +                                         size_t *nentries)
> +{
> +    char sep = *rule++;
> +    const char *tmp;
> +    char *key;
> +    char *prefix;
> +    XattrMapEntry tmp_entry;
> +
> +    /* At start of 'key' field */
> +    tmp = strchr(rule, sep);

Missing sep == '\0' check. The strchr(3) man page says:

  The terminating null byte is considered part of the string, so that if
  c is specified as '\0', these functions return a pointer to the
  terminator.

So the code in this patch will eventually access beyond the end of the
string:

  rule = tmp + 1; <-- tmp is already at the NUL terminator

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)

From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: dinechin@redhat.com, virtio-fs@redhat.com, qemu-devel@nongnu.org,
	vgoyal@redhat.com
Subject: Re: [Virtio-fs] [PATCH v3 5/5] tools/virtiofsd: xattr name mappings: Simple 'map'
Date: Tue, 20 Oct 2020 11:09:22 +0100	[thread overview]
Message-ID: <20201020100922.GF140014@stefanha-x1.localdomain> (raw)
In-Reply-To: <20201014180209.49299-6-dgilbert@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

On Wed, Oct 14, 2020 at 07:02:09PM +0100, Dr. David Alan Gilbert (git) wrote:
> +static XattrMapEntry *parse_xattrmap_map(const char *rule,
> +                                         XattrMapEntry *map,
> +                                         size_t *nentries)
> +{
> +    char sep = *rule++;
> +    const char *tmp;
> +    char *key;
> +    char *prefix;
> +    XattrMapEntry tmp_entry;
> +
> +    /* At start of 'key' field */
> +    tmp = strchr(rule, sep);

Missing sep == '\0' check. The strchr(3) man page says:

  The terminating null byte is considered part of the string, so that if
  c is specified as '\0', these functions return a pointer to the
  terminator.

So the code in this patch will eventually access beyond the end of the
string:

  rule = tmp + 1; <-- tmp is already at the NUL terminator

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

next prev parent reply	other threads:[~2020-10-20 10:10 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 18:02 [PATCH v3 0/5] virtiofsd xattr name mappings Dr. David Alan Gilbert (git)
2020-10-14 18:02 ` [Virtio-fs] " Dr. David Alan Gilbert (git)
2020-10-14 18:02 ` [PATCH v3 1/5] tools/virtiofsd: xattr name mappings: Add option Dr. David Alan Gilbert (git)
2020-10-14 18:02   ` [Virtio-fs] " Dr. David Alan Gilbert (git)
2020-10-20  9:07   ` Stefan Hajnoczi
2020-10-20  9:07     ` [Virtio-fs] " Stefan Hajnoczi
2020-10-21 17:13     ` Dr. David Alan Gilbert
2020-10-21 17:13       ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-20 14:04   ` Vivek Goyal
2020-10-20 14:04     ` [Virtio-fs] " Vivek Goyal
2020-10-22 14:52   ` Vivek Goyal
2020-10-22 14:52     ` [Virtio-fs] " Vivek Goyal
2020-10-23 15:46     ` Dr. David Alan Gilbert
2020-10-23 15:46       ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-14 18:02 ` [PATCH v3 2/5] tools/virtiofsd: xattr name mappings: Map client xattr names Dr. David Alan Gilbert (git)
2020-10-14 18:02   ` [Virtio-fs] " Dr. David Alan Gilbert (git)
2020-10-20  9:16   ` Stefan Hajnoczi
2020-10-20  9:16     ` [Virtio-fs] " Stefan Hajnoczi
2020-10-22 15:28   ` Vivek Goyal
2020-10-22 15:28     ` [Virtio-fs] " Vivek Goyal
2020-10-23 15:04     ` Dr. David Alan Gilbert
2020-10-23 15:04       ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-14 18:02 ` [PATCH v3 3/5] tools/virtiofsd: xattr name mappings: Map server " Dr. David Alan Gilbert (git)
2020-10-14 18:02   ` [Virtio-fs] " Dr. David Alan Gilbert (git)
2020-10-15 23:57   ` [Virtio-fs] Puzzle about rootflags, restorecon "operation not supported" Harry G. Coin
2020-10-20  9:54     ` Stefan Hajnoczi
2020-10-20 12:57       ` Miklos Szeredi
2020-10-20 14:55         ` Harry G. Coin
2020-10-20  9:52   ` [PATCH v3 3/5] tools/virtiofsd: xattr name mappings: Map server xattr names Stefan Hajnoczi
2020-10-20  9:52     ` [Virtio-fs] " Stefan Hajnoczi
2020-10-22 16:16   ` Vivek Goyal
2020-10-22 16:16     ` [Virtio-fs] " Vivek Goyal
2020-10-23 14:49     ` Dr. David Alan Gilbert
2020-10-23 14:49       ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-14 18:02 ` [PATCH v3 4/5] tools/virtiofsd: xattr name mapping examples Dr. David Alan Gilbert (git)
2020-10-14 18:02   ` [Virtio-fs] " Dr. David Alan Gilbert (git)
2020-10-20  9:56   ` Stefan Hajnoczi
2020-10-20  9:56     ` [Virtio-fs] " Stefan Hajnoczi
2020-10-20 14:40   ` Vivek Goyal
2020-10-20 14:40     ` [Virtio-fs] " Vivek Goyal
2020-10-20 15:34     ` Dr. David Alan Gilbert
2020-10-20 15:34       ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-20 17:56       ` Vivek Goyal
2020-10-20 17:56         ` [Virtio-fs] " Vivek Goyal
2020-10-20 19:02         ` Dr. David Alan Gilbert
2020-10-20 19:02           ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-21 13:44           ` Vivek Goyal
2020-10-21 13:44             ` [Virtio-fs] " Vivek Goyal
2020-10-21 17:39             ` Dr. David Alan Gilbert
2020-10-21 17:39               ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-14 18:02 ` [PATCH v3 5/5] tools/virtiofsd: xattr name mappings: Simple 'map' Dr. David Alan Gilbert (git)
2020-10-14 18:02   ` [Virtio-fs] " Dr. David Alan Gilbert (git)
2020-10-20 10:09   ` Stefan Hajnoczi [this message]
2020-10-20 10:09     ` Stefan Hajnoczi
2020-10-20 11:35     ` Dr. David Alan Gilbert
2020-10-20 11:35       ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-22 13:42   ` Vivek Goyal
2020-10-22 13:42     ` [Virtio-fs] " Vivek Goyal
2020-10-23 13:05     ` Dr. David Alan Gilbert
2020-10-23 13:05       ` [Virtio-fs] " Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201020100922.GF140014@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=dinechin@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.