All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: "Alex G." <mr.nuke.me@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>, Mark Brown <broonie@kernel.org>,
	Jonas Karlman <jonas@kwiboo.se>,
	open list <linux-kernel@vger.kernel.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH v2 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies if present
Date: Tue, 20 Oct 2020 17:08:45 +0200	[thread overview]
Message-ID: <20201020150845.GA1913775@ravnborg.org> (raw)
In-Reply-To: <5c21a4a4-717c-9f8a-9764-6e3fb9554e46@gmail.com>

Hi Alex.

On Tue, Oct 20, 2020 at 09:01:27AM -0500, Alex G. wrote:
> 
> 
> On 10/20/20 2:16 AM, Sam Ravnborg wrote:
> > Hi Alex.
> 
> [snip]
> 
> > > 
> > > 
> > > > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> > > > index 33fd33f953ec..d15e9f2c0d8a 100644
> > > > --- a/drivers/gpu/drm/bridge/sii902x.c
> > > > +++ b/drivers/gpu/drm/bridge/sii902x.c
> > > > @@ -17,6 +17,7 @@
> > > >    #include <linux/i2c.h>
> > > >    #include <linux/module.h>
> > > >    #include <linux/regmap.h>
> > > > +#include <linux/regulator/consumer.h>
> > > >    #include <linux/clk.h>
> > > >    #include <drm/drm_atomic_helper.h>
> > > > @@ -168,6 +169,8 @@ struct sii902x {
> > > >    	struct drm_connector connector;
> > > >    	struct gpio_desc *reset_gpio;
> > > >    	struct i2c_mux_core *i2cmux;
> > > > +	struct regulator *iovcc;
> > > > +	struct regulator *cvcc12;
> > > >    	/*
> > > >    	 * Mutex protects audio and video functions from interfering
> > > >    	 * each other, by keeping their i2c command sequences atomic.
> > > > @@ -954,13 +957,13 @@ static const struct drm_bridge_timings default_sii902x_timings = {
> > > >    		 | DRM_BUS_FLAG_DE_HIGH,
> > > >    };
> > > > +static int sii902x_init(struct sii902x *sii902x);
> > Please re-arrange the code so this prototype is not needed.
> 
> I'd be happy to re-arrange things. It will make the diff look a lot bigger
> than what it is. Is that okay?

The best way would be to split it in two patches.
One that is pure code movement and one that does the actula changes.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: "Alex G." <mr.nuke.me@gmail.com>
Cc: devicetree@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Rob Herring <robh+dt@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>, Jonas Karlman <jonas@kwiboo.se>,
	open list <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Mark Brown <broonie@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH v2 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies if present
Date: Tue, 20 Oct 2020 17:08:45 +0200	[thread overview]
Message-ID: <20201020150845.GA1913775@ravnborg.org> (raw)
In-Reply-To: <5c21a4a4-717c-9f8a-9764-6e3fb9554e46@gmail.com>

Hi Alex.

On Tue, Oct 20, 2020 at 09:01:27AM -0500, Alex G. wrote:
> 
> 
> On 10/20/20 2:16 AM, Sam Ravnborg wrote:
> > Hi Alex.
> 
> [snip]
> 
> > > 
> > > 
> > > > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> > > > index 33fd33f953ec..d15e9f2c0d8a 100644
> > > > --- a/drivers/gpu/drm/bridge/sii902x.c
> > > > +++ b/drivers/gpu/drm/bridge/sii902x.c
> > > > @@ -17,6 +17,7 @@
> > > >    #include <linux/i2c.h>
> > > >    #include <linux/module.h>
> > > >    #include <linux/regmap.h>
> > > > +#include <linux/regulator/consumer.h>
> > > >    #include <linux/clk.h>
> > > >    #include <drm/drm_atomic_helper.h>
> > > > @@ -168,6 +169,8 @@ struct sii902x {
> > > >    	struct drm_connector connector;
> > > >    	struct gpio_desc *reset_gpio;
> > > >    	struct i2c_mux_core *i2cmux;
> > > > +	struct regulator *iovcc;
> > > > +	struct regulator *cvcc12;
> > > >    	/*
> > > >    	 * Mutex protects audio and video functions from interfering
> > > >    	 * each other, by keeping their i2c command sequences atomic.
> > > > @@ -954,13 +957,13 @@ static const struct drm_bridge_timings default_sii902x_timings = {
> > > >    		 | DRM_BUS_FLAG_DE_HIGH,
> > > >    };
> > > > +static int sii902x_init(struct sii902x *sii902x);
> > Please re-arrange the code so this prototype is not needed.
> 
> I'd be happy to re-arrange things. It will make the diff look a lot bigger
> than what it is. Is that okay?

The best way would be to split it in two patches.
One that is pure code movement and one that does the actula changes.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-10-20 15:08 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 20:05 [PATCH 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies if present Alexandru Gagniuc
2020-09-24 20:05 ` Alexandru Gagniuc
2020-09-24 20:05 ` [PATCH 2/2] dt-bindings: display: sii902x: Add supply bindings Alexandru Gagniuc
2020-09-24 20:05   ` Alexandru Gagniuc
2020-09-26 18:42   ` Sam Ravnborg
2020-09-26 18:42     ` Sam Ravnborg
2020-09-24 20:22 ` [PATCH 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies if present Fabio Estevam
2020-09-24 20:22   ` Fabio Estevam
2020-09-24 20:34   ` Alex G.
2020-09-24 20:34     ` Alex G.
2020-09-26 12:50 ` Dan Carpenter
2020-09-26 12:50   ` Dan Carpenter
2020-09-26 12:50   ` Dan Carpenter
2020-09-26 12:50   ` Dan Carpenter
2020-09-26 18:49 ` Sam Ravnborg
2020-09-26 18:49   ` Sam Ravnborg
2020-09-28 17:35   ` Alex G.
2020-09-28 17:35     ` Alex G.
2020-09-28 19:03     ` Sam Ravnborg
2020-09-28 19:03       ` Sam Ravnborg
2020-09-28 17:30 ` [PATCH v2 " Alexandru Gagniuc
2020-09-28 17:30   ` Alexandru Gagniuc
2020-09-28 17:30   ` [PATCH v2 2/2] dt-bindings: display: sii902x: Add supply bindings Alexandru Gagniuc
2020-09-28 17:30     ` Alexandru Gagniuc
2020-09-29 20:17     ` Rob Herring
2020-09-29 20:17       ` Rob Herring
2020-10-20  1:24   ` [PATCH v2 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies if present Alex G.
2020-10-20  1:24     ` Alex G.
2020-10-20  7:16     ` Sam Ravnborg
2020-10-20  7:16       ` Sam Ravnborg
2020-10-20 14:01       ` Alex G.
2020-10-20 14:01         ` Alex G.
2020-10-20 15:08         ` Sam Ravnborg [this message]
2020-10-20 15:08           ` Sam Ravnborg
2020-10-20 22:14   ` [PATCH v3 1/3] drm/bridge: sii902x: Refactor init code into separate function Alexandru Gagniuc
2020-10-20 22:14     ` Alexandru Gagniuc
2020-10-20 22:14   ` [PATCH v3 2/3] drm/bridge: sii902x: Enable I/O and core VCC supplies if present Alexandru Gagniuc
2020-10-20 22:14     ` Alexandru Gagniuc
2020-11-08 10:55     ` Sam Ravnborg
2020-11-08 10:55       ` Sam Ravnborg
2020-10-20 22:14   ` [PATCH v3 3/3] dt-bindings: display: sii902x: Add supply bindings Alexandru Gagniuc
2020-10-20 22:14     ` Alexandru Gagniuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201020150845.GA1913775@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=mr.nuke.me@gmail.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.