From: Sudeep Holla <sudeep.holla@arm.com> To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Sudeep Holla <sudeep.holla@arm.com>, linux-arm-kernel@lists.infradead.org, Rob Herring <robh+dt@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org> Subject: [PATCH 2/2] firmware: arm_scmi: Move away from clock devicetree bindings Date: Tue, 20 Oct 2020 21:37:10 +0100 [thread overview] Message-ID: <20201020203710.10100-2-sudeep.holla@arm.com> (raw) In-Reply-To: <20201020203710.10100-1-sudeep.holla@arm.com> Commit dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER") handles -EPROBE_DEFER for the clock/interconnects within _allocate_opp_table() which is called from dev_pm_opp_add and it now propagates the error back to the caller. This breaks SCMI performance domains as we will never succeed to add any OPPs. A quick fix would be to register dummy clocks which is completely ugly and bigger fix which may break with some other change in future. It is better to add separate binding for the same and use it. A separate SCMI performance domain binding is introduced and let us use it here. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/firmware/arm_scmi/perf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c index 3e1e87012c95..e2a47b3eead1 100644 --- a/drivers/firmware/arm_scmi/perf.c +++ b/drivers/firmware/arm_scmi/perf.c @@ -629,13 +629,13 @@ static void scmi_perf_domain_init_fc(const struct scmi_handle *handle, /* Device specific ops */ static int scmi_dev_domain_id(struct device *dev) { - struct of_phandle_args clkspec; + struct of_phandle_args spec; - if (of_parse_phandle_with_args(dev->of_node, "clocks", "#clock-cells", - 0, &clkspec)) + if (of_parse_phandle_with_args(dev->of_node, "arm,scmi-perf-domain", + "#perf-domain-cells", 0, &spec)) return -EINVAL; - return clkspec.args[0]; + return spec.args[0]; } static int scmi_dvfs_device_opps_add(const struct scmi_handle *handle, -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com> To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Viresh Kumar <viresh.kumar@linaro.org>, Rob Herring <robh+dt@kernel.org>, linux-arm-kernel@lists.infradead.org, Sudeep Holla <sudeep.holla@arm.com> Subject: [PATCH 2/2] firmware: arm_scmi: Move away from clock devicetree bindings Date: Tue, 20 Oct 2020 21:37:10 +0100 [thread overview] Message-ID: <20201020203710.10100-2-sudeep.holla@arm.com> (raw) In-Reply-To: <20201020203710.10100-1-sudeep.holla@arm.com> Commit dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER") handles -EPROBE_DEFER for the clock/interconnects within _allocate_opp_table() which is called from dev_pm_opp_add and it now propagates the error back to the caller. This breaks SCMI performance domains as we will never succeed to add any OPPs. A quick fix would be to register dummy clocks which is completely ugly and bigger fix which may break with some other change in future. It is better to add separate binding for the same and use it. A separate SCMI performance domain binding is introduced and let us use it here. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/firmware/arm_scmi/perf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c index 3e1e87012c95..e2a47b3eead1 100644 --- a/drivers/firmware/arm_scmi/perf.c +++ b/drivers/firmware/arm_scmi/perf.c @@ -629,13 +629,13 @@ static void scmi_perf_domain_init_fc(const struct scmi_handle *handle, /* Device specific ops */ static int scmi_dev_domain_id(struct device *dev) { - struct of_phandle_args clkspec; + struct of_phandle_args spec; - if (of_parse_phandle_with_args(dev->of_node, "clocks", "#clock-cells", - 0, &clkspec)) + if (of_parse_phandle_with_args(dev->of_node, "arm,scmi-perf-domain", + "#perf-domain-cells", 0, &spec)) return -EINVAL; - return clkspec.args[0]; + return spec.args[0]; } static int scmi_dvfs_device_opps_add(const struct scmi_handle *handle, -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-20 20:37 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-20 20:37 [PATCH 1/2] dt-bindings: arm,scmi: Do not use clocks for SCMI performance domains Sudeep Holla 2020-10-20 20:37 ` [PATCH 1/2] dt-bindings: arm, scmi: " Sudeep Holla 2020-10-20 20:37 ` Sudeep Holla [this message] 2020-10-20 20:37 ` [PATCH 2/2] firmware: arm_scmi: Move away from clock devicetree bindings Sudeep Holla 2020-10-21 16:20 ` [PATCH 1/2] dt-bindings: arm,scmi: Do not use clocks for SCMI performance domains Rob Herring 2020-10-21 16:20 ` Rob Herring 2020-10-21 16:30 ` Sudeep Holla 2020-10-21 16:30 ` Sudeep Holla 2020-10-23 13:21 ` Rob Herring 2020-10-23 13:21 ` Rob Herring 2020-10-23 13:55 ` Sudeep Holla 2020-10-23 13:55 ` Sudeep Holla 2020-10-23 14:58 ` Sudeep Holla 2020-10-23 14:58 ` Sudeep Holla 2020-10-21 18:19 ` Sudeep Holla 2020-10-21 18:19 ` Sudeep Holla 2020-10-23 13:34 ` Rob Herring 2020-10-23 13:34 ` Rob Herring 2020-10-23 14:27 ` Sudeep Holla 2020-10-23 14:27 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201020203710.10100-2-sudeep.holla@arm.com \ --to=sudeep.holla@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.