From: jaegeuk@kernel.org To: Can Guo <cang@codeaurora.org> Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman <avri.altman@wdc.com> Subject: Re: [PATCH v2 1/5] scsi: ufs: atomic update for clkgating_enable Date: Tue, 20 Oct 2020 21:41:28 -0700 [thread overview] Message-ID: <20201021044128.GA3004521@google.com> (raw) In-Reply-To: <6c7bc6794b215a0ae1ae0cd9d448efa3@codeaurora.org> On 10/21, Can Guo wrote: > On 2020-10-21 03:52, Jaegeuk Kim wrote: > > From: Jaegeuk Kim <jaegeuk@google.com> > > > > When giving a stress test which enables/disables clkgating, we hit > > device > > timeout sometimes. This patch avoids subtle racy condition to address > > it. > > > > Cc: Alim Akhtar <alim.akhtar@samsung.com> > > Cc: Avri Altman <avri.altman@wdc.com> > > Cc: Can Guo <cang@codeaurora.org> > > Signed-off-by: Jaegeuk Kim <jaegeuk@google.com> > > Reviewed-by: Can Guo <cang@codeaurora.org> > > Next time can you have a cover letter in case of multiple patches? Ah, it seems I had to cc you here as well. https://lore.kernel.org/linux-scsi/20201020195258.2005605-1-jaegeuk@kernel.org/T/#mb4e43f3bd03a6b7bc136bea21ac805041c1417a2 > > Thanks, > > Can Guo. > > > --- > > drivers/scsi/ufs/ufshcd.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > > index b8f573a02713..7344353a9167 100644 > > --- a/drivers/scsi/ufs/ufshcd.c > > +++ b/drivers/scsi/ufs/ufshcd.c > > @@ -1807,19 +1807,19 @@ static ssize_t > > ufshcd_clkgate_enable_store(struct device *dev, > > return -EINVAL; > > > > value = !!value; > > + > > + spin_lock_irqsave(hba->host->host_lock, flags); > > if (value == hba->clk_gating.is_enabled) > > goto out; > > > > - if (value) { > > - ufshcd_release(hba); > > - } else { > > - spin_lock_irqsave(hba->host->host_lock, flags); > > + if (value) > > + __ufshcd_release(hba); > > + else > > hba->clk_gating.active_reqs++; > > - spin_unlock_irqrestore(hba->host->host_lock, flags); > > - } > > > > hba->clk_gating.is_enabled = value; > > out: > > + spin_unlock_irqrestore(hba->host->host_lock, flags); > > return count; > > }
WARNING: multiple messages have this Message-ID (diff)
From: jaegeuk@kernel.org To: Can Guo <cang@codeaurora.org> Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Avri Altman <avri.altman@wdc.com>, Alim Akhtar <alim.akhtar@samsung.com>, kernel-team@android.com Subject: Re: [f2fs-dev] [PATCH v2 1/5] scsi: ufs: atomic update for clkgating_enable Date: Tue, 20 Oct 2020 21:41:28 -0700 [thread overview] Message-ID: <20201021044128.GA3004521@google.com> (raw) In-Reply-To: <6c7bc6794b215a0ae1ae0cd9d448efa3@codeaurora.org> On 10/21, Can Guo wrote: > On 2020-10-21 03:52, Jaegeuk Kim wrote: > > From: Jaegeuk Kim <jaegeuk@google.com> > > > > When giving a stress test which enables/disables clkgating, we hit > > device > > timeout sometimes. This patch avoids subtle racy condition to address > > it. > > > > Cc: Alim Akhtar <alim.akhtar@samsung.com> > > Cc: Avri Altman <avri.altman@wdc.com> > > Cc: Can Guo <cang@codeaurora.org> > > Signed-off-by: Jaegeuk Kim <jaegeuk@google.com> > > Reviewed-by: Can Guo <cang@codeaurora.org> > > Next time can you have a cover letter in case of multiple patches? Ah, it seems I had to cc you here as well. https://lore.kernel.org/linux-scsi/20201020195258.2005605-1-jaegeuk@kernel.org/T/#mb4e43f3bd03a6b7bc136bea21ac805041c1417a2 > > Thanks, > > Can Guo. > > > --- > > drivers/scsi/ufs/ufshcd.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > > index b8f573a02713..7344353a9167 100644 > > --- a/drivers/scsi/ufs/ufshcd.c > > +++ b/drivers/scsi/ufs/ufshcd.c > > @@ -1807,19 +1807,19 @@ static ssize_t > > ufshcd_clkgate_enable_store(struct device *dev, > > return -EINVAL; > > > > value = !!value; > > + > > + spin_lock_irqsave(hba->host->host_lock, flags); > > if (value == hba->clk_gating.is_enabled) > > goto out; > > > > - if (value) { > > - ufshcd_release(hba); > > - } else { > > - spin_lock_irqsave(hba->host->host_lock, flags); > > + if (value) > > + __ufshcd_release(hba); > > + else > > hba->clk_gating.active_reqs++; > > - spin_unlock_irqrestore(hba->host->host_lock, flags); > > - } > > > > hba->clk_gating.is_enabled = value; > > out: > > + spin_unlock_irqrestore(hba->host->host_lock, flags); > > return count; > > } _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-10-21 4:41 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-20 19:52 propose some UFS fixes Jaegeuk Kim 2020-10-20 19:52 ` [f2fs-dev] " Jaegeuk Kim 2020-10-20 19:52 ` [PATCH v2 1/5] scsi: ufs: atomic update for clkgating_enable Jaegeuk Kim 2020-10-20 19:52 ` [f2fs-dev] " Jaegeuk Kim 2020-10-21 2:05 ` Can Guo 2020-10-21 2:05 ` [f2fs-dev] " Can Guo 2020-10-21 4:41 ` jaegeuk [this message] 2020-10-21 4:41 ` jaegeuk 2020-10-20 19:52 ` [PATCH v2 2/5] scsi: ufs: clear UAC for FFU and RPMB LUNs Jaegeuk Kim 2020-10-20 19:52 ` [f2fs-dev] " Jaegeuk Kim 2020-10-20 19:52 ` [PATCH v2 3/5] scsi: ufs: use WQ_HIGHPRI for gating work Jaegeuk Kim 2020-10-20 19:52 ` [f2fs-dev] " Jaegeuk Kim 2020-10-21 0:57 ` Can Guo 2020-10-21 0:57 ` [f2fs-dev] " Can Guo 2020-10-21 4:52 ` jaegeuk 2020-10-21 4:52 ` [f2fs-dev] " jaegeuk 2020-10-20 19:52 ` [PATCH v2 4/5] scsi: add more contexts in the ufs tracepoints Jaegeuk Kim 2020-10-20 19:52 ` [f2fs-dev] " Jaegeuk Kim 2020-10-20 19:52 ` [PATCH v2 5/5] scsi: ufs: fix clkgating on/off correctly Jaegeuk Kim 2020-10-20 19:52 ` [f2fs-dev] " Jaegeuk Kim 2020-10-21 2:00 ` Can Guo 2020-10-21 2:00 ` [f2fs-dev] " Can Guo 2020-10-21 4:52 ` jaegeuk 2020-10-21 4:52 ` [f2fs-dev] " jaegeuk 2020-10-21 6:05 ` Can Guo 2020-10-21 6:05 ` [f2fs-dev] " Can Guo 2020-10-23 0:53 ` Jaegeuk Kim 2020-10-23 0:53 ` [f2fs-dev] " Jaegeuk Kim 2020-10-26 3:12 ` Can Guo 2020-10-26 3:12 ` [f2fs-dev] " Can Guo 2020-10-26 6:19 ` Jaegeuk Kim 2020-10-26 6:19 ` [f2fs-dev] " Jaegeuk Kim 2020-10-26 18:47 ` asutoshd 2020-10-26 18:47 ` [f2fs-dev] " asutoshd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201021044128.GA3004521@google.com \ --to=jaegeuk@kernel.org \ --cc=alim.akhtar@samsung.com \ --cc=avri.altman@wdc.com \ --cc=cang@codeaurora.org \ --cc=kernel-team@android.com \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.