[PATCH] tcl: adapt to potential psuedo changes

[PATCH] tcl: adapt to potential psuedo changes

[Yu, Mingli]

From: Mingli Yu <mingli.yu@windriver.com>

It failed as below when rerun do_install for tcl:
 $ bitbake tcl
 $ bitbake tcl -f -cinstall
[snip]
 | NOTE: make -j 72 DESTDIR=/build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/image install
 | abort()ing pseudo client by server request. See https://wiki.yoctoproject.org/wiki/Pseudo_Abort for more details on this.
 | /build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/temp/run.do_install.3490694: line 184: 3499214 Aborted                 (core dumped) make -j 72 "$@"

Though unpack tcl source to ${WORKDIR}/${BPN}${PV}, but we set
S as below:
 S = "${WORKDIR}/${BPN}${PV}/unix"

Exclude ${WORKDIR}/${BPN}${PV} from pseudo database to fix the
above do_install failure.

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 meta/recipes-devtools/tcltk/tcl_8.6.10.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/tcltk/tcl_8.6.10.bb b/meta/recipes-devtools/tcltk/tcl_8.6.10.bb
index aedd96b021..e6feb25a7e 100644
--- a/meta/recipes-devtools/tcltk/tcl_8.6.10.bb
+++ b/meta/recipes-devtools/tcltk/tcl_8.6.10.bb
@@ -32,6 +32,7 @@ SRC_URI_class-native = "${BASE_SRC_URI}"
 
 S = "${WORKDIR}/${BPN}${PV}/unix"
 
+PSEUDO_IGNORE_PATHS .= ",${WORKDIR}/${BPN}${PV}"
 VER = "${PV}"
 
 inherit autotools ptest binconfig update-alternatives
-- 
2.17.1

Re: [OE-core] [PATCH] tcl: adapt to potential psuedo changes

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]

There is typo in the commit summary and doesn't base.bbclass do this
automatically already?

See
https://git.openembedded.org/openembedded-core/tree/meta/classes/base.bbclass#n396

On Wed, Oct 21, 2020 at 11:24 AM Yu, Mingli <mingli.yu@windriver.com> wrote:

> From: Mingli Yu <mingli.yu@windriver.com>
>
> It failed as below when rerun do_install for tcl:
>  $ bitbake tcl
>  $ bitbake tcl -f -cinstall
> [snip]
>  | NOTE: make -j 72
> DESTDIR=/build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/image install
>  | abort()ing pseudo client by server request. See
> https://wiki.yoctoproject.org/wiki/Pseudo_Abort for more details on this.
>  |
> /build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/temp/run.do_install.3490694:
> line 184: 3499214 Aborted                 (core dumped) make -j 72 "$@"
>
> Though unpack tcl source to ${WORKDIR}/${BPN}${PV}, but we set
> S as below:
>  S = "${WORKDIR}/${BPN}${PV}/unix"
>
> Exclude ${WORKDIR}/${BPN}${PV} from pseudo database to fix the
> above do_install failure.
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
>  meta/recipes-devtools/tcltk/tcl_8.6.10.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-devtools/tcltk/tcl_8.6.10.bb
> b/meta/recipes-devtools/tcltk/tcl_8.6.10.bb
> index aedd96b021..e6feb25a7e 100644
> --- a/meta/recipes-devtools/tcltk/tcl_8.6.10.bb
> +++ b/meta/recipes-devtools/tcltk/tcl_8.6.10.bb
> @@ -32,6 +32,7 @@ SRC_URI_class-native = "${BASE_SRC_URI}"
>
>  S = "${WORKDIR}/${BPN}${PV}/unix"
>
> +PSEUDO_IGNORE_PATHS .= ",${WORKDIR}/${BPN}${PV}"
>  VER = "${PV}"
>
>  inherit autotools ptest binconfig update-alternatives
> --
> 2.17.1
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 2831 bytes --]

Re: [OE-core] [PATCH] tcl: adapt to potential psuedo changes

[Richard Purdie]

On Wed, 2020-10-21 at 12:11 +0200, Martin Jansa wrote:
> There is typo in the commit summary and doesn't base.bbclass do this
> automatically already?
> 
> See 
> https://git.openembedded.org/openembedded-core/tree/meta/classes/base.bbclass#n396

I think the issue is because the recipe is setting:

S = ${WORKDIR}/${BPN}${PV}/unix

but we want

${WORKDIR}/${BPN}${PV}
(no /unix suffix)

in the ignored paths so that code won't help?

Cheers,

Richard

Re: [OE-core] [PATCH] tcl: adapt to potential psuedo changes

[Yu, Mingli]

On 10/21/20 6:41 PM, Richard Purdie wrote:
> On Wed, 2020-10-21 at 12:11 +0200, Martin Jansa wrote:
>> There is typo in the commit summary and doesn't base.bbclass do this
>> automatically already?
>>
>> See
>> https://git.openembedded.org/openembedded-core/tree/meta/classes/base.bbclass#n396
> 
> I think the issue is because the recipe is setting:
> 
> S = ${WORKDIR}/${BPN}${PV}/unix
> 
> but we want
> 
> ${WORKDIR}/${BPN}${PV}
> (no /unix suffix)
> 
> in the ignored paths so that code won't help?

Yes, I will send v2 to explain more why tcl is special.

Thanks,

> 
> Cheers,
> 
> Richard
> 

[PATCH v2] tcl: adapt to potential pseudo changes

[Yu, Mingli]

From: Mingli Yu <mingli.yu@windriver.com>

It failed as below when rerun do_install for tcl:
 $ bitbake tcl
 $ bitbake tcl -f -cinstall
 [snip]
 | NOTE: make -j 72 DESTDIR=/build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/image install
 | abort()ing pseudo client by server request. See https://wiki.yoctoproject.org/wiki/Pseudo_Abort for more details on this.
 | /build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/temp/run.do_install.3490694: line 184: 3499214 Aborted                 (core dumped) make -j 72 "$@"

By default the S is ${WORKDIR}/${BPN}-${PV}, but after unpack,
the tcl source [1] unpacked to ${WORKDIR}/${BPN}${PV} and all the
files under ${WORKDIR}/${BPN}${PV} are acutally the source files.

But the the main Makefile.in is under ${WORKDIR}/${BPN}${PV}/unix
for tcl, so there is below logic in tcl recipe:
S = "${WORKDIR}/${BPN}${PV}/unix"

To adapt the potential pseudo changes, there is a general logic to
exclude ${S} from pseudo database in base.bbclass in [2]. That's to
say, just the dir ${WORKDIR}/${BPN}${PV}/unix is excluded from the
pseudo database.

But it's not enough for tcl, we need to exclude the actual source dir
${WORKDIR}/${BPN}${PV} from pseudo database specifically to fix the
above do_install failure.

[1] https://downloads.sourceforge.net/tcl/tcl8.6.0-src.tar.gz
[2] https://git.openembedded.org/openembedded-core/tree/meta/classes/base.bbclass#n396

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 meta/recipes-devtools/tcltk/tcl_8.6.10.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/tcltk/tcl_8.6.10.bb b/meta/recipes-devtools/tcltk/tcl_8.6.10.bb
index aedd96b021..e6feb25a7e 100644
--- a/meta/recipes-devtools/tcltk/tcl_8.6.10.bb
+++ b/meta/recipes-devtools/tcltk/tcl_8.6.10.bb
@@ -32,6 +32,7 @@ SRC_URI_class-native = "${BASE_SRC_URI}"
 
 S = "${WORKDIR}/${BPN}${PV}/unix"
 
+PSEUDO_IGNORE_PATHS .= ",${WORKDIR}/${BPN}${PV}"
 VER = "${PV}"
 
 inherit autotools ptest binconfig update-alternatives
-- 
2.17.1