* [Intel-wired-lan] [PATCH v1 1/1] e1000e: add rtnl_lock() to e1000_reset_task
@ 2020-10-21 11:59 Vitaly Lifshits
0 siblings, 0 replies; only message in thread
From: Vitaly Lifshits @ 2020-10-21 11:59 UTC (permalink / raw)
To: intel-wired-lan
A possible race condition was found in e1000_reset_task,
after discovering a similar issue in igb driver
(024a8168b7 igb: reinit_locked() should be called with rtnl_lock).
Added rtnl_lock() and rtnl_unlock() to avoid this.
Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
Suggested-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index ee6a5f0cb16c..ab2cf4540425 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -5990,15 +5990,19 @@ static void e1000_reset_task(struct work_struct *work)
struct e1000_adapter *adapter;
adapter = container_of(work, struct e1000_adapter, reset_task);
+ rtnl_lock();
/* don't run the task if already down */
- if (test_bit(__E1000_DOWN, &adapter->state))
+ if (test_bit(__E1000_DOWN, &adapter->state)) {
+ rtnl_unlock();
return;
+ }
if (!(adapter->flags & FLAG_RESTART_NOW)) {
e1000e_dump(adapter);
e_err("Reset adapter unexpectedly\n");
}
e1000e_reinit_locked(adapter);
+ rtnl_unlock();
}
/**
--
2.11.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-21 11:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-21 11:59 [Intel-wired-lan] [PATCH v1 1/1] e1000e: add rtnl_lock() to e1000_reset_task Vitaly Lifshits
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.