* [PATCH] log: Tidy up documentation
@ 2020-10-14 1:55 Simon Glass
2020-10-23 0:30 ` Tom Rini
2020-10-23 0:30 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Simon Glass @ 2020-10-14 1:55 UTC (permalink / raw)
To: u-boot
Fix up the documentation which was lost in a merge conflict in the
conversion to RST.
Fixes: 52d3df7fefe ("log: Allow LOG_DEBUG to always enable log output")
Signed-off-by: Simon Glass <sjg@chromium.org>
---
doc/develop/logging.rst | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/doc/develop/logging.rst b/doc/develop/logging.rst
index 7ce8482ab6d..28340a4aac7 100644
--- a/doc/develop/logging.rst
+++ b/doc/develop/logging.rst
@@ -83,11 +83,8 @@ Sometimes it is useful to turn on logging just in one file. You can use this
#define LOG_DEBUG
to enable building in of all logging statements in a single file. Put it at
-the top of the file, before any #includes.
-
-To actually get U-Boot to output this you need to also set the default logging
-level - e.g. set CONFIG_LOG_DEFAULT_LEVEL to 7 (LOGL_DEBUG) or more. Otherwise
-debug output is suppressed and will not be generated.
+the top of the file, before any #includes. This overrides any log-level setting
+in U-Boot, including CONFIG_LOG_DEFAULT_LEVEL, but just for that file.
Convenience functions
@@ -111,6 +108,12 @@ LOG_CATEGORY, which you can only define once per file, above all #includes, e.g.
#define LOG_CATEGORY LOGC_ALLOC
+or
+
+.. code-block:: c
+
+ #define LOG_CATEGORY UCLASS_SPI
+
Remember that all uclasses IDs are log categories too.
--
2.28.0.1011.ga647a8990f-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] log: Tidy up documentation
2020-10-14 1:55 [PATCH] log: Tidy up documentation Simon Glass
@ 2020-10-23 0:30 ` Tom Rini
2020-10-23 0:30 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-10-23 0:30 UTC (permalink / raw)
To: u-boot
On Tue, Oct 13, 2020 at 07:55:07PM -0600, Simon Glass wrote:
> Fix up the documentation which was lost in a merge conflict in the
> conversion to RST.
>
> Fixes: 52d3df7fefe ("log: Allow LOG_DEBUG to always enable log output")
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201022/8b79889b/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] log: Tidy up documentation
2020-10-14 1:55 [PATCH] log: Tidy up documentation Simon Glass
2020-10-23 0:30 ` Tom Rini
@ 2020-10-23 0:30 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-10-23 0:30 UTC (permalink / raw)
To: u-boot
On Tue, Oct 13, 2020 at 07:55:07PM -0600, Simon Glass wrote:
> Fix up the documentation which was lost in a merge conflict in the
> conversion to RST.
>
> Fixes: 52d3df7fefe ("log: Allow LOG_DEBUG to always enable log output")
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201022/690e3811/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-23 0:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 1:55 [PATCH] log: Tidy up documentation Simon Glass
2020-10-23 0:30 ` Tom Rini
2020-10-23 0:30 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.