From: Dave Ertman <david.m.ertman@intel.com> To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, linux-rdma@vger.kernel.org, jgg@nvidia.com, dledford@redhat.com, netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, gregkh@linuxfoundation.org, ranjani.sridharan@linux.intel.com, pierre-louis.bossart@linux.intel.com, fred.oh@linux.intel.com, parav@mellanox.com, shiraz.saleem@intel.com, dan.j.williams@intel.com, kiran.patil@intel.com, linux-kernel@vger.kernel.org, leonro@nvidia.com Subject: [PATCH v3 10/10] ASoC: SOF: Intel: CNL: register probes client Date: Thu, 22 Oct 2020 17:33:38 -0700 [thread overview] Message-ID: <20201023003338.1285642-11-david.m.ertman@intel.com> (raw) In-Reply-To: <20201023003338.1285642-1-david.m.ertman@intel.com> From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Register the client device for probes support on the CNL platform. Creating this client device alleviates the need for modifying the sound card definitions in the existing machine drivers to add support for the new probes feature in the FW. This will result in the creation of a separate sound card that can be used for audio data extraction from user specified points in the audio pipeline. Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Tested-by: Fred Oh <fred.oh@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Dave Ertman <david.m.ertman@intel.com> --- sound/soc/sof/intel/cnl.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/sound/soc/sof/intel/cnl.c b/sound/soc/sof/intel/cnl.c index 20afb622c315..6d15b871dc17 100644 --- a/sound/soc/sof/intel/cnl.c +++ b/sound/soc/sof/intel/cnl.c @@ -19,6 +19,7 @@ #include "hda.h" #include "hda-ipc.h" #include "../sof-audio.h" +#include "../sof-client.h" #include "intel-client.h" static const struct snd_sof_debugfs_map cnl_dsp_debugfs[] = { @@ -233,12 +234,26 @@ void cnl_ipc_dump(struct snd_sof_dev *sdev) static int cnl_register_clients(struct snd_sof_dev *sdev) { - return intel_register_ipc_test_clients(sdev); + int ret; + + ret = intel_register_ipc_test_clients(sdev); + if (ret < 0) + return ret; + +#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_PROBES) + return sof_client_dev_register(sdev, "probes", 0); +#endif + + return 0; } static void cnl_unregister_clients(struct snd_sof_dev *sdev) { intel_unregister_ipc_test_clients(sdev); + +#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_PROBES) + sof_client_dev_unregister(sdev, "probes", 0); +#endif } /* cannonlake ops */ @@ -409,3 +424,4 @@ const struct sof_intel_dsp_desc jsl_chip_info = { }; EXPORT_SYMBOL_NS(jsl_chip_info, SND_SOC_SOF_INTEL_HDA_COMMON); MODULE_IMPORT_NS(SND_SOC_SOF_INTEL_CLIENT); +MODULE_IMPORT_NS(SND_SOC_SOF_CLIENT); -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Dave Ertman <david.m.ertman@intel.com> To: alsa-devel@alsa-project.org Cc: parav@mellanox.com, tiwai@suse.de, netdev@vger.kernel.org, leonro@nvidia.com, ranjani.sridharan@linux.intel.com, pierre-louis.bossart@linux.intel.com, fred.oh@linux.intel.com, linux-rdma@vger.kernel.org, dledford@redhat.com, broonie@kernel.org, jgg@nvidia.com, gregkh@linuxfoundation.org, kuba@kernel.org, dan.j.williams@intel.com, shiraz.saleem@intel.com, davem@davemloft.net, linux-kernel@vger.kernel.org, kiran.patil@intel.com Subject: [PATCH v3 10/10] ASoC: SOF: Intel: CNL: register probes client Date: Thu, 22 Oct 2020 17:33:38 -0700 [thread overview] Message-ID: <20201023003338.1285642-11-david.m.ertman@intel.com> (raw) In-Reply-To: <20201023003338.1285642-1-david.m.ertman@intel.com> From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Register the client device for probes support on the CNL platform. Creating this client device alleviates the need for modifying the sound card definitions in the existing machine drivers to add support for the new probes feature in the FW. This will result in the creation of a separate sound card that can be used for audio data extraction from user specified points in the audio pipeline. Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Tested-by: Fred Oh <fred.oh@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Dave Ertman <david.m.ertman@intel.com> --- sound/soc/sof/intel/cnl.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/sound/soc/sof/intel/cnl.c b/sound/soc/sof/intel/cnl.c index 20afb622c315..6d15b871dc17 100644 --- a/sound/soc/sof/intel/cnl.c +++ b/sound/soc/sof/intel/cnl.c @@ -19,6 +19,7 @@ #include "hda.h" #include "hda-ipc.h" #include "../sof-audio.h" +#include "../sof-client.h" #include "intel-client.h" static const struct snd_sof_debugfs_map cnl_dsp_debugfs[] = { @@ -233,12 +234,26 @@ void cnl_ipc_dump(struct snd_sof_dev *sdev) static int cnl_register_clients(struct snd_sof_dev *sdev) { - return intel_register_ipc_test_clients(sdev); + int ret; + + ret = intel_register_ipc_test_clients(sdev); + if (ret < 0) + return ret; + +#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_PROBES) + return sof_client_dev_register(sdev, "probes", 0); +#endif + + return 0; } static void cnl_unregister_clients(struct snd_sof_dev *sdev) { intel_unregister_ipc_test_clients(sdev); + +#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_PROBES) + sof_client_dev_unregister(sdev, "probes", 0); +#endif } /* cannonlake ops */ @@ -409,3 +424,4 @@ const struct sof_intel_dsp_desc jsl_chip_info = { }; EXPORT_SYMBOL_NS(jsl_chip_info, SND_SOC_SOF_INTEL_HDA_COMMON); MODULE_IMPORT_NS(SND_SOC_SOF_INTEL_CLIENT); +MODULE_IMPORT_NS(SND_SOC_SOF_CLIENT); -- 2.26.2
next prev parent reply other threads:[~2020-10-23 0:35 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-23 0:33 [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support Dave Ertman 2020-10-23 0:33 ` Dave Ertman 2020-10-23 0:33 ` [PATCH v3 01/10] Add auxiliary bus support Dave Ertman 2020-10-23 0:33 ` Dave Ertman 2020-11-05 9:19 ` Dan Williams 2020-11-05 9:19 ` Dan Williams 2020-11-05 9:47 ` Leon Romanovsky 2020-11-05 9:47 ` Leon Romanovsky 2020-11-05 17:12 ` Dan Williams 2020-11-05 17:12 ` Dan Williams 2020-11-05 19:30 ` Leon Romanovsky 2020-11-05 19:30 ` Leon Romanovsky 2020-11-05 20:27 ` Dan Williams 2020-11-05 20:27 ` Dan Williams 2020-11-05 20:22 ` Greg KH 2020-11-05 20:22 ` Greg KH 2020-11-05 20:24 ` Dan Williams 2020-11-05 20:24 ` Dan Williams 2020-11-05 19:27 ` Ertman, David M 2020-11-05 19:27 ` Ertman, David M 2020-11-05 19:32 ` Pierre-Louis Bossart 2020-11-05 19:32 ` Pierre-Louis Bossart 2020-11-05 19:37 ` Leon Romanovsky 2020-11-05 19:37 ` Leon Romanovsky 2020-11-05 19:35 ` Leon Romanovsky 2020-11-05 19:35 ` Leon Romanovsky 2020-11-05 20:52 ` Ertman, David M 2020-11-05 20:52 ` Ertman, David M 2020-11-05 19:40 ` Parav Pandit 2020-11-05 19:40 ` Parav Pandit 2020-11-05 20:26 ` Dan Williams 2020-11-05 20:26 ` Dan Williams 2020-11-05 20:37 ` Parav Pandit 2020-11-05 20:37 ` Parav Pandit 2020-11-06 19:35 ` Mark Brown 2020-11-06 19:35 ` Mark Brown 2020-11-10 7:23 ` Oded Gabbay 2020-11-10 7:23 ` Oded Gabbay 2020-11-05 22:00 ` Dan Williams 2020-11-05 22:00 ` Dan Williams 2020-11-05 23:48 ` Ertman, David M 2020-11-05 23:48 ` Ertman, David M 2020-11-13 15:50 ` Greg KH 2020-11-13 15:50 ` Greg KH 2020-11-13 16:07 ` Ertman, David M 2020-11-13 16:07 ` Ertman, David M 2020-11-13 23:21 ` Greg KH 2020-11-13 23:21 ` Greg KH 2020-11-15 6:48 ` Leon Romanovsky 2020-11-15 6:48 ` Leon Romanovsky 2020-10-23 0:33 ` [PATCH v3 02/10] ASoC: SOF: Introduce descriptors for SOF client Dave Ertman 2020-10-23 0:33 ` Dave Ertman 2020-10-23 0:33 ` [PATCH v3 03/10] ASoC: SOF: Create client driver for IPC test Dave Ertman 2020-10-23 0:33 ` Dave Ertman 2020-10-23 0:33 ` [PATCH v3 04/10] ASoC: SOF: ops: Add ops for client registration Dave Ertman 2020-10-23 0:33 ` Dave Ertman 2020-10-23 0:33 ` [PATCH v3 05/10] ASoC: SOF: Intel: Define " Dave Ertman 2020-10-23 0:33 ` Dave Ertman 2020-10-23 0:33 ` [PATCH v3 06/10] ASoC: SOF: Intel: Remove IPC flood test support in SOF core Dave Ertman 2020-10-23 0:33 ` Dave Ertman 2020-10-23 0:33 ` [PATCH v3 07/10] ASoC: SOF: sof-client: Add client APIs to access probes ops Dave Ertman 2020-10-23 0:33 ` Dave Ertman 2020-10-23 0:33 ` [PATCH v3 08/10] ASoC: SOF: compress: move and export sof_probe_compr_ops Dave Ertman 2020-10-23 0:33 ` Dave Ertman 2020-10-23 0:33 ` [PATCH v3 09/10] ASoC: SOF: Add new client driver for probes support Dave Ertman 2020-10-23 0:33 ` Dave Ertman 2020-10-23 0:33 ` Dave Ertman [this message] 2020-10-23 0:33 ` [PATCH v3 10/10] ASoC: SOF: Intel: CNL: register probes client Dave Ertman 2020-10-23 6:49 ` [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support Leon Romanovsky 2020-10-23 6:56 ` Greg KH 2020-10-23 6:56 ` Greg KH 2020-10-23 15:48 ` Leon Romanovsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201023003338.1285642-11-david.m.ertman@intel.com \ --to=david.m.ertman@intel.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=davem@davemloft.net \ --cc=dledford@redhat.com \ --cc=fred.oh@linux.intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=jgg@nvidia.com \ --cc=kiran.patil@intel.com \ --cc=kuba@kernel.org \ --cc=leonro@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=parav@mellanox.com \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=ranjani.sridharan@linux.intel.com \ --cc=shiraz.saleem@intel.com \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.