* [PATCH] ext4: fix double locking in ext4_fc_commit_dentry_updates()
@ 2020-10-23 16:13 Harshad Shirwadkar
2020-10-28 3:52 ` Theodore Y. Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Harshad Shirwadkar @ 2020-10-23 16:13 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso, Harshad Shirwadkar
Fixed double locking of sbi->s_fc_lock in the above function
as reported by kernel-test-robot.
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
---
fs/ext4/fast_commit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 447c8d93f480..1d72f8f13a05 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -964,7 +964,6 @@ static int ext4_fc_commit_dentry_updates(journal_t *journal, u32 *crc)
fc_dentry->fcd_parent, fc_dentry->fcd_ino,
fc_dentry->fcd_name.len,
fc_dentry->fcd_name.name, crc)) {
- spin_lock(&sbi->s_fc_lock);
ret = -ENOSPC;
goto lock_and_exit;
}
--
2.29.0.rc2.309.g374f81d7ae-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: fix double locking in ext4_fc_commit_dentry_updates()
2020-10-23 16:13 [PATCH] ext4: fix double locking in ext4_fc_commit_dentry_updates() Harshad Shirwadkar
@ 2020-10-28 3:52 ` Theodore Y. Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Y. Ts'o @ 2020-10-28 3:52 UTC (permalink / raw)
To: Harshad Shirwadkar; +Cc: linux-ext4
On Fri, Oct 23, 2020 at 09:13:39AM -0700, Harshad Shirwadkar wrote:
> Fixed double locking of sbi->s_fc_lock in the above function
> as reported by kernel-test-robot.
>
> Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-29 2:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-23 16:13 [PATCH] ext4: fix double locking in ext4_fc_commit_dentry_updates() Harshad Shirwadkar
2020-10-28 3:52 ` Theodore Y. Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.