All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/s390-tools: add zlib dependency
@ 2020-10-20 10:39 Alexander Egorenkov
  2020-10-24 20:55 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Egorenkov @ 2020-10-20 10:39 UTC (permalink / raw)
  To: buildroot

zlib is required to build s390-tools and cannot be disabled for now
due to libvmdump.

Fixes:

$BUILD_DIR/host/bin/s390x-buildroot-linux-gnu-g++ ... -c vmdump_convert.cpp -o vmdump_convert.o
lkcd_dump.cpp:15:10: fatal error: zlib.h: No such file or directory
   15 | #include <zlib.h>
      |          ^~~~~~~~
compilation terminated.

Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
---
 package/s390-tools/Config.in     | 1 +
 package/s390-tools/s390-tools.mk | 1 +
 2 files changed, 2 insertions(+)

diff --git a/package/s390-tools/Config.in b/package/s390-tools/Config.in
index a553b5eeab..4aede4e265 100644
--- a/package/s390-tools/Config.in
+++ b/package/s390-tools/Config.in
@@ -7,6 +7,7 @@ config BR2_PACKAGE_S390_TOOLS
 	depends on BR2_s390x
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_USES_GLIBC
+	select BR2_PACKAGE_ZLIB
 	help
 	  Tools for use with the s390 Linux kernel and device drivers.
 
diff --git a/package/s390-tools/s390-tools.mk b/package/s390-tools/s390-tools.mk
index 4d4c8188fe..d186f85cd3 100644
--- a/package/s390-tools/s390-tools.mk
+++ b/package/s390-tools/s390-tools.mk
@@ -8,6 +8,7 @@ S390_TOOLS_VERSION = 2.14.0
 S390_TOOLS_SITE = $(call github,ibm-s390-tools,s390-tools,v$(S390_TOOLS_VERSION))
 S390_TOOLS_LICENSE = MIT
 S390_TOOLS_LICENSE_FILES = LICENSE
+S390_TOOLS_DEPENDENCIES = zlib
 
 S390_TOOLS_MAKE_OPTS = \
 	ARCH=$(BR2_ARCH) \
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] package/s390-tools: add zlib dependency
  2020-10-20 10:39 [Buildroot] [PATCH 1/1] package/s390-tools: add zlib dependency Alexander Egorenkov
@ 2020-10-24 20:55 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2020-10-24 20:55 UTC (permalink / raw)
  To: buildroot

On Tue, 20 Oct 2020 12:39:04 +0200
Alexander Egorenkov <egorenar@linux.ibm.com> wrote:

> zlib is required to build s390-tools and cannot be disabled for now
> due to libvmdump.
> 
> Fixes:
> 
> $BUILD_DIR/host/bin/s390x-buildroot-linux-gnu-g++ ... -c vmdump_convert.cpp -o vmdump_convert.o
> lkcd_dump.cpp:15:10: fatal error: zlib.h: No such file or directory
>    15 | #include <zlib.h>
>       |          ^~~~~~~~
> compilation terminated.
> 
> Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> ---
>  package/s390-tools/Config.in     | 1 +
>  package/s390-tools/s390-tools.mk | 1 +
>  2 files changed, 2 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-24 20:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 10:39 [Buildroot] [PATCH 1/1] package/s390-tools: add zlib dependency Alexander Egorenkov
2020-10-24 20:55 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.