Re: [igt-dev] [PATCH i-g-t] tests/kms_psr2_su: Skip frontbuffer test in TGL

[Petri Latvala <petri.latvala@intel.com>]

On Fri, Oct 23, 2020 at 04:11:51PM -0700, José Roberto de Souza wrote:
> Due the commit 71c1a4998320 ("drm/i915/tgl/psr: Fix glitches when
> doing frontbuffer modifications"), frontbuffer test is expected to
> fail on TGL, so here skiping this test on TGL.
> When PSR issues is fixed the patch above will be reverted and we
> can revert this skip too.

How does the previous failure behave? I mean in the sense that what
does this skip gain? The skip will have to be cibuglog-filtered too so
no gain on that side.

Did the fail kill the machine, or is this just for saving runtime?


-- 
Petri Latvala



> 
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  tests/kms_psr2_su.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/kms_psr2_su.c b/tests/kms_psr2_su.c
> index d549d9a31..d554052f0 100644
> --- a/tests/kms_psr2_su.c
> +++ b/tests/kms_psr2_su.c
> @@ -279,6 +279,11 @@ igt_main
>  
>  	for (data.op = PAGE_FLIP; data.op < LAST; data.op++) {
>  		igt_subtest_f("%s", op_str(data.op)) {
> +			if (data.op == FRONTBUFFER) {
> +				const uint16_t devid = intel_get_drm_devid(data.drm_fd);
> +				igt_require(!IS_TIGERLAKE(devid));
> +			}
> +
>  			prepare(&data);
>  			run(&data);
>  			cleanup(&data);
> -- 
> 2.29.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev