From: Sasha Levin <sashal@kernel.org> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wen Gong <wgong@codeaurora.org>, Kalle Valo <kvalo@codeaurora.org>, Sasha Levin <sashal@kernel.org>, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 13/60] ath10k: start recovery process when payload length exceeds max htc length for sdio Date: Mon, 26 Oct 2020 20:03:28 -0400 [thread overview] Message-ID: <20201027000415.1026364-13-sashal@kernel.org> (raw) In-Reply-To: <20201027000415.1026364-1-sashal@kernel.org> From: Wen Gong <wgong@codeaurora.org> [ Upstream commit 2fd3c8f34d08af0a6236085f9961866ad92ef9ec ] When simulate random transfer fail for sdio write and read, it happened "payload length exceeds max htc length" and recovery later sometimes. Test steps: 1. Add config and update kernel: CONFIG_FAIL_MMC_REQUEST=y CONFIG_FAULT_INJECTION=y CONFIG_FAULT_INJECTION_DEBUG_FS=y 2. Run simulate fail: cd /sys/kernel/debug/mmc1/fail_mmc_request echo 10 > probability echo 10 > times # repeat until hitting issues 3. It happened payload length exceeds max htc length. [ 199.935506] ath10k_sdio mmc1:0001:1: payload length 57005 exceeds max htc length: 4088 .... [ 264.990191] ath10k_sdio mmc1:0001:1: payload length 57005 exceeds max htc length: 4088 4. after some time, such as 60 seconds, it start recovery which triggered by wmi command timeout for periodic scan. [ 269.229232] ieee80211 phy0: Hardware restart was requested [ 269.734693] ath10k_sdio mmc1:0001:1: device successfully recovered The simulate fail of sdio is not a real sdio transter fail, it only set an error status in mmc_should_fail_request after the transfer end, actually the transfer is success, then sdio_io_rw_ext_helper will return error status and stop transfer the left data. For example, the really RX len is 286 bytes, then it will split to 2 blocks in sdio_io_rw_ext_helper, one is 256 bytes, left is 30 bytes, if the first 256 bytes get an error status by mmc_should_fail_request,then the left 30 bytes will not read in this RX operation. Then when the next RX arrive, the left 30 bytes will be considered as the header of the read, the top 4 bytes of the 30 bytes will be considered as lookaheads, but actually the 4 bytes is not the lookaheads, so the len from this lookaheads is not correct, it exceeds max htc length 4088 sometimes. When happened exceeds, the buffer chain is not matched between firmware and ath10k, then it need to start recovery ASAP. Recently then recovery will be started by wmi command timeout, but it will be long time later, for example, it is 60+ seconds later from the periodic scan, if it does not have periodic scan, it will be longer. Start recovery when it happened "payload length exceeds max htc length" will be reasonable. This patch only effect sdio chips. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. Signed-off-by: Wen Gong <wgong@codeaurora.org> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20200108031957.22308-3-wgong@codeaurora.org Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/net/wireless/ath/ath10k/sdio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index 0cdaecb0e28a9..28d86da65c051 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -561,6 +561,10 @@ static int ath10k_sdio_mbox_rx_alloc(struct ath10k *ar, le16_to_cpu(htc_hdr->len), ATH10K_HTC_MBOX_MAX_PAYLOAD_LENGTH); ret = -ENOMEM; + + queue_work(ar->workqueue, &ar->restart_work); + ath10k_warn(ar, "exceeds length, start recovery\n"); + goto err; } -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sasha Levin <sashal@kernel.org>, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Wen Gong <wgong@codeaurora.org>, Kalle Valo <kvalo@codeaurora.org> Subject: [PATCH AUTOSEL 4.19 13/60] ath10k: start recovery process when payload length exceeds max htc length for sdio Date: Mon, 26 Oct 2020 20:03:28 -0400 [thread overview] Message-ID: <20201027000415.1026364-13-sashal@kernel.org> (raw) In-Reply-To: <20201027000415.1026364-1-sashal@kernel.org> From: Wen Gong <wgong@codeaurora.org> [ Upstream commit 2fd3c8f34d08af0a6236085f9961866ad92ef9ec ] When simulate random transfer fail for sdio write and read, it happened "payload length exceeds max htc length" and recovery later sometimes. Test steps: 1. Add config and update kernel: CONFIG_FAIL_MMC_REQUEST=y CONFIG_FAULT_INJECTION=y CONFIG_FAULT_INJECTION_DEBUG_FS=y 2. Run simulate fail: cd /sys/kernel/debug/mmc1/fail_mmc_request echo 10 > probability echo 10 > times # repeat until hitting issues 3. It happened payload length exceeds max htc length. [ 199.935506] ath10k_sdio mmc1:0001:1: payload length 57005 exceeds max htc length: 4088 .... [ 264.990191] ath10k_sdio mmc1:0001:1: payload length 57005 exceeds max htc length: 4088 4. after some time, such as 60 seconds, it start recovery which triggered by wmi command timeout for periodic scan. [ 269.229232] ieee80211 phy0: Hardware restart was requested [ 269.734693] ath10k_sdio mmc1:0001:1: device successfully recovered The simulate fail of sdio is not a real sdio transter fail, it only set an error status in mmc_should_fail_request after the transfer end, actually the transfer is success, then sdio_io_rw_ext_helper will return error status and stop transfer the left data. For example, the really RX len is 286 bytes, then it will split to 2 blocks in sdio_io_rw_ext_helper, one is 256 bytes, left is 30 bytes, if the first 256 bytes get an error status by mmc_should_fail_request,then the left 30 bytes will not read in this RX operation. Then when the next RX arrive, the left 30 bytes will be considered as the header of the read, the top 4 bytes of the 30 bytes will be considered as lookaheads, but actually the 4 bytes is not the lookaheads, so the len from this lookaheads is not correct, it exceeds max htc length 4088 sometimes. When happened exceeds, the buffer chain is not matched between firmware and ath10k, then it need to start recovery ASAP. Recently then recovery will be started by wmi command timeout, but it will be long time later, for example, it is 60+ seconds later from the periodic scan, if it does not have periodic scan, it will be longer. Start recovery when it happened "payload length exceeds max htc length" will be reasonable. This patch only effect sdio chips. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. Signed-off-by: Wen Gong <wgong@codeaurora.org> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20200108031957.22308-3-wgong@codeaurora.org Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/net/wireless/ath/ath10k/sdio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index 0cdaecb0e28a9..28d86da65c051 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -561,6 +561,10 @@ static int ath10k_sdio_mbox_rx_alloc(struct ath10k *ar, le16_to_cpu(htc_hdr->len), ATH10K_HTC_MBOX_MAX_PAYLOAD_LENGTH); ret = -ENOMEM; + + queue_work(ar->workqueue, &ar->restart_work); + ath10k_warn(ar, "exceeds length, start recovery\n"); + goto err; } -- 2.25.1 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-10-27 0:20 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-27 0:03 [PATCH AUTOSEL 4.19 01/60] powerpc/powernv/smp: Fix spurious DBG() warning Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 02/60] powerpc: select ARCH_WANT_IRQS_OFF_ACTIVATE_MM Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 03/60] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 04/60] f2fs: add trace exit in exception path Sasha Levin 2020-10-27 0:03 ` [f2fs-dev] " Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 05/60] f2fs: fix uninit-value in f2fs_lookup Sasha Levin 2020-10-27 0:03 ` [f2fs-dev] " Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 06/60] f2fs: fix to check segment boundary during SIT page readahead Sasha Levin 2020-10-27 0:03 ` [f2fs-dev] " Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 07/60] um: change sigio_spinlock to a mutex Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 08/60] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRACE Sasha Levin 2020-10-27 7:59 ` Sergei Shtylyov 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 09/60] ARM: 8997/2: hw_breakpoint: Handle inexact watchpoint addresses Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 10/60] power: supply: bq27xxx: report "not charging" on all types Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 11/60] xfs: fix realtime bitmap/summary file truncation when growing rt volume Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 12/60] video: fbdev: pvr2fb: initialize variables Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` Sasha Levin [this message] 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 13/60] ath10k: start recovery process when payload length exceeds max htc length for sdio Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 14/60] ath10k: fix VHT NSS calculation when STBC is enabled Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 15/60] drm/brige/megachips: Add checking if ge_b850v3_lvds_init() is working correctly Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 16/60] media: videodev2.h: RGB BT2020 and HSV are always full range Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 17/60] media: platform: Improve queue set up flow for bug fixing Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 18/60] usb: typec: tcpm: During PR_SWAP, source caps should be sent only after tSwapSourceStart Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 19/60] media: tw5864: check status of tw5864_frameinterval_get Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 20/60] media: imx274: fix frame interval handling Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 21/60] mmc: via-sdmmc: Fix data race bug Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 22/60] drm/bridge/synopsys: dsi: add support for non-continuous HS clock Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 23/60] arm64: topology: Stop using MPIDR for topology information Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 24/60] printk: reduce LOG_BUF_SHIFT range for H8300 Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 25/60] ia64: kprobes: Use generic kretprobe trampoline handler Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 26/60] kgdb: Make "kgdbcon" work properly with "kgdb_earlycon" Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 27/60] media: uvcvideo: Fix dereference of out-of-bound list iterator Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 28/60] riscv: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-11-06 5:26 ` Palmer Dabbelt 2020-11-06 5:26 ` Palmer Dabbelt 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 29/60] cpufreq: sti-cpufreq: add stih418 support Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 30/60] USB: adutux: fix debugging Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 31/60] uio: free uio id after uio file node is freed Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 32/60] usb: xhci: omit duplicate actions when suspending a runtime suspended host Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 33/60] arm64/mm: return cpu_all_mask when node is NUMA_NO_NODE Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 34/60] xfs: don't free rt blocks when we're doing a REMAP bunmapi call Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 35/60] ACPI: Add out of bounds and numa_off protections to pxm_to_node() Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 36/60] genirq: Add stub for set_handle_irq() when !GENERIC_IRQ_MULTI_HANDLER Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 37/60] dm: change max_io_len() to use blk_max_size_offset() Sasha Levin 2020-10-27 0:03 ` [dm-devel] " Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 38/60] drivers/net/wan/hdlc_fr: Correctly handle special skb->protocol values Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 39/60] bus/fsl_mc: Do not rely on caller to provide non NULL mc_io Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 40/60] power: supply: test_power: add missing newlines when printing parameters by sysfs Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 41/60] drm/amd/display: HDMI remote sink need mode validation for Linux Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 42/60] btrfs: fix replace of seed device Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 43/60] md/bitmap: md_bitmap_get_counter returns wrong blocks Sasha Levin 2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 44/60] bnxt_en: Log unknown link speed appropriately Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 45/60] rpmsg: glink: Use complete_all for open states Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 46/60] clk: ti: clockdomain: fix static checker warning Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 47/60] net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 48/60] drivers: watchdog: rdc321x_wdt: Fix race condition bugs Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 49/60] ext4: Detect already used quota file early Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 50/60] gfs2: add validation checks for size of superblock Sasha Levin 2020-10-27 0:04 ` [Cluster-devel] " Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 51/60] cifs: handle -EINTR in cifs_setattr Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 52/60] arm64: dts: renesas: ulcb: add full-pwr-cycle-in-suspend into eMMC nodes Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 53/60] ARM: dts: omap4: Fix sgx clock rate for 4430 Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 54/60] memory: emif: Remove bogus debugfs error handling Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 55/60] ARM: dts: s5pv210: remove DMA controller bus node name to fix dtschema warnings Sasha Levin 2020-10-27 0:04 ` Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 56/60] ARM: dts: s5pv210: move PMU node out of clock controller Sasha Levin 2020-10-27 0:04 ` Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 57/60] ARM: dts: s5pv210: remove dedicated 'audio-subsystem' node Sasha Levin 2020-10-27 0:04 ` Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 58/60] nbd: make the config put is called before the notifying the waiter Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 59/60] sgl_alloc_order: fix memory leak Sasha Levin 2020-10-27 0:04 ` [PATCH AUTOSEL 4.19 60/60] nvme-rdma: fix crash when connect rejected Sasha Levin 2020-10-27 0:04 ` Sasha Levin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201027000415.1026364-13-sashal@kernel.org \ --to=sashal@kernel.org \ --cc=ath10k@lists.infradead.org \ --cc=kvalo@codeaurora.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=stable@vger.kernel.org \ --cc=wgong@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.