From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Marcus Cooper <codekipper@gmail.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v8 03/14] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit
Date: Tue, 27 Oct 2020 18:50:16 +0100 [thread overview]
Message-ID: <20201027175016.ffx7lokjbscczvox@gilmour.lan> (raw)
In-Reply-To: <20201026185239.379417-4-peron.clem@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Mon, Oct 26, 2020 at 07:52:28PM +0100, Clément Péron wrote:
> We are actually using a complex formula to just return a bunch of
> simple values. Also this formula is wrong for sun4i when calling
> get_wss() the function return 4 instead of 3.
>
> Replace this with a simpler switch case.
>
> Also drop the i2s params which is unused and return a simple int as
> returning an error code could be out of range for an s8 and there is
> no optim to return a s8 here.
>
> Fixes: 619c15f7fac9 ("ASoC: sun4i-i2s: Change SR and WSS computation")
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-sunxi@googlegroups.com, Takashi Iwai <tiwai@suse.com>,
Marcus Cooper <codekipper@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 03/14] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit
Date: Tue, 27 Oct 2020 18:50:16 +0100 [thread overview]
Message-ID: <20201027175016.ffx7lokjbscczvox@gilmour.lan> (raw)
In-Reply-To: <20201026185239.379417-4-peron.clem@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Mon, Oct 26, 2020 at 07:52:28PM +0100, Clément Péron wrote:
> We are actually using a complex formula to just return a bunch of
> simple values. Also this formula is wrong for sun4i when calling
> get_wss() the function return 4 instead of 3.
>
> Replace this with a simpler switch case.
>
> Also drop the i2s params which is unused and return a simple int as
> returning an error code could be out of range for an s8 and there is
> no optim to return a s8 here.
>
> Fixes: 619c15f7fac9 ("ASoC: sun4i-i2s: Change SR and WSS computation")
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-sunxi@googlegroups.com, Takashi Iwai <tiwai@suse.com>,
Jaroslav Kysela <perex@perex.cz>,
Marcus Cooper <codekipper@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 03/14] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit
Date: Tue, 27 Oct 2020 18:50:16 +0100 [thread overview]
Message-ID: <20201027175016.ffx7lokjbscczvox@gilmour.lan> (raw)
In-Reply-To: <20201026185239.379417-4-peron.clem@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 714 bytes --]
On Mon, Oct 26, 2020 at 07:52:28PM +0100, Clément Péron wrote:
> We are actually using a complex formula to just return a bunch of
> simple values. Also this formula is wrong for sun4i when calling
> get_wss() the function return 4 instead of 3.
>
> Replace this with a simpler switch case.
>
> Also drop the i2s params which is unused and return a simple int as
> returning an error code could be out of range for an s8 and there is
> no optim to return a s8 here.
>
> Fixes: 619c15f7fac9 ("ASoC: sun4i-i2s: Change SR and WSS computation")
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-27 17:50 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 18:52 [PATCH v8 00/14] Add Allwinner H3/H5/H6/A64 HDMI audio Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` [PATCH v8 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-27 17:49 ` Maxime Ripard
2020-10-27 17:49 ` Maxime Ripard
2020-10-27 17:49 ` Maxime Ripard
2020-10-26 18:52 ` [PATCH v8 02/14] ASoC: sun4i-i2s: Add support for H6 I2S Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-27 17:49 ` Maxime Ripard
2020-10-27 17:49 ` Maxime Ripard
2020-10-27 17:49 ` Maxime Ripard
2020-10-26 18:52 ` [PATCH v8 03/14] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-27 17:50 ` Maxime Ripard [this message]
2020-10-27 17:50 ` Maxime Ripard
2020-10-27 17:50 ` Maxime Ripard
2020-10-26 18:52 ` [PATCH v8 04/14] ASoC: sun4i-i2s: Set sign extend sample Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-27 17:50 ` Maxime Ripard
2020-10-27 17:50 ` Maxime Ripard
2020-10-27 17:50 ` Maxime Ripard
2020-10-26 18:52 ` [PATCH v8 05/14] ASoc: sun4i-i2s: Add 20 and 24 bit support Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` [PATCH v8 06/14] ASoC: sun4i-i2s: Fix sun8i volatile regs Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` [PATCH v8 07/14] ASoC: sun4i-i2s: Fix setting of FIFO modes Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-27 17:51 ` Maxime Ripard
2020-10-27 17:51 ` Maxime Ripard
2020-10-27 17:51 ` Maxime Ripard
2020-10-26 18:52 ` [PATCH v8 08/14] ASoC: sun4i-i2s: fix coding-style for callback definition Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` [PATCH v8 09/14] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` [PATCH v8 10/14] arm64: dts: allwinner: h6: Add I2S1 node Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` [PATCH v8 11/14] arm64: dts: allwinner: a64: Add I2S2 node Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` [PATCH v8 12/14] arm64: defconfig: Enable Allwinner i2s driver Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` [PATCH v8 13/14] dt-bindings: sound: sun4i-i2s: Document H3 with missing RX channel possibility Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` [PATCH v8 14/14] arm: dts: sunxi: h3/h5: Add I2S2 node Clément Péron
2020-10-26 18:52 ` Clément Péron
2020-10-26 18:52 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027175016.ffx7lokjbscczvox@gilmour.lan \
--to=maxime@cerno.tech \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=perex@perex.cz \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.