From: Aleksa Sarai <cyphar@cyphar.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT
Date: Wed, 28 Oct 2020 10:39:41 +1100 [thread overview]
Message-ID: <20201027233941.ux23xlzlzgv4ym5u@yavin.dot.cyphar.com> (raw)
In-Reply-To: <4ce6ba2c-8b23-78aa-47c0-8c9673273e8f@linuxfoundation.org>
[-- Attachment #1.1: Type: text/plain, Size: 1236 bytes --]
On 2020-10-27, Shuah Khan <skhan@linuxfoundation.org> wrote:
> On 10/7/20 4:36 AM, Aleksa Sarai wrote:
> > This was an oversight in the original implementation, as it makes no
> > sense to specify both scoping flags to the same openat2(2) invocation
> > (before this patch, the result of such an invocation was equivalent to
> > RESOLVE_IN_ROOT being ignored).
> >
> > This is a userspace-visible ABI change, but the only user of openat2(2)
> > at the moment is LXC which doesn't specify both flags and so no
> > userspace programs will break as a result.
> >
> > Cc: <stable@vger.kernel.org> # v5.6+
> > Fixes: fddb5d430ad9 ("open: introduce openat2(2) syscall")
> > Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> > Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> > ---
> > fs/open.c | 4 +++
> > tools/testing/selftests/openat2/openat2_test.c | 8 +++++++-
>
> You are combining fs change with selftest change.
>
> Is there a reason why these two changes are combined?
> 2 separate patches is better.
Not really, I'll split it into two patches.
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 171 bytes --]
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers
prev parent reply other threads:[~2020-10-27 23:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 10:36 [PATCH] openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT Aleksa Sarai
2020-10-07 10:36 ` Aleksa Sarai
2020-10-09 11:50 ` Christian Brauner
2020-10-09 11:50 ` Christian Brauner
2020-10-27 22:28 ` Shuah Khan
2020-10-27 22:28 ` Shuah Khan
2020-10-27 23:39 ` Aleksa Sarai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027233941.ux23xlzlzgv4ym5u@yavin.dot.cyphar.com \
--to=cyphar@cyphar.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.